Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Double Response (ERR_HTTP_HEADERS_SENT) in addProjectToCollection controller

オープン
  • 何か問題がありますか？
#3,964 コメント 5 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 3 日以内に返信

@dpoppe7 がすでに取り組んでいます。

2026年3月10日 から。

評価

この issue はまだ評価されていません。

説明

Bug
p5.js version

1.11.11

What is your operating system?

Mac OS

Web browser and version

Safari 17.6

Actual Behavior

The addProjectToCollection controller (found in server/controllers/collection.controller.js) contains a logic flaw in its Promise handling that leads to a server crash (ERR_HTTP_HEADERS_SENT).

When a validation error occurs (e.g. a collection or a project is not found), the updateCollection function correctly sends a failure response to the client. However, it then returns null to the next block in the Promise chain rather than "short-circuiting" the execution.

addProjectToCollection.js :

First response sent to client here.
Returning 'null' doesn't stop the Promise chain. It passes 'null' to the next .then() block.

function updateCollection([collection, project]) {
    if (collection == null) {
      sendFailure(404, 'Collection not found');
      return null;
    }

Then, even if updateCollection returned null, .then(populateReferences) runs.
Second response occurs when .then(sendSuccess), attempts to send 200OK and crash.

return Promise.all([collectionPromise, projectPromise])
  .then(updateCollection) 
  .then(populateReferences)
  .then(sendSuccess)         
  .catch(sendFailure);

Error in Terminal:

node:_http_outgoing:655
throw new ERR_HTTP_HEADERS_SENT('set');
^

Error: Cannot set headers after they are sent to the client

Expected Behavior

When a resource (Collection or Project) is not found, the server should respond with a 404 Not Found and terminate the request lifecycle immediately.

The Promise chain should be short-circuited so that subsequent .then() blocks (like populateReferences and sendSuccess) are never executed after a failure response has been sent. The Node process should remain operational, and no ERR_HTTP_HEADERS_SENT error should be triggered.

Steps to reproduce
Steps:

This bug is triggered by a race condition where the Frontend UI becomes "stale" due to actions in another session/tab. For example:

  1. Ensure user is logged in
  2. Open the p5.js Web Editor in two separate browser tabs (Tab A and Tab B).
  3. In Tab A: Open the "Add to Collection" modal for any sketch. The list of existing collections is displayed, if none, create one.
  4. In Tab B, delete the collection that you intend to add the sketch to.
  5. Back in Tab, click the button to add the sketch to that (now deleted) collection.

Observed Result: The server identifies the collection is missing, sends a 404, but then fails to stop execution, attempts a second response, and crashes the backend process.

Also happens when: user has a sketch open in Tab A, deletes it in Tab B, and then attempts to add the now deleted sketch from Tab A to a collection.

https://github.com/user-attachments/assets/f27acf43-2d59-4b4c-b5a5-2eb618369755

主要言語
JavaScript
スター
1.7k
フォーク
1.7k
平均マージ
3日 18時間
マージ済み PR（30日）
7

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

processing/p5.js-web-editor のほかの issue

processing/p5.js-web-editor の issue をすべて見る

似ている issue

JavaScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。