Proposal: HostOps.nodeRect — node geometry readback (root-space border box)

オープン
#618 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
react, rust, typescript
領域
api, frontend

調査の方向性

Read contracts/spec/ui-ops.ts and inspect the generated bindings and engine/runtime-cabi/src/compat/ui/mod.rs; the issue says the prototype targeted the removed engine/wasm crate. First settle the result shape and auxiliary-surface semantics with maintainers, then port the core method, C ABI export, and framework/web binding. Done means tests cover nested geometry, missing or stale IDs, and agreement with the drawn position.

索引モデルが issue の本文から書いたものです。

説明

Proposal: HostOps.nodeRect — node geometry readback

Summary

Add a read-only op that returns a node's border box in root space, so renderers can anchor UI (popovers, menus, tooltips, floating buttons) without probing the framebuffer.

Problem

The core computes layout, but the host-visible op surface has no way to read a node's rectangle:

  • ui_node_layout returns parent-relative values and is not part of HostOps, so every caller has to re-walk the ancestor chain.
  • There is no op that returns a node's box in root space.

A renderer that wants to place a popover next to its trigger therefore has to reconstruct the box from hit tests.

Measured cost in a real renderer

Our React renderer for PocketJS (compat layer over this core) anchors Menu/Select/tooltip panels to their triggers today by scanning for a seed point with hitTestBounds, then four binary searches for the edges:

Scene Hit-test queries per measure Queries per popover open (8 frames)
bare node 1,839 —
labelled node 3,040 —
clipped node 449 —
popover open — 22,322

That is per interaction, on a 480×272 viewport, with two frames of latency before the panel can be placed.

Proposal

interface NodeRect {
  readonly x: number;
  readonly y: number;
  readonly w: number;
  readonly h: number;
}
interface HostOps {
  nodeRect?(id: number): NodeRect | null;
}

Semantics:

  • Root-space border box in logical pixels: the node's parent-relative layout rect summed up the parent chain.
  • Untransformed (transforms are not applied) and unclipped (overflow clips and occlusion are not applied); a painted/clipped rect can be a later op.
  • Margin excluded.
  • null for id 0, a stale id or a destroyed node.
  • Optional member: hosts without the op omit it, and callers feature-detect. Old hosts keep working.

A working implementation exists in a local branch (see below): a core method that sums the parent chain, a C ABI export writing four f32s to an output buffer, and the framework/web binding. Tests: a hand-computed nested rect, the none/stale cases, and a pixel-free assertion that the box matches the drawn position.

Feedback we would like before opening a ported PR:

  1. Result shape. The op needs to return four numbers. Options we see: (a) a new rect result kind in contracts/spec/ui-ops.ts with the generated bindings extended for it, (b) an out-buffer call with the existing integer success result — cheaper to wire, less ergonomic. We are happy to do either; (a) touches the generator chain and the guests, so we would rather ask first.
  2. Untransformed/unclipped as stated, or should it intersect with clipping ancestors?
  3. Should the same op serve auxiliary surfaces (rect in that surface's space, as hit tests do)?

Status of the local implementation

The prototype predates the runtime-drivers refactor (#603): it added ui_node_rect to the old engine/wasm crate, which no longer exists. The core method and the C ABI export port cleanly to engine/runtime-cabi/src/compat/ui/mod.rs; what needs deciding is the descriptor/result-kind shape above. We have not opened that PR yet because we would rather agree on the API than hand you a PR that needs reworking in all the generators.

Happy to post the prototype diff on request, and to rebase the ported version the moment the shape is settled.

主要言語
TypeScript
スター
1.6k
フォーク
88
PR マージ指標
30日以内にマージされた PR はありません

環境構築

このプロジェクトの環境構築ファイルはまだ確認していません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

pocket-stack/pocketjs のほかの issue

pocket-stack/pocketjs の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。