plugin-nested-docs: option to re-save only children whose breadcrumbs would change, instead of the whole subtree on every publish
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
- issue の種類
- 機能追加
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- typescript
調査の方向性
Read the nested-docs plugin's resaveChildren implementation and its getParents, populateBreadcrumbs, formatBreadcrumb, generateLabel, and generateURL paths, along with the referenced issues #14943 and #5706. Trace how published children and pending drafts are read and saved, then assess the proposed opt-in behavior against the Postgres reproduction; done means unrelated parent edits avoid descendant writes while breadcrumb changes still cascade correctly.
索引モデルが issue の本文から書いたものです。
説明
Describe the Bug
After every published save, resaveChildren re-saves every child (both its published version and its pending draft), and each re-saved child runs the same hook on its own children. This happens whatever changed. Publishing a change to an unrelated field on a page re-saves its whole subtree, one document after another, inside the parent's transaction.
The cost grows with subtree size, not with what was edited: every descendant gets a new version and runs its full hook and validation chain, all inside the parent's transaction, even when the edit can't affect any breadcrumb.
(This is about cost, not lost saves: publishes we saw fail under this cascade turned out to be #15515.)
Why the full cascade can't simply be dropped
Re-saving a child does more than refresh its breadcrumbs. It runs the child's own hooks and their side effects (revalidation, search indexing, webhooks, a hook that derives a field from the child's ancestors). Some projects may depend on an ancestor's save refreshing those. The plugin can't know, so the full cascade should stay the default.
Proposal: an opt-in, with an exact breadcrumb check
Something like resaveChildren: 'always' | 'whenBreadcrumbsChange' (or a shouldResaveChild({ child, expectedBreadcrumbs, req }) callback), default 'always'. With 'whenBreadcrumbsChange':
- Read the published parent and its ancestors once (
getParents), as the child's beforeChange hook would. - Read the children (both their published versions and pending drafts) in full.
- For each child, compute in memory the breadcrumbs
populateBreadcrumbswould write: for each document in[...ancestors, parent, child],formatBreadcrumbover the chain up to it, using the configuredgenerateLabel/generateURL. - Re-save only the children whose stored breadcrumbs (
docid,url,label) differ. Each re-saved child runs the hook in turn, so the cascade reaches exactly the part of the tree a change affects. - When a child's published version is re-saved, re-save its pending draft after it, so the draft stays the newest version (the #14943 situation).
Computing the expected breadcrumbs, rather than checking that a child's stored crumbs start with the parent's, matters. generateLabel / generateURL receive the whole chain, so a child's own crumb can depend on an ancestor field that ancestor's own crumb doesn't show. A prefix check would miss that. Comparing against the children's stored state, rather than diffing the parent against previousDoc the way #5706 does, also covers publishing a draft whose breadcrumbs changed, since draft saves never cascade.
With the option on, the only requirement is that generateLabel / generateURL depend only on their arguments. A save that changes nothing a breadcrumb depends on then does a few reads and no writes.
Given the core nested-docs work in #19277, will the core version avoid the full cascade, or offer something like this?
Reproduction Steps
- A collection with
versions.draftsandplugin-nested-docs, on a Postgres adapter. - Create a parent with a few dozen published descendants, several levels deep.
- Publish a change to any non-breadcrumb field on the parent (for example a checkbox).
- Every descendant gets a new version, and the save time grows with the size of the subtree.
Which area(s) are affected?
plugin: nested-docs
Environment Info
Reproduced on payload / @payloadcms/plugin-nested-docs 3.90.0.
- 主要言語
- TypeScript
- スター
- 45.8k
- フォーク
- 4.4k
- 平均マージ
- 2日 16時間
- マージ済み PR(30日)
- 251
環境構築
このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
payloadcms/payload のほかの issue
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keys対応中かも @pcbeingused333 が今日担当しました。 オープンBug db: d1-sqlite Payload OSS
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
payloadcms/payload#19766 ·
メンテナーはふだん 1 日以内に返信
-
Document bar (.doc-controls__content) overflows a 375 px viewport, clips "Created" and fails axe scrollable-region-focusable対応中かも このイシューにリンクされたプルリクエストがオープン中、またはマージ済みです。 オープンarea: ui Bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
payloadcms/payload#19690 ·
メンテナーはふだん 1 日以内に返信
-
[v4] Blocks thumbnails croped 3:2対応中かも @samiarif02 が 2 日前に担当しました。 オープンarea: ui Bug Payload OSS status: needs-triage v3
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
payloadcms/payload#19609 ·
メンテナーはふだん 1 日以内に返信
-
Scheduled publish jobs are not deleted when their document is deleted (string id in the job, raw id in the cleanup)対応中かも @volodymyrshk が 10 日前に担当しました。 オープンarea: core Bug db: sqlite
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
payloadcms/payload#19448 ·
メンテナーはふだん 1 日以内に返信
-
plugin-multi-tenant: `isGlobal` collections redirect tenant-scoped users to `/admin` since 3.93.0 (GlobalViewRedirect prop-name mismatch)対応中かも @JarrodMFlesch が 10 日前に担当しました。 オープンBug plugin: multi-tenant
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
payloadcms/payload#19420 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
payloadcms/payload の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
milind-soni/OpenMausBot#6730 ·
メンテナーはふだん 1 日以内に返信
-
`@angular/[email protected]` depends on vulnerable Vite 7.3.7 - GHSA-p4f5-76q4-ffq7 (Critical RCE)オープンarea: @angular/build
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
angular/angular-cli#34764 ·
メンテナーはふだん 1 日以内に返信
-
status/need-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
google-gemini/gemini-cli#30384 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
P2
難易度 1/5 1時間未満 初心者へのやさしさ 84/100
メンテナーはふだん 1 日以内に返信
-
area:image documentation good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 1 日以内に返信