Make the maximum automatic retry delay configurable in the GUI

オープン
#12,685 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
cpp
領域
backend, desktop

調査の方向性

Start with the retry delay calculation and environment variable handling in src/libsync/owncloudpropagator.cpp at the linked source reference, then trace how the client stores and displays advanced settings. Check the existing settings and sync tests before deciding where coverage belongs. Done means the GUI setting persists, affects waiting transfers while preserving the default behavior, validates input, and has a documented precedence rule for OWNCLOUD_BLACKLIST_TIME_MAX.

索引モデルが issue の本文から書いたものです。

説明

Pre-submission Checks

  • I searched open and closed issues for similar proposals. Related issue #8022 covers manual retries, not GUI configuration of the automatic retry delay.
  • The required information for this feature proposal is included below.

Feature description

Please make the maximum delay between automatic retries of failed file transfers configurable in the ownCloud Desktop Client GUI.

Using ownCloud Desktop Client 5.3.2 on macOS, two downloads remained deferred for approximately another 20 hours after repeated connection failures reported as "Connection closed". After resetting the retry delay, both files downloaded successfully. The cause of the earlier connection failures is unknown.

A long retry delay can be useful to limit repeated unsuccessful transfers. However, users who need files promptly across multiple devices may find that files remain unsynchronized long after a temporary problem has ended. Users should be able to configure the maximum delay without an environment variable or a customized application launch.

Proposed solution

Provide a maximum retry delay setting in "Settings". Concrete GUI proposal for discussion:

  • Location: "Settings", "Advanced" section.
  • Field: "Maximum retry delay", a numeric input with the unit "minutes".
  • Range: 1 to 1440 minutes; default: 1440 minutes, preserving the existing maximum of 24 hours.
  • Help text: "Limits the waiting time between automatic retries of failed file transfers. Shorter delays cause more frequent retries."
  • Validation: Empty, non-integer, or out-of-range values cannot be saved. Error message: "Enter a whole number between 1 and 1440 minutes."
  • The setting applies client-wide, is saved persistently, and is restored after restarting the client.
  • Keep the existing progressive backoff; make only its upper limit configurable.
  • A reduced maximum should also apply to transfers already waiting: if the new delay has already elapsed since the last attempt, the next regular sync run should retry the file.
  • Leaving the setting unchanged preserves existing behavior. "Force sync now" remains available for immediate manual retries.
  • Define and document the interaction with OWNCLOUD_BLACKLIST_TIME_MAX; for example, an explicitly set environment variable could take precedence, with the GUI showing the effective value and the override.

Verification should cover the unchanged default, a shorter maximum delay, transfers already waiting, invalid input, persistence across restarts, and the documented precedence rule.

Alternative solutions you considered

  • "Force sync now" bypasses the delay manually and is sufficient as an immediate workaround. However, it requires the user to notice the error and intervene.
  • OWNCLOUD_BLACKLIST_TIME_MAX already provides technical configuration. A GUI setting would be easier to discover and would not require a customized application launch.

Additional context

This proposal concerns the Desktop Client in owncloud/client, not a change to OCIS.

The observation comes from version 5.3.2. The same mechanism is also present in the inspected default branch master at commit 55bd930a11636134ebfe32ee2721e417ac1e1707: calculation and environment variables. This source reference does not establish the behavior of an installed newer version.

Related: #8022 ("Force sync now" improvements).

主要言語
C++
スター
1.5k
フォーク
695
平均マージ
8日 7時間
マージ済み PR(30日)
6

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

owncloud/client のほかの issue

owncloud/client の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。