[FEATURE REQUEST] Bump SDK Target to 37 (Android 17)
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
調査の方向性
Start by reading the Android manifest, build.gradle, network_security_config.xml, AccountAuthenticator.java, NotificationUtils.kt, DownloadFileWorker.kt, and StorageMigrationActivity.runIfNeeded(). Search for setContentCaptureEnabled and audit manifest orientation and resizability declarations; verify API 37 guidance and library compatibility. Done means addressing the listed permission, certificate transparency, BAL, cleanup, and target SDK changes, then completing the large-screen audit and Android 17 emulator smoke tests.
索引モデルが issue の本文から書いたものです。
説明
Context
Current targetSdk is 36. Android 17 (API 37) introduces several mandatory behavior changes for apps that explicitly target it. This issue tracks all the work needed before the bump is safe to ship.
Breaking changes
1. Local Network Permission (ACCESS_LOCAL_NETWORK)
On API 37 this becomes a runtime permission. The app connects to WebDAV servers on local networks (and may perform OIDC discovery on LAN), so this permission is required for core functionality.
Required actions:
- Declare
android.permission.ACCESS_LOCAL_NETWORKinAndroidManifest.xml - Add a runtime permission request flow before opening any local network connection (WebDAV, OIDC, etc.)
- Submit a Local Network Access declaration in the Play Console (mandatory for apps targeting API 37+)
Reference: Local network permission
2. Certificate Transparency enabled by default
Certificate Transparency is optional on API 36. On API 37 it is on by default for all TLS connections. This directly affects self-hosted servers whose certificates may not be logged in a public log.
Required actions:
- Decide on a CT strategy:
-
- Global disable: That'd keep the current behaviour
-
- Per-domain disable: the number of domains is not scoped. Not manageable ❌
-
- User-facing warning for non-compliant server certs: adding another warning that does not add extra security, since the current one already warns.
-
For option 1: update network_security_config.xml with the appropriate <certificateTransparency> element
<base-config cleartextTrafficPermitted="false">
<certificateTransparency enabled="false" />
</base-config>
Reference: Certificate Transparency
3. AccountAuthenticator — KEY_INTENT BAL hardening
addAccount, confirmCredentials, getAuthToken, and prepareBundleToAccessLoginActivity in AccountAuthenticator.java return intents via AccountManager.KEY_INTENT. On API 37 the BAL (Background Activity Launch) restrictions are extended to IntentSender; when AccountManager launches these intents from the system process, the app may lose the implicit BAL privilege it currently relies on.
Required actions:
- Attach
ActivityOptionswithsetPendingIntentCreatorBackgroundActivityStartMode (MODE_BACKGROUND_ACTIVITY_START_ALLOW_IF_VISIBLE)to theKEY_INTENTbundles (or the applicable API 37 equivalent once guidance is published) - Fix
prepareBundleToAccessLoginActivity()(~line 458): this site is missingFLAG_ACTIVITY_NEW_TASKthat all other three KEY_INTENT sites already set, this is a latent bug independent of API 37
Cleanup: should go in the same PR as the bump
4. Remove deprecated FLAG_FROM_BACKGROUND
FLAG_FROM_BACKGROUND is a deprecated Intent flag that is silently ignored on API 37. It appears in:
NotificationUtils.kt—composePendingIntentToRefreshCredentials()(~line 93) andnotifyConflict()(~line 164)DownloadFileWorker.kt—composePendingIntentToRefreshCredentials()(~line 295)
All usages are in notification content intents (user-triggered on tap), so there is no runtime risk. Remove the flag from all three sites.
5. StorageMigrationActivity.runIfNeeded(Context), add Activity guard
runIfNeeded(context: Context) at ~line 87 calls context.startActivity() without verifying the context is an Activity. All current call sites in MainApp.kt` (line ~131) pass an Activity, so it is safe today. On API 37 a non-Activity context would be a BAL violation.
Add a context is Activity (or context is AppCompatActivity) guard matching the pattern already used in WhatsNewActivity and ReleaseNotesActivity.
Verify — likely fine, but confirm during the bump
6. Large-screen orientation / resizability
The optional from Android 16's large-screen policy (orientation and resizability constraints ignored on sw≥600dp) is removed in API 37. Any android:screenOrientation or android:resizeableActivity="false" declarations will be silently overridden on tablets and foldables.
- Audit the manifest for any orientation/resizability constraints
- Run manual testing on a large-screen emulator (sw≥600dp) before
shipping
7. ContentCaptureManager.setContentCaptureEnabled(false) deprecated
Calling this on API 37 has no effect. If any screen uses it to prevent system AI from reading sensitive file content, migrate to window.setFlags(FLAG_SECURE, FLAG_SECURE). Search the codebase for setContentCaptureEnabled before bumping.
8. Static final field mutation via reflection
On API 37 any attempt to modify a static final field via reflection throws IllegalAccessException. App code is unlikely to do this, but third-party libraries (Moshi, DAV4Android, OkHttp) should be verified against their changelogs or known issues lists for API 37 compatibility before the bump.
Not applicable (confirmed by audit)
| Item | Reason |
|---|---|
| Manage Contacts permission | Not used |
| Location permission | Not used |
MANAGE_EXTERNAL_STORAGE |
Not used |
| Accessibility API | Not declared |
| Call Log / SMS permissions | Not used |
| AppFunctions API | Not used |
| Background audio hardening | Not an audio app |
| AppWidget memory limits | No home screen widget |
| BluetoothSocket changes | No Bluetooth usage |
| OTP / SMS protection | No SMS usage |
Checklist
- Declare and request
ACCESS_LOCAL_NETWORKat runtime - Submit Play Console local network declaration
- Define Certificate Transparency strategy and update
network_security_config.xml - Fix
AccountAuthenticatorKEY_INTENT bundles for API 37 BAL requirements - Fix
prepareBundleToAccessLoginActivity, add missingFLAG_ACTIVITY_NEW_TASK - Remove
FLAG_FROM_BACKGROUNDfromNotificationUtils.ktandDownloadFileWorker.kt - Add Activity guard to
StorageMigrationActivity.runIfNeeded() - Audit and test large-screen UI (sw≥600dp)
- Grep for
setContentCaptureEnabledand migrate if found - Verify third-party library compatibility with API 37
- Bump
targetSdkVersionto 37 inbuild.gradle - Manual smoke test on Android 17 emulator (local WebDAV, auth flow, file upload/download)
TASKS
- Research (if needed)
- Create branch feature/feature_name
- Development tasks
- Implement whatever
- ...
- Implement unit tests (if needed)
- Code review and apply changes requested
- Design test plan
- QA
- Merge branch feature/feature_name into master
- 主要言語
- Kotlin
- スター
- 4.2k
- フォーク
- 3.1k
- 平均マージ
- 3日 9時間
- マージ済み PR(30日)
- 16
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
owncloud/android のほかの issue
-
Camera Uploads Contributions are welcome Technical
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
owncloud/android#5040 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
KW-related Type:bug UI / UX
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
メンテナーはふだん 1 日以内に返信
-
Type:bug
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
owncloud/android#4485 · コメント 6 件 ·
メンテナーはふだん 1 日以内に返信
-
Contributions are welcome p3-medium Type:bug
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
owncloud/android#4300 · コメント 5 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
owncloud/android#3720 · コメント 8 件 ·
メンテナーはふだん 1 日以内に返信
owncloud/android の issue をすべて見る
似ている issue
-
👀 example 📱 iOS
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
hyochan/react-native-nitro-sound#871 ·
メンテナーはふだん 2 日以内に返信
-
android:plan main:plan packages:learn
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
メンテナーはふだん 1 日以内に返信
-
a:bug in:configuration-cache re:windows
難易度 2/5 1〜3時間 初心者へのやさしさ 77/100
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
メンテナーはふだん 1 日以内に返信
-
Needs Triage
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
ankidroid/Anki-Android#23453 ·
メンテナーはふだん 1 日以内に返信