Colour matching below 100% draws the live zone stack instead of the baked tiles

オープン
  • 何か問題がありますか？
#29 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
lua
領域
performance

調査の方向性

Read OpenMap/Map/Stitch.lua and OpenMap/Data/Forever/ZoneArt.lua to trace when Baked.use selects baked tiles versus live zone layers. Reproduce with Colour matching at 80% and 100% using /openmap bench, then identify a change that preserves the baked art path across slider values. Done means the map keeps the intended colour matching and avoids the measured panning slowdown at lower settings.

索引モデルが issue の本文から書いたものです。

説明

Game version

Forever. The same expression runs on retail, where the tiles are baked at its own settings.

OpenMap version

v0.8.1, and still on main as of v0.8.2.

What happens

Baked.use in OpenMap/Map/Stitch.lua requires the colour-matching slider to equal the value the tiles were baked at (strength == art.colorMatch; OpenMap/Data/Forever/ZoneArt.lua bakes at 1.0). At any other slider setting the map skips the pre-drawn world tiles at every zoom and draws the live zone layers and their colour-matched copies instead. The desaturate setting is tolerated (desat >= art.desaturate - 0.001) while colour matching is compared for equality, so one notch on that slider changes which art path the whole map takes.

Measured

/openmap bench on v0.8.1, 3840x2160, vsync off, no fps cap, map 1455, unexplored areas darkened, the map standing in the same place.

Colour matching textures drawn at 2.5x pan ms (p90) still ms
0.8 2,348 20.8 (23) 7.6
1.0 509 8.2 (10) 5.9

At 2.5x with 0.8, taking one layer out costs the pan frame: zone overlays 7.9 ms, colour-matched copies 5.7 ms, zone base art 5.0 ms. At 1.0 the pan frame sits level with the still frame at every zoom.

This came out of a player report of panning dropping from 130 to 55 fps with the slider at 0.8; at 100% the same panning holds its frame rate.

Why it matters

One slider position costs about 13 ms a frame on the map's busiest views, and nothing in the menu says that moving it turns off the pre-drawn art. A player has no way to tell why the map got slower.

Repro

Set Colour matching to 80% (Options, under the map's colours), stand where several zones show, and run /openmap bench. Set it to 100% and run it again.

Directions, not tried

  • Bake a second set of tiles at 0 and cross-fade between the two sets by the slider.
  • Accept a tolerance on the slider and correct the remainder with a per-tile vertex tint, the way the colour-matched copies are tinted now.
  • At least say in the slider's description that other values cost the pre-drawn art.
主要言語
Lua
スター
20
フォーク
6
平均マージ
6時間 34分
マージ済み PR（30日）
9

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

openmap-world/openmap のほかの issue

openmap-world/openmap の issue をすべて見る

似ている issue

Lua の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。