orama-db: `orama-db.json` changes on every build
メンテナーはふだん 3 日以内に返信
評価
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 初心者へのやさしさ
- 35/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 停滞
- 技術スタック
- javascript, node.js
調査の方向性
Start with packages/react/src/orama-db/generate.mjs: read how it builds documents, calls insertMultiple, and saves the index; the issue also points to useOrama.mjs to check how search uses results. Add stable ids and sort the flattened documents by href, then create the suggested generator tests for repeatability, input order, and search behavior. Run node --run test and confirm the generated output is stable; pull request #1190 is already open against this issue.
索引モデルが issue の本文から書いたものです。
説明
Running a build twice on the same docs gives two different orama-db.json files, for two reasons:
- Timestamp-based ids. The
orama-dbgenerator inserts documents without anid, so Orama 3.x makes one up from the current time and a counter (e.g.20003290-1). That id is saved in the index (internalDocumentIDStore.internalIdToId), so the file changes on every build. - Insertion order. Orama's saved index follows the order documents were inserted, and the generator's input order can change between builds (see #1183).
The search index is several MB, so a file that changes on every deploy wastes caching, and CI can't compare it byte for byte.
Where to look
packages/react/src/orama-db/generate.mjs:27-44: builds the documents (title,description,href,siteSection) with noid, in input order.- The same file, line 40:
href(${entry.path}.html#${entry.heading.data.slug}), which makes a natural stable id. - The same file, line 47:
insertMultiple(db, documents); lines 49-56:save(db)is written toorama-db.json. packages/react/src/html/ui/hooks/useOrama.mjs:26-41: the website loads the saved index and searches it. It doesn't depend on the id format, and results are rendered fromhit.document.
How to reproduce
From packages/react (where @orama/orama resolves), save this as repro.mjs and run node repro.mjs a few times:
import { createHash } from 'node:crypto';
import { create, insertMultiple, save } from '@orama/orama';
const docs = [
{ title: 'fs', description: 'File system', href: 'fs.html#fs', siteSection: 'fs' },
{ title: 'fs > readFile', description: 'Reads a file', href: 'fs.html#readfile', siteSection: 'fs' },
];
const db = create({
schema: { title: 'string', description: 'string', href: 'string', siteSection: 'string' },
});
await insertMultiple(db, docs); // try: docs.map(doc => ({ id: doc.href, ...doc }))
const out = JSON.stringify(save(db));
console.log(createHash('sha256').update(out).digest('hex').slice(0, 16));
Each run prints a different hash. With the commented id: doc.href line, every run prints the same one, until you reverse docs, which changes it again.
Suggested approach
Only packages/react/src/orama-db/generate.mjs needs to change:
- Add
id: hrefto each document (Orama requires string ids, andhrefis one). - Sort the flattened documents by
hrefbefore inserting them, comparing with<and>(orlocaleCompare(..., 'en')) so the order doesn't depend on the machine's locale.
Keep the existing flatMap as it is, and sort its result, not the input: buildHierarchicalTitle walks each module's headings in document order to build titles like "Class > Method".
How to test
There's no generator test for orama-db yet. Create packages/react/src/orama-db/__tests__/generate.test.mjs, setting up the config like llms-txt-full/__tests__/generate.test.mjs does (setConfig({ target: ['orama-db'] }), then set output to undefined so generate() just returns the saved index). With a few fake metadata entries from two modules, test that:
- Two runs give the same output: compare the
JSON.stringifyof twogenerate()results. This already fails today within a single process. - Input order doesn't matter: put one module's entries before the other's, keeping each module's own entries in order, and compare.
- Search still works:
load()the result intocreate({ schema: {} }),search()for a title word, and checkhits[0].document.href.
Run everything with node --run test.
Things to watch out for
- Ids must be unique, or Orama throws
DOCUMENT_ALREADY_EXISTSand the build fails. Slugs are deduplicated per file, so hrefs should be unique. If the full Node.js docs build throws anyway, point out the duplicate in your PR rather than going back to automatic ids. save()doesn't include the database's own id, so that one doesn't matter.- The output is only identical for the same
@orama/oramaversion; a dependency update can still change it.
Getting started
New to doc-kit? CONTRIBUTING.md covers setup, running the tests and adding a changeset (node --run changeset, a patch for @doc-kit/generator-react). Leave a comment here if you'd like to take it on.
- 主要言語
- JavaScript
- スター
- 70
- フォーク
- 75
- 平均マージ
- 2日 11時間
- マージ済み PR(30日)
- 50
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
nodejs/doc-kit のほかの issue
-
難易度 2/5 半日 初心者へのやさしさ 68/100
nodejs/doc-kit#1085 · コメント 6 件 ·
メンテナーはふだん 3 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
nodejs/doc-kit#1054 · コメント 1 件 ·
メンテナーはふだん 3 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 55/100
nodejs/doc-kit#1194 · リアクション 1 件 ·
メンテナーはふだん 3 日以内に返信
-
core: incremental generation against an existing output (`--incremental`)対応中かも @avivkeller が 1 日前に担当しました。 オープンCLI
nodejs/doc-kit#1189 · コメント 2 件 · 担当者 1 名 ·
メンテナーはふだん 3 日以内に返信
-
cli: add a `dev` command with in-memory builds and HMR対応中かも @avivkeller が 1 日前に担当しました。 オープンCLI Web Generator
nodejs/doc-kit#1188 · リアクション 1 件 · 担当者 1 名 ·
メンテナーはふだん 3 日以内に返信
似ている issue
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
glossyio/traffic-monitor#264 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 72/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
micromatch/picomatch#243 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
getComputedStyle().display is "" for span, a, b, label and other inline elements instead of "inline"オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
capricorn86/happy-dom#2556 ·
メンテナーはふだん 1 日以内に返信