[treescript] switch from using `actions` to using `behaviors`
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 30/100
調査の方向性
treescript/src/treescript/script.py の57-67行目から始め、iscript/src/iscript/script.py の29-50行目と比較してください。動作の境界を決める前に、既存のアクションの組み合わせと merge-day および l10n のワークフローを洗い出してください。完了とは、treescript が個別にテスト可能なサポート対象ワークフローを動作として使用し、説明されている version-bump、tagging、merge-day、l10n の相互作用を含むことです。
索引モデルが issue の本文から書いたものです。
説明
In treescript, we currently use actions to determine what logic to run. This follows the mozharness model, and made sense when we first implemented treescript, to allow us to tag, version bump, and/or push independently or together. However, the script has grown in complexity, now supporting l10n bumping and merge day automation, and there are the following downsides to using actions:
- Various actions are incompatible with each other. Neither l10n bumping nor merge day were designed to work with the current tagging or version bumping logic, so there are caveats when choosing combinations of actions to run.
- If we make a large change or refactor to one or more of the actions, we need to test to make sure all valid combinations of actions still work. It isn't completely clear which combinations of actions are supported, and which are not.
- If we want to include or exclude an action in a given set of tasks, we also have to make an in-tree change, and coordinate landing. This likely means we need to run at least one full staging release to test this and (2).
- It's trickier making a change where an action behaves differently in a subset of cases. This likely means adding a task payload setting, and then making sure that setting is correctly set in all permutations of the gecko taskgraph.
In iscript, we use behaviors to determine what logic to run. Instead of multiple mix-and-match actions per task, there is a single behavior per task. If we need to be able to run tagging separately from version bumping, as well as together, that might mean three behaviors (tag, version_bump, version_bump_and_tag) or a single behavior with flags (version_bump_and_tag, with an empty new_version, for instance).
This doesn't seem like a big win when looking at just tagging, version bumping, and pushing. When we get to merge day automation, however, it's a huge win:
- the merge day behavor can have all appropriate logic baked in. We can test these as appropriate.
- we may even want to separate these into separate behaviors:
merge_central_to_beta,merge_beta_to_release,merge_release_to_esr,bump_esr,bump_early_to_late_beta,bump_central. (bump_centralcould potentially be part of themerge_central_to_betatask if we wanted, though.) These would duplicate a lot of the same logic, but those could be factored out into simple standalone functions that they each call. - we will be able to test these separately, and be able to make more surgical changes if any of these behaviors need different workflows than the others.
- we may even want to separate these into separate behaviors:
- we want to l10n bump after the
central_to_betabehavior. This currently necessitates another task, and we have to deal with both a) removingDONTBUILDand b) addingCLOSED TREE, which is a change from the current non-merge-day behavior. We can add an l10n bump helper function call into themerge_central_to_betabehavior function, with the appropriateDONTBUILD/CLOSED TREEsettings, and that problem is solved. - we want to version bump in the merge behavior. We can call the version bump helper function.
- by having a single task handle all of these, rather than multiple disparate tasks, we avoid multiple pushes, and save in both CI compute time and taskgraph complexity.
Not a blocker, but I think moving from actions to behaviors will save us time and headache in the long run.
- 主要言語
- Python
- スター
- 16
- フォーク
- 38
- 平均マージ
- 1日 7時間
- マージ済み PR(30日)
- 14
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
mozilla-releng/scriptworker-scripts のほかの issue
-
Dependency Dashboard オープン
難易度 5/5 1週間以上 初心者へのやさしさ 15/100
-
難易度 5/5 1週間以上 初心者へのやさしさ 25/100
-
treescript
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
mozilla-releng/scriptworker-scripts#1055 · コメント 2 件 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 32/100
mozilla-releng/scriptworker-scripts#994 · コメント 1 件 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
mozilla-releng/scriptworker-scripts#980 · コメント 1 件 ·
mozilla-releng/scriptworker-scripts の issue をすべて見る
似ている issue
-
agent-ready documentation needs-triage
難易度 1/5 1〜3時間 初心者へのやさしさ 88/100
-
documentation
難易度 1/5 1時間未満 初心者へのやさしさ 91/100
-
workflow-status page template still says reusable workflows are "triggered only by workflow_call:" オープン
難易度 1/5 1時間未満 初心者へのやさしさ 92/100
-
instance instance add
難易度 1/5 1時間未満 初心者へのやさしさ 72/100
searxng/searx-instances#939 · コメント 1 件 ·
-
area-deployment area-integrations triage:bot-seen
難易度 2/5 半日 初心者へのやさしさ 86/100