Hacktoberfest 2026:メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

streamable-http client: an error response to `initialize` is lost or ignored (SSE, session re-init)

オープン
#1,360 コメント 1 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 3 日以内に返信

@bolinfest がすでに取り組んでいます。

2026年10月14日 から。

  • #1361 @gocamille による — オープン

評価

この issue はまだ評価されていません。

説明

bug P1 ready for work T-transport

Describe the bug

This is about the 2025-11-25 initialize handshake and Mcp-Session-Id sessions. There are two places where the streamable-http client doesn't handle a JSON-RPC error that comes back for initialize.

  1. The server answers the initialize POST with text/event-stream, and the event is an error. StreamableHttpPostResponse::expect_initialized only stops draining on ServerJsonRpcMessage::Response(_), so it logs the error at debug and moves on. If the stream then ends, serve() returns ConnectionClosed("initialize response") and the worker logs unexpected server response: empty sse stream, when process initialize response. If the server keeps the stream open, serve() never returns. The same error sent as application/json comes back as ClientInitializeError::JsonRpcError.

  2. With reinit_on_expired_session(true), a 404 makes the client send a new initialize, but perform_reinitialization doesn't check whether the reply is an error. With an application/json error, it still sends notifications/initialized and then retries the original request, both without a session id, even though no new session was set up. An SSE error here currently fails with "empty sse stream" like case 1, and would go down the same path as JSON once case 1 is fixed.

To Reproduce (main at 8d226f4)

Case 1: a mock server answers POST /mcp with 200, Content-Type: text/event-stream and one event:

data: {"jsonrpc":"2.0","id":0,"error":{"code":-32602,"message":"Unsupported protocol version","data":{"supported":["2024-11-05"],"requested":"1.0.0"}}}

This is the example error from the spec's lifecycle page, but any error response to initialize does the same thing.

let res = tokio::time::timeout(
    Duration::from_secs(3),
    ().serve(StreamableHttpClientTransport::from_uri(uri)),
)
.await;
server response result
SSE error event (no event id), then the stream ends Err(ConnectionClosed("initialize response"))
SSE error event, stream held open still pending after 3s
same error as application/json Err(JsonRpcError(-32602 ...))

Case 2: a mock server accepts the first initialize (session s1), returns 404 for the next request on s1, and answers the second initialize with the same error as application/json. These are the POSTs it gets:

initialize                 session=None
notifications/initialized  session=Some("s1")
tools/list                 session=Some("s1")   <- 404
initialize                 session=None         <- error response
notifications/initialized  session=None
tools/list                 session=None

Expected behavior

  1. serve() returns ClientInitializeError::JsonRpcError with the server's code, message and data, whether the error comes over SSE or JSON.
  2. Recovery fails and the pending request gets an error, without sending notifications/initialized or retrying.

Additional context

The drain loop came in with #467 so that notifications sent before the initialize response don't break the handshake. #569 (for #563) made the service layer report an initialize error, but the SSE branch here never hands the error to it. Letting Error(_) end the loop at streamable_http_client.rs:317 fixes case 1. Case 2 needs its own check in perform_reinitialization, otherwise fixing case 1 just moves SSE errors during recovery onto the JSON path.

I can open a PR for both.

主要言語
Rust
スター
4k
フォーク
662
平均マージ
3日 23時間
マージ済み PR(30日)
34

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

modelcontextprotocol/rust-sdk のほかの issue

modelcontextprotocol/rust-sdk の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。