Support Skills authorization without cross-package dependencies

オープン
#1,990 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
csharp

調査の方向性

Start by reading the Core hosting primitive-filter composition and the existing AddAuthorizationFilters policy evaluator, then trace how Skills composes skills/list and skills/get handlers. The issue requires a shared hook that preserves existing authorization checkpoints, request services, and Tasks dispatch order while avoiding package dependency changes. Done means the acceptance criteria pass, including Native AOT compatibility and no new package dependency.

索引モデルが issue の本文から書いたものです。

説明

P3

Problem

The registered-Skills/typed-handler design associated with #1863 should participate in AddAuthorizationFilters. Authorizing the file resources alone does not protect the frontmatter and manifests exposed by skills/list and skills/get. Wrapping the optional custom Skills handlers is insufficient: registered entries augment the list afterward, and matched registered gets take precedence over the fallback.

Applications should be able to use WithSkills(...) plus AddAuthorizationFilters() with their existing ASP.NET authorization services, without a separate integration registration or package. ModelContextProtocol.AspNetCore must not reference Skills, and Skills must not acquire an ASP.NET authorization dependency.

Recommended approach

Add a small, experimental, policy-neutral primitive-filter seam in Core/hosting over IMcpServerPrimitive and its server-local metadata. It needs a typed invocation hook around the complete composed handler after matching, plus a listing-visibility hook for entries mapped to registered primitives. A McpServerPrimitiveFilter-style contract is illustrative; this does not require a new catalog abstraction or a large generic framework.

AddAuthorizationFilters registers an adapter that reuses its existing policy evaluator. Skills owns the protocol-specific matching and list projection and consumes the shared hook automatically. Keep the existing tool/prompt/resource typed adapters at their current checkpoints rather than replacing them with a single outer filter: intervening filters can change the principal or matched primitive, and tool authorization must still precede Tasks dispatch.

Expected behavior and acceptance criteria

  • WithSkills and AddAuthorizationFilters work in either registration order, with no additional application integration step or cross-package dependency.
  • Protected registered entries are omitted from the complete composed listing. Registered gets are matched and authorized before dispatch, including URI-equivalent requests; denial never falls through to the custom handler. Authorized direct get/read does not depend on listing membership.
  • Reuse the existing IAuthorizeData, explicit AuthorizationPolicy, IAuthorizationRequirementData, and IAllowAnonymous behavior. Unprotected/anonymous entries remain usable; missing authorization services or filters produce actionable local diagnostics rather than silently exposing protected entries.
  • Preserve repeated authorization checkpoints around changes to the user or matched primitive, existing typed-filter order, and denial before task creation.
  • Resolve authorization services from context.Services and use context.User. Reuse stateless HTTP's HttpContext.RequestServices and existing MCP request scopes/disposal; do not manufacture scopes or capture request services in shared filters.
  • Preserve Skills snapshots, validation, initial-null-cursor augmentation, registered-get precedence, conservative get defaults, protocol-version handling, and source-generated/Native AOT compatibility.

Boundaries and open decision

Custom database entries without registered primitive metadata remain application-owned: authorize before pagination and cursor construction, and authorize direct get/read independently. A generic post-page filter cannot sanitize an arbitrary application cursor. Do not load a whole database source or mutate shared registrations per caller to compensate.

Skill files remain ordinary resources with separately applied corresponding policies, especially when files are shared. Do not implicitly copy/merge skill metadata onto files or add automatic file revocation when a skill is removed.

The prototype preserves handler-supplied cache hints. Caller-dependent results must not be reused through public caching; decide whether authorization filtering should constrain/reject public hints or leave that enforcement with the application.

A local-only prototype exercised composed Skills list/get, stateless HTTP service identity and async disposal, policy/guard parity, repeated checkpoints, and pre-Tasks authorization, and built and ran under Native AOT without changing the package dependency graph. The recommendation is the small shared seam, not shipping the prototype verbatim. Related: #1941 for request-service integration and #1704 for broader extension-handler composition.

[!NOTE]
This issue was generated by GitHub Copilot from a local prototype at the maintainer's request.

主要言語
C#
スター
4.6k
フォーク
849
平均マージ
1日 16時間
マージ済み PR(30日)
24

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

modelcontextprotocol/csharp-sdk のほかの issue

modelcontextprotocol/csharp-sdk の issue をすべて見る

似ている issue

C# の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。