Add an admin-only SimpleChat Admin action that restricts any agent using it to admins
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- javascript, python
調査の方向性
#1347 の capability audit から始め、次に application/single_app/functions_simplechat_operations.py、functions_authentication.py、functions_governance.py、route_backend_agents.py を読み、アクションの登録、認可、一覧表示を把握します。続いて、authoring feedback に関連する modal ファイルと plugin ファイルを追跡し、その後 functional_tests/route_tests/ と指定されたドキュメントページを更新します。完了条件は、admin アクションとその agents がフィルタリングされ、実行が独立して保護され、governance によって admin の下限が弱められず、admin UI のフィードバックが存在することです。
索引モデルが issue の本文から書いたものです。
説明
Summary
Add a second, separate action type — SimpleChat Admin — for SimpleChat operations that only an application admin should be able to perform. The action is invisible to non-admins, and any agent that references it becomes admin-only. That restriction is enforced in code as a floor, not left to governance policy.
User Value
Admin-capable operations are currently mixed into the general SimpleChat action. make_group_inactive is the clearest example: it already requires Control Center admin access, so a normal user can enable it on an action, attach it to an agent, and only discover the problem as a runtime permission failure. That is a late and confusing way to learn about a permission boundary.
A dedicated admin action makes the boundary explicit at design time, keeps privileged operations out of the capability list that ordinary authors browse, and gives admins one obvious place to look when auditing who can do what.
Proposed Behavior
Visibility
- Non-admin users never see the SimpleChat Admin action type in the action picker, the action type list, or any action listing API.
- Non-admin users never see an agent that references the admin action — in any agent list, catalog, picker, popular-agents surface, or template listing.
- If an admin attaches the action to an otherwise ordinary agent, that agent disappears for non-admins rather than failing later.
Enforcement
- Visibility filtering is a convenience, not the control. Server-side execution must independently refuse to run an agent carrying the admin action for a non-admin caller, with a clear error.
- The same refusal applies to workflows bound to such an agent.
Admin authoring experience
- When an admin adds the SimpleChat Admin action to an agent, show a confirmation notice in the agent modal explaining that the agent becomes admin-only from that point on.
- Show a persistent badge on any agent carrying the action so the restriction is visible at a glance, not only at the moment it was added.
- Show the same notice when a workflow is bound to an agent carrying the action.
Relationship to governance
This is a hard, built-in restriction that sits underneath governance rather than inside it. Governance can narrow access further; it can never widen it.
Governance already supports item-level policies for global_agent, global_action, and action types including global_action_type (application/single_app/functions_governance.py:39-56). The admin action should register as a governed action type so an admin can restrict it further — for example to a subset of admins in a multi-admin tenant — but the admin-only floor must hold even when no policy is configured.
Capabilities
The capability set needs its own audit as part of this work. Starting points to evaluate:
- Move
make_group_inactiveout of the general SimpleChat action, since it already requires Control Center admin access. - Identify which other existing SimpleChat capabilities are really admin operations wearing a user-permission costume.
- Decide which genuinely new admin operations are worth exposing at launch, keeping the initial set small and defensible.
Acceptance Criteria
- A
simplechat_adminaction type exists with its own capability definitions, separate from the general SimpleChat action. - The action type is filtered out of every non-admin-facing action listing and action picker.
- Agents referencing the action are filtered out of every non-admin-facing agent listing, catalog, and picker.
- Server-side execution refuses non-admin invocation with a clear error, verified independently of any UI filtering.
- An admin sees a clear warning when attaching the action to an agent, and a persistent badge on the agent afterwards.
- The action type is visible in the governance portal so admins can restrict it further, and governance cannot grant access below the built-in admin floor.
- Existing agents that do not use the action are completely unaffected.
- Route tests updated under
functional_tests/route_tests/for any new or changed endpoint and its auth policy. - Functional tests cover: non-admin cannot list the action, cannot see an agent using it, and cannot execute it; admin can do all three.
- Documentation updated: feature doc under
docs/explanation/features/, an action reference page underdocs/reference/actions/, the governance admin doc, anddocs/explanation/release_notes.md.
Open Questions
- Which capabilities ship in the admin action at launch?
- Should "admin" mean the application
Adminrole (admin_required), Control Center admin access (control_center_required), or either? These are distinct today infunctions_authentication.py. - What should happen to an agent carrying the action when a user's admin role is revoked while a session or scheduled workflow is active?
- Should group-scoped privileged operations key off group admin role rather than application admin?
- Does the restriction need to propagate to agent templates and any export/import path?
Notes
Depends on the capability audit in #1347, since at least one capability is expected to move between the two actions.
Primary files:
application/single_app/functions_simplechat_operations.pyapplication/single_app/semantic_kernel_plugins/simplechat_plugin.pyapplication/single_app/semantic_kernel_loader.pyapplication/single_app/functions_governance.pyapplication/single_app/functions_authentication.pyapplication/single_app/route_backend_agents.pyapplication/single_app/static/js/plugin_modal_stepper.jsapplication/single_app/static/js/agent_modal_stepper.js
- 主要言語
- Python
- スター
- 157
- フォーク
- 117
- 平均マージ
- 4時間 3分
- マージ済み PR(30日)
- 217
環境構築
このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
microsoft/simplechat のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
microsoft/simplechat#1491 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
microsoft/simplechat#1370 ·
メンテナーはふだん 1 日以内に返信
-
Stale activeGroupOid after group removal interrupts chat in legacy and React V2対応中かも @paullizer が 2 日前に担当しました。 オープンbug P1
microsoft/simplechat#1816 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
Simple Chat - NLRオープン
難易度 3/5 1〜2日 初心者へのやさしさ 55/100
microsoft/simplechat#1804 ·
メンテナーはふだん 1 日以内に返信
-
Simple Chat - NLRオープン
難易度 3/5 1〜2日 初心者へのやさしさ 48/100
microsoft/simplechat#1803 ·
メンテナーはふだん 1 日以内に返信
microsoft/simplechat の issue をすべて見る
似ている issue
-
難易度 1/5 1〜3時間 初心者へのやさしさ 85/100
WLAN-Pi/wlanpi-profiler#341 ·
メンテナーはふだん 1 日以内に返信
-
Memory leak: the shared `validation_aborted_error` keeps every traceback it is raised through対応中かも @Fire162 が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
graphql-python/graphql-core#287 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 67/100
roman-corgi/ctc-dip#160 ·
メンテナーはふだん 1 日以内に返信
-
type-bug
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
メンテナーはふだん 1 日以内に返信
-
render_findings.py reads and writes in the host's default encoding, so findings.html breaks on a cp1252 Windows host対応中かも @Aaqibhafeezkhan が今日担当しました。 オープンbug good first issue mentored python size: XS up-for-grabs
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
dheerajjha/mcp-migrate#366 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信