Python: Bug: Redis search returns None for every field that declares a storage_name, because RETURN lists the declared name
メンテナーはふだん 5 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 初心者へのやさしさ
- 78/100
調査の方向性
python/semantic_kernel/connectors/redis.pyから始め、両方のcollectionクラスにある_add_return_fieldsとRedisHashsetCollection._deserialize_store_models_to_dictsを読みます。次にtests/unit/connectors/memory/test_redis_store.pyを調べ、そのテストを実行します。両方のcollectionが検索結果でストレージ名を返し、Hashsetのベクトルのデシリアライズが検索時と取得時のどちらでも浮動小数点数のリストを生成すれば完了です。
索引モデルが issue の本文から書いたものです。
説明
Description
When a field of a Redis collection declares a storage_name, a search returns the record without that field.
The collection creates the index attributes under storage_name or name, and it stores the values under storage_name or name. The KNN part of the search query also uses the storage name. But the RETURN clause of the query lists the declared field name. The server has no attribute with that name, so it leaves the field out.
- A data field with a
storage_namecomes back asNone(dict or dataclass record types). For a pydantic record type, the validation fails because the field is missing. - With
include_vectors=True, a vector field with astorage_nameis not returned either. RedisHashsetCollectionhas a second problem in the same area. It decodes the vector bytes and writes the array under the declared name. The data model step then reads the storage name key, so the vector stays raw bytes. This also hitsget, not onlysearch.
Both RedisHashsetCollection and RedisJsonCollection have the wrong RETURN list.
Reproduction
I ran this on current main (df1cb33d0), Python 3.13, redis-py and redisvl 0.27.2. I have no Redis Stack server here. The fake ft(...).search below answers the way RediSearch does for RETURN: only the attributes named in RETURN come back, plus the key. The RETURN list it prints is the one the connector sends.
import asyncio
import struct
import warnings
from types import SimpleNamespace
warnings.filterwarnings("ignore")
from redis.asyncio import Redis
from redis.commands.search.document import Document
from redisvl.schema import IndexSchema
import semantic_kernel.connectors.redis as redis_module
from semantic_kernel.connectors.redis import RedisHashsetCollection
from semantic_kernel.data.vector import VectorStoreCollectionDefinition, VectorStoreField
DEFN = VectorStoreCollectionDefinition(
fields=[
VectorStoreField("key", name="id", type="str"),
VectorStoreField("data", name="title", type="str", storage_name="doc_title", is_indexed=True),
VectorStoreField("vector", name="vec", dimensions=3, storage_name="doc_vec", type="float"),
]
)
VEC = struct.pack("<3f", 0.1, 0.2, 0.3)
STORED_HASH = {"doc_title": "hello", "doc_vec": VEC, "vector_distance": "0.25"}
class FakeFT:
async def search(self, query, query_params=None):
args = query.get_args()
i = args.index("RETURN")
wanted = args[i + 2 : i + 2 + args[i + 1]]
print("RETURN sent to the server:", wanted)
doc = {"id": "c:k1", "payload": None}
for name in wanted:
if name in STORED_HASH:
doc[name] = STORED_HASH[name]
return SimpleNamespace(docs=[Document(**doc)], total=1)
SCHEMA = IndexSchema.from_dict(
{
"index": {"name": "c", "prefix": "c", "storage_type": "hash"},
"fields": [
{"name": "doc_title", "type": "text"},
{
"name": "doc_vec",
"type": "vector",
"attrs": {"dims": 3, "algorithm": "flat", "distance_metric": "cosine", "datatype": "float32"},
},
],
}
)
async def fake_from_existing(*args, **kwargs):
return SimpleNamespace(schema=SCHEMA)
redis_module.AsyncSearchIndex.from_existing = fake_from_existing
async def main():
db = Redis()
db.ft = lambda name: FakeFT()
col = RedisHashsetCollection(record_type=dict, definition=DEFN, collection_name="c", redis_database=db)
print("stored attributes:", ["doc_title", "doc_vec"])
res = await col.search(vector=[0.1, 0.2, 0.3], top=3, include_vectors=True)
async for r in res.results:
print("search record:", r.record)
# the get path: a stored hash read back through the same deserialization
store_record = {"id": "k1", "doc_title": "hello", "doc_vec": VEC}
print("get record:", col.deserialize([store_record], include_vectors=True))
asyncio.run(main())
Output on main:
stored attributes: ['doc_title', 'doc_vec']
RETURN sent to the server: ['vector_distance', 'id', 'title', 'vec']
search record: {'id': 'c:k1', 'title': None, 'vec': None}
get record: [{'id': 'k1', 'title': 'hello', 'vec': b'\xcd\xcc\xcc=\xcd\xccL>\x9a\x99\x99>'}]
The stored hash has doc_title and doc_vec, but the query asks for title and vec. The search result has None for both fields. The get record has the title, but the vector is still bytes.
For RedisJsonCollection the generated RETURN list is the same, ['vector_distance', 'id', 'title', 'vec'], while the index attributes are doc_title and doc_vec. I printed it with col._construct_vector_query([0.1, 0.2, 0.3], VectorSearchOptions(include_vectors=True)) and query.get_args().
Cause
In python/semantic_kernel/connectors/redis.py, _add_return_fields of both collections calls query.return_field(field.name). Everything else in the file uses field.storage_name or field.name: _definition_to_redis_fields, the serializers, the KNN vector_field_name and the filter parser.
In RedisHashsetCollection._deserialize_store_models_to_dicts, the vector is decoded into rec[field.name]. VectorStoreCollection._deserialize_dict_to_data_model reads record.get(field.storage_name or field.name) for dict and dataclass types, and for pydantic types it moves the storage key over the declared name. In both cases the raw bytes win.
The same thing was reported and fixed for Azure AI Search hybrid search in #14684.
Expected
A field with a storage_name is returned by search and by get, with the same value as a field without one. The vector is decoded to a list of floats.
Possible fix
I have a branch ready: https://github.com/VANDRANKI/semantic-kernel/tree/fix/redis-return-fields-storage-name
_add_return_fieldsof both collections returnsfield.storage_name or field.name.- The Hashset deserialization decodes the vector in place under the storage name, and also keeps the value under the declared name.
It adds 6 tests to tests/unit/connectors/memory/test_redis_store.py: the RETURN list for both collections with and without vectors, a search through a fake ft.search that honors RETURN, and the vector decode. All 6 fail on main. The 35 tests in that file pass on the branch, and ruff check and format are clean.
I can't open a pull request from this account right now, so the compare link is https://github.com/microsoft/semantic-kernel/compare/main...VANDRANKI:semantic-kernel:fix/redis-return-fields-storage-name
- 主要言語
- C#
- スター
- 28.7k
- フォーク
- 4.9k
- 平均マージ
- 5日 3時間
- マージ済み PR(30日)
- 63
環境構築
このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
microsoft/semantic-kernel のほかの issue
-
.Net: gpt-image-1 is the default image model in the .NET OpenAI connector, and OpenAI shuts it down on October 23対応中かも @nightcityblade が 36 日前に担当しました。 オープン.NET triage
難易度 2/5 1〜3時間 初心者へのやさしさ 73/100
microsoft/semantic-kernel#14526 · コメント 1 件 ·
メンテナーはふだん 5 日以内に返信
-
Python: VolatileMemoryStore.get_batch and get_nearest_matches ignore with_embeddings=False (deepcopy result is discarded)対応中かも @VANDRANKI が 38 日前に担当しました。 オープンpython triage
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
microsoft/semantic-kernel#14522 ·
メンテナーはふだん 5 日以内に返信
-
.Net: Bug: BinaryContent does not decode the %xx escapes of a non-base64 data URI対応中かも @Laurianti が 38 日前に担当しました。 オープン.NET triage
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
microsoft/semantic-kernel#14518 ·
メンテナーはふだん 5 日以内に返信
-
Python: FunctionCallContent.combine_arguments drops a streamed "{}" chunk, producing invalid JSON arguments対応中かも @VANDRANKI が 39 日前に担当しました。 オープンpython triage
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
microsoft/semantic-kernel#14512 · コメント 2 件 ·
メンテナーはふだん 5 日以内に返信
-
Python: NAMED_ARG_REGEX character-class bug [${1}] lets non-$-prefixed values ({, 1, }) be silently parsed as variable references対応中かも @aniketkrs が 42 日前に担当しました。 オープンpython triage
難易度 2/5 1〜3時間 初心者へのやさしさ 85/100
microsoft/semantic-kernel#14491 · コメント 1 件 ·
メンテナーはふだん 5 日以内に返信
microsoft/semantic-kernel の issue をすべて見る
似ている issue
-
NEW ISSUE Requestor-Player
難易度 2/5 1〜3時間 初心者へのやさしさ 81/100
tModLoader/tModLoader#5575 · リアクション 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信
-
A: Art Beginner Friendly P3: Standard T: Bugfix
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
space-wizards/space-station-14#46728 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 65/100
-
bug ready-for-agent
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
fboucher/2d6-dungeon-app#291 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信