[MCP]: Add optional atomic upload action for file chooser triggers

クローズ
  • 何か問題がありますか？
#43,546 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
38/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
playwright, typescript
領域
testing-qa, tooling

調査の方向性

Start with packages/playwright-core/src/tools/backend/files.ts and tool.ts, then read tests/mcp/files.spec.ts to understand upload handling, modal guards, and the two-step flow. The proposal requires coordinating chooser timing, existing target and file validation, failure cleanup, and tests. Done means an optional atomic upload action works with deterministic errors and preserves the existing APIs and access restrictions.

索引モデルが issue の本文から書いたものです。

説明

What's going on?
Feature request: optional one-call file picker upload

The current Playwright MCP workflow for an element that opens a native file chooser is intentionally two-step:

  1. browser_click({ element: "Choose file", target: "e2" })
  2. browser_file_upload({ paths: ["/workspace/example.txt"] })

While the chooser is pending, the MCP backend correctly restricts other tab tools. This is not a report of a broken modal guard. I'd like to propose an optional atomic action that performs both steps within one tool invocation, without changing existing APIs.

Reproduction / motivation

Tested on @playwright/[email protected] (current published npm version on 2026-10-20), Node.js 22 and Chrome in an isolated headless browser. The page was served locally and contained only a button that clicks a hidden <input type="file">, a harmless second button, and a status text node.

  • browser_navigate and browser_snapshot: succeed.
  • browser_click on the upload trigger: succeeds; response reports [File chooser] modal state.
  • browser_snapshot while that chooser is pending: returns Tool "browser_snapshot" does not handle the modal state. (7 ms).
  • Clicking the unrelated button: similarly blocked (14 ms).
  • browser_file_upload({}): clears the modal state; the next snapshot succeeds.
  • Reopen chooser, call browser_file_upload({ paths: [file] }): file selected and the next snapshot succeeds.

This confirms expected current behavior, not a reproduced upstream hang. The remaining gap is orchestration: when an agent's upload steps are interrupted, retried, or interleaved with another tool call, it can be left in a chooser-only state requiring separate recovery. This is particularly awkward for long-running agent workflows and extension-connected tabs.

Proposal

Consider an opt-in browser_upload_files tool (name/API flexible), roughly:

{ "element": "Choose file button", "target": "e2", "paths": ["/workspace/example.txt"] }

Expected behavior:

  • Validate target using the existing browser target resolution and validate paths using the existing workspace/file-access restrictions.
  • Click the target and wait for the newly opened file chooser within a bounded timeout.
  • Set files using the existing upload implementation and return the resulting snapshot/status.
  • If no chooser opens, fail with a clear error; do not consume an unrelated previously pending chooser. Define safe, deterministic cleanup/retry semantics for failure.
  • Preserve browser_click and browser_file_upload unchanged for backwards compatibility. No relaxation of browser permissions or file access.

The existing defineTabTool modal guard and tests already cover the two-step flow; this proposal would add an optional higher-level operation, not remove the guard. See packages/playwright-core/src/tools/backend/{files.ts,tool.ts} and tests/mcp/files.spec.ts.

Could maintainers advise whether this belongs upstream? I can contribute a focused implementation and tests if this issue is approved/assigned, per the contributing guidelines. No production website or private user data was used for the reproduction.

Version

@playwright/mcp 0.0.83 (npm); upstream main 27219bd2cc94e1ebceec58f188760a6bf458c192

主要言語
TypeScript
スター
98.5k
フォーク
6.7k
平均マージ
15時間 58分
マージ済み PR（30日）
302

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

microsoft/playwright のほかの issue

microsoft/playwright の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。