nvx-rs: replace the golden launch-profile and sandbox-option fixtures with specification tests
メンテナーはふだん 1 日以内に返信
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 25/100
調査の方向性
Start by reading the listed sandbox tests and src/host/sandbox/{golden.rs,mod.rs,layer.rs,mount.rs,options.rs}, plus the OpenVMM and guest contracts; this is step 4 of #722 and depends on #726. Replace fixture checks with the named specification tests and map each fixture section to a test. Done means both fixtures are removed, the new tests pass on Linux and Windows, every section is covered, and accepted launches retain their OpenVMM arguments and kernel tokens.
索引モデルが issue の本文から書いたものです。
説明
Related: #723.
Goal
Replace tests/fixtures/sandbox.json, tests/fixtures/sandbox_options.json, and src/host/sandbox/golden.rs with table-driven and property tests derived from the documented options and from the contracts with OpenVMM and the guest. Then make the checks Rust-native.
Background
sandbox.jsonholds 1,412 cases in POSIX and Windows path flavors: 213 identities, 320 layers, 212 mount values, 228 mount targets, 53 child names, 210 mounts, and 176 launches. Since #556 removed the runtime and custom block roles, 130 of the launches end in the same error.sandbox_options.jsonholds 885 cases: 128 share targets ofrun, 250 sandbox mounts, 80 exec environments, 109 environment files, and 318 distro manifests.- Six tests check them:
identities_and_layers_parse_as_python_parses_them,mount_values_targets_and_child_names_match_python,mounts_lower_to_the_arguments_that_python_gives,launches_give_the_arguments_and_command_lines_that_python_gives,sandbox_option_helpers_match_nvx_py, andenvironment_files_and_distro_manifests_read_as_python_reads_them. - Contracts that the new tests keep: OpenVMM's arguments, the guest's kernel tokens and their 1024-byte budget, the reserved targets and tokens, and the names of an aggregate's children,
INDEX-HEX, whereHEXis the first 16 bytes of the SHA-256 of the target, on which restores depend. - Python behavior that goes: Python's messages and
reprquoting,int()'s Unicode digits and underscores, the other spellings thatuuid.UUIDaccepts, the leniency ofjson.loads, and checking both path flavors on every host.
Tasks
Replacement tests, in a pull request that doesn't change behavior:
-
workload_identity_grammar:UID:GIDfrom 1 to 4294967295, root refused, and malformed values. -
layer_values_are_role_path_uuid: onlydistro; a canonical UUID reaches the guest token unchanged; a configuration of a retired role is refused. -
mount_value_grammar:TARGET,HOST, optionally followed by,roor,rw, commas in host paths, and empty parts. -
reserved_mount_targets_are_refused: a property over the reserved trees and exact targets. -
aggregate_child_names_follow_the_restore_contract: a property that computes the names withsha2, and known answers such as0-c52ddf65534b7b46035084358ab7902bfor/workspaceat index 0. -
launch_arguments_follow_the_openvmm_contract -
kernel_command_line_stays_within_1024_bytes: a property that a launch's command line either fits and holds every token or is refused, and that reserved tokens are always refused. -
policy_paths_attach_to_their_shares: a property over sequences of options, forsandbox, where they apply to the--mountbefore them, and forrun, where they apply to the share that holds them. -
exec_environment_limitsandenvironment_files_hold_a_json_array_of_strings. -
distro_manifest_binds_the_layerandsystemd_entrypoint_needs_systemd_in_the_manifest. -
host_paths_become_absolute: a property on each OS's own filesystem, and a table of Windows drive-relative and UNC paths. - A temporary table that maps every section of the two fixtures to tests.
Retirement, in the next pull request:
- Integers are ASCII decimal within documented ranges, UUIDs are canonical, environment files and distro manifests are strict JSON, and messages quote values as Rust does.
- Values that become kernel tokens refuse the separators of #723, if it hasn't landed yet.
- Each host checks its own path flavor only.
- Replace
nvx::host::sandbox::{Int, IntError}, which re-export Python's integers, and note the API change in the README. - Delete the two fixtures and
src/host/sandbox/golden.rs. - Docs: the README's module table and "Python parity", and
doc/usage.mdanddoc/run.mdwhere accepted input changes.
Gate
- The lines and branches that only these fixtures reach, on Windows and Linux (#726), are reached by the new tests or deleted.
-
cargo mutantsonsrc/host/sandbox/mod.rs,layer.rs,mount.rs, andoptions.rsmisses no mutant with the new tests that the fixtures catch. - Every section maps to a test.
- The OpenVMM arguments and kernel tokens of every launch that the fixtures accept are unchanged.
Acceptance criteria
- The two fixtures are gone, and the new tests pass on Linux and Windows.
- 主要言語
- Python
- スター
- 408
- フォーク
- 28
- 平均マージ
- 16時間 20分
- マージ済み PR(30日)
- 355
環境構築
このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
microsoft/nvx のほかの issue
-
Track nvx-rs host VMM supervisor bugs: a non-UTF-8 process name at a reused PID blocks reconcile, reattach, and stop対応中かも @56steve が 1 日前に担当しました。 オープンbug-hunt confirmed good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
microsoft/nvx#720 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 25/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 24/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 38/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 25/100
メンテナーはふだん 1 日以内に返信
似ている issue
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 1 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
sergey-miryanov/gcmon#230 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
Azure-Samples/azure-search-openai-demo#3249 ·
メンテナーはふだん 1 日以内に返信
-
[BUG] Failed archive extraction deletes the dataset cache対応中かも @dajiaohuang が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
alibaba/GraphScope#4674 ·