openvmm: virtiofs: inode deduplication key omits host device number (st_dev)

オープン
#1,604 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
半日
初心者へのやさしさ
64/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
rust

調査の方向性

Start in vm/devices/virtio/virtiofs/src/inode.rs at the DedupKey::Ino variant and VirtioFsInode::dedup_key, then follow its use into InodeMap::insert in vm/devices/virtio/virtiofs/src/lib.rs. The fix carries device_nr in the stable-ID key, so check every construction and match site of DedupKey::Ino. Done means the two-inode construction in step 5 of the report yields distinct node IDs; run the virtiofs crate tests via cargo nextest to confirm nothing else shifts.

索引モデルが issue の本文から書いたものです。

説明

Summary

On volumes that report stable file IDs, VirtioFs deduplicates inodes in InodeMap by (volume_id, inode_nr) instead of (volume_id, device_nr, inode_nr). When a single shared directory tree spans multiple host st_dev values — such as nested bind mounts or btrfs subvolumes, where every subvolume root has st_ino == 256 on its own anonymous st_dev — two distinct host objects with the same st_ino collide onto one FUSE node ID and overwrite that node's stored host path. Found by testing (also blocks formal verification).

Root Cause

In vm/devices/virtio/virtiofs/src/inode.rs, DedupKey::Ino omits stat.device_nr, and VirtioFsInode::dedup_key keys stable-ID volumes solely by (self.volume_id(), self.inode_nr()):

#[derive(Clone, PartialEq, Eq, Hash)]
pub(crate) enum DedupKey {
    /// `(volume_id, host_inode_number)`, for stable-id volumes.
    Ino(u32, lx::ino_t),
    /// `(volume_id, host_path)`, for volumes that recycle inode numbers.
    Path(u32, PathBuf),
}
    pub(crate) fn dedup_key(&self) -> DedupKey {
        if self.volume.supports_stable_file_id() {
            return DedupKey::Ino(self.volume_id(), self.inode_nr());
        }
        DedupKey::Path(self.volume_id(), self.get_path().clone())
    }

When a lookup resolves a second host object with the same st_ino and file type on a different st_dev, InodeMap::insert takes the Entry::Occupied branch and calls VirtioFsInode::lookup, replacing existing.path with new_path and returning existing's node_id.

Consequence

In POSIX, file identity is (st_dev, st_ino), not st_ino alone. On btrfs, unprivileged users can create subvolumes whose root directory always has st_ino == 256 with a distinct st_dev; container rootfs layers, bind mounts, and nested mounts inside a shared directory produce the same condition on ext4/xfs/overlayfs. If the share root is a btrfs subvolume (FUSE_ROOT_ID == 1, st_ino == 256, path == "") and contains a nested subvolume sub (st_ino == 256, path == "sub"), looking up sub returns nodeid == 1 (producing a directory cycle in the guest VFS) and overwrites the root inode's stored path from "" to "sub", causing subsequent lookups at the share root to resolve inside "sub" and making entries outside "sub" disappear with ENOENT. Colliding regular files across subvolumes or nested mounts likewise alias onto one FUSE node ID, misdirecting path-based operations (getattr, open, setattr, unlink, and microVM subtree policy checks) to whichever path was looked up most recently, and causing microVM save_microvm_state to fail when validate_saved_identity detects that a single inode's recorded aliases have different device_nr values.

Reproduction

  1. On a Linux host with btrfs (for example by running cargo nextest with TMPDIR on a btrfs filesystem), create a btrfs subvolume root, create a nested btrfs subvolume root/sub, and create a regular file root/only_in_root.
  2. Instantiate VirtioFs::new(&root_path, None) so FUSE_ROOT_ID (1) refers to root (st_ino == 256).
  3. Call fs.lookup(&request(FUSE_ROOT_ID), lx::LxStr::from_bytes(b"sub")). It erroneously returns sub.nodeid == FUSE_ROOT_ID (1) and rewrites node 1's path from "" to "sub".
  4. Call fs.lookup(&request(FUSE_ROOT_ID), lx::LxStr::from_bytes(b"only_in_root")). It fails with ENOENT because VirtioFs resolves "sub/only_in_root" instead of "only_in_root".
  5. Without btrfs, constructing two VirtioFsInode values via VirtioFsInode::with_attr with (device_nr: 1, inode_nr: 256) at "a" and (device_nr: 2, inode_nr: 256) at "b" and inserting both into InodeMap reproduces the same node ID collision deterministically on any host filesystem.

Related: #1605, #1619, #1602.

主要言語
Rust
スター
848
フォーク
63
平均マージ
13時間 37分
マージ済み PR(30日)
571

環境構築

  • Dockerfile・Docker Compose ファイルなし
  • プルリクエストのテンプレートあり
  • コントリビューションガイドなし

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

microsoft/nvx のほかの issue

microsoft/nvx の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。