event_loop_blocked can emit a parentless span when the stall is sampled in job_task after session close
メンテナーはふだん 1 日以内に返信
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 48/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- python
調査の方向性
Start with telemetry/loop_monitor.py, especially _emit_span around line 446, then trace the task and session context setup in ipc/job_proc_lazy_main.py and voice/agent_session.py at the cited locations. Reproduce or test the outer job_task stall after session close and inspect why the report-context fallback does not provide a parent. Done means resolving the cause so the emitted span has the intended parent, or is skipped when none is valid.
索引モデルが issue の本文から書いたものです。
説明
Summary
An event_loop_blocked span can be emitted with no parent, becoming a stray root, when the stall is sampled in the outer job_task after the agent session has closed. The documented third-tier fallback in _emit_span — "else the report context (job_entrypoint)" — does not appear to be reached in this path.
Introduced by #7128 (1ac4183fc), so this is main-only; loop_monitor.py is not present in 1.8.4 or earlier.
Observed
In one 579 s voice session on main (8a677a62), 5 event_loop_blocked spans were emitted. 4 parented correctly. The 5th did not:
| sampled in task | parent |
|---|---|
job_user_entrypoint |
job_entrypoint ✅ |
LLM._main_task |
the task's own span ✅ |
| (task span) | the task's own span ✅ |
| (task span) | the task's own span ✅ |
job_task |
none — stray root ❌ |
The orphan fired at t+561.18 s, in the same millisecond agent_session and session_close ended (t+561.17 s), and ~18 s before job_entrypoint itself ended (t+579.13 s). So the root span was still open and still a valid parent at the time.
Why the fallback chain doesn't cover it
_emit_span (telemetry/loop_monitor.py:446) selects a parent in three tiers, per its own comment — "under the span the blocked task was in, else the session root, else the report context (job_entrypoint)":
if report.parent_span_context is not None:
parent = trace.set_span_in_context(trace.NonRecordingSpan(report.parent_span_context))
else:
parent = session_context.session_root_context()
span = tracer.start_span(SPAN_NAME, context=parent, start_time=start_ns, attributes=attributes)
Tier 1 is unavailable for job_task. _run_job_task is created at ipc/job_proc_lazy_main.py:323, and only the inner job_user_entrypoint task (:359) has its body wrapped in tracer.use_span(job_span, ...). The outer task is what creates job_span, never runs inside it, so a stall sampled there has no task span to inherit.
Tier 2 is cleared at session close. voice/agent_session.py:1356 sets self._root_span_context = None, so session_root_context() returns None from that point on.
Tier 3 then appears not to fire. With parent = None, start_span(context=None) should resolve to the ambient context, and _emit runs inside self._report_context.run(_emit) whose snapshot was taken inside use_span(job_span) — so job_entrypoint should be current. The emitted span nonetheless has no parent. I have not pinned down why, and did not want to guess at a patch.
Note that event_loop_blocked is the only span in the system whose parentage is reconstructed rather than inherited — it originates on the watchdog thread, which has no ambient OTel context of its own. That is what set_report_context(contextvars.copy_context()) at job_proc_lazy_main.py:347 exists for, and it is why this path has no natural backstop.
Impact
Low. At most one diagnostic span per session, and it still carries the same trace id, so nothing else is detached. But a backend that groups by trace membership renders it as a separate root, which is noise in exactly the view #7533 set out to clean up.
Possible directions
Offered as suggestions rather than a diagnosis, since I could not confirm the tier-3 failure:
- In
_emit_span, fall through to the ambient/report context whensession_root_context()yields no span with a valid context, instead of passing its result ascontext=unconditionally — this makes the documented tier 3 actually reachable. - Wrap
_run_job_task's body inuse_span(job_span)so tier 1 also covers stalls sampled in the outer job task. - Alternatively, skip emitting when no valid parent can be resolved —
_emit_spanalready returns early when there is no job context (loop_monitor.py:442), on the same reasoning that "a root span here would be a stray trace".
Environment
livekit-agentsmain @8a677a62, Python 3.13- OTLP/HTTP export, voice (cascade) pipeline, single session per job process
- 主要言語
- Python
- スター
- 14.6k
- フォーク
- 3.9k
- 平均マージ
- 3日 11時間
- マージ済み PR(30日)
- 196
環境構築
このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
livekit/agents のほかの issue
-
Assistant markup is stripped from chat history when expressive mode is off対応中かも @ShivamSharma43 が 17 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
メンテナーはふだん 1 日以内に返信
-
docs: openai.LLM vs openai.responses.LLM for HTTP OpenAI-compat hosts再び着手できるかも @AbarnaaSree が 57 日前に担当しましたが、オープン中のプルリクエストはありません。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
livekit/agents#7022 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
メンテナーはふだん 1 日以内に返信
-
TranslationRoomIO: unset_track() before a track is linked stalls startup, so the translation is never published対応中かも @RaphaelFakhri が 1 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 20/100
livekit/agents#8114 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
Python AgentServer health check (GET /) returns 200 before the worker has registered with LiveKit対応中かも @ninglinLiu が 2 日前に担当しました。 オープン
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
livekit/agents#8092 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
似ている issue
-
The changelog workflow excludes otelbot but not dependabot, so every Dependabot pull request fails the changelog check対応中かも @ocelotl が今日担当しました。 オープン
難易度 1/5 1時間未満 初心者へのやさしさ 82/100
open-telemetry/opentelemetry-python#5825 ·
メンテナーはふだん 2 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
cuga-project/cuga-agent#1020 ·
メンテナーはふだん 2 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 70/100
microsoft/playwright#43640 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
stac-utils/stac-fastapi-elasticsearch-opensearch#965 ·
メンテナーはふだん 2 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
メンテナーはふだん 1 日以内に返信