Verifier crashes on a field or enum constant whose declaring class cannot be resolved
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
調査の方向性
The crash is in Utils.qualifyFieldName (Utils.java, around line 56), reached from RefinementTypeChecker.visitCtFieldRead (line 325) when a CtFieldReference has a null declaring type. Start by running the four-line Repro class from the issue against the verifier and checking how the null case is handled for other field reads. Done means the reproducer prints the 'Passed Verification' result with the compilation warning instead of throwing, and the unresolved-type case is covered by a test.
索引モデルが issue の本文から書いたものです。
説明
Impact: verification stops with an internal error: 5 of the 53 real-world files below.
Description
Reading a field whose declaring type is unknown (an enum constant in a case label, a field generated by Lombok such as log, an array's .length on a value of an unresolved type): CtFieldReference.getDeclaringType() is null and Utils.qualifyFieldName calls getQualifiedName() on it.
Minimal reproducer (org.example.missing is not on the classpath)
import org.example.missing.Mode;
public class Repro {
static int weight(Mode mode) {
switch (mode) {
case STATEFUL:
return 2;
default:
return 1;
}
}
}
Expected
Correct! Passed Verification. (with the "Java compilation encountered issues" warning).
Actual
Exception in thread "main" java.lang.RuntimeException:
Error while checking CtMethodImpl
on weight(Mode mode) {
at Repro.java:4
with
Error while checking CtBlockImpl
on {
at Repro.java:4
with
Error while checking CtSwitchImpl
on switch (mode) {
at Repro.java:5
with
Error while checking CtCaseImpl
on case STATEFUL:
at Repro.java:6
with
Error while checking CtFieldReadImpl
on STATEFUL:
at Repro.java:6
with Cannot invoke "spoon.reflect.reference.CtTypeReference.getQualifiedName()" because the return value of "spoon.reflect.reference.CtFieldReference.getDeclaringType()" is null
at liquidjava.processor.refinement_checker.TypeChecker.scan(TypeChecker.java:80)
at spoon.reflect.visitor.CtScanner.scan(CtScanner.java:189)
at spoon.reflect.visitor.CtScanner.scan(CtScanner.java:154)
at spoon.reflect.visitor.CtScanner.visitCtClass(CtScanner.java:363)
at liquidjava.processor.refinement_checker.RefinementTypeChecker.visitCtClass(RefinementTypeChecker.java:97)
at spoon.support.reflect.declaration.CtClassImpl.accept(CtClassImpl.java:63)
at liquidjava.processor.RefinementProcessor.lambda$processPackage$3(RefinementProcessor.java:51)
at java.base/java.lang.Iterable.forEach(Iterable.java:75)
at liquidjava.processor.RefinementProcessor.processPackage(RefinementProcessor.java:50)
at liquidjava.processor.RefinementProcessor.process(RefinementProcessor.java:35)
at liquidjava.processor.RefinementProcessor.process(RefinementProcessor.java:15)
at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:72)
at spoon.support.QueueProcessingManager.process(QueueProcessingManager.java:118)
at spoon.support.QueueProcessingManager.process(QueueProcessingManager.java:132)
at liquidjava.api.CommandLineLauncher.launch(CommandLineLauncher.java:92)
at liquidjava.api.CommandLineLauncher.main(CommandLineLauncher.java:41)
...
Caused by: java.lang.NullPointerException: Cannot invoke "spoon.reflect.reference.CtTypeReference.getQualifiedName()" because the return value of "spoon.reflect.reference.CtFieldReference.getDeclaringType()" is null
at liquidjava.utils.Utils.qualifyFieldName(Utils.java:56)
at liquidjava.processor.refinement_checker.RefinementTypeChecker.visitCtFieldRead(RefinementTypeChecker.java:325)
at liquidjava.processor.refinement_checker.TypeChecker.scan(TypeChecker.java:69)
Reproduced on main at dcfc4eb2 (liquidjava-verifier 0.0.35).
Real-world files that hit it
log.error("get host name error:{}", e.getMessage());— apache/ozhera (file)UNKNOWN_CASING;— apache/derby (file)(p.define().length > 0 || p.include().length > 0 || p.cinclude().length > 0 ||— larael/javacpp (file)STATEFUL:— stratwine/openejb (file)(config.httpAdminPassword.length() < MIN_ADMIN_PASSWORD_LENGTH) {— spazio17/muralis (file)
Context
Found while running LiquidJava on the original repository files of 53 real-world typestate and refinement bugs (the same files as our study exercises, before simplification). Each file is verified on its own, as a user would on one file of a project, so the project's other classes and its dependencies are not on the classpath. On main this crash and the two related ones (#388 binary operator, #389 unary operator, #390 field read) stop verification in 33 of the 53 files.
- 主要言語
- Java
- スター
- 67
- フォーク
- 36
- 平均マージ
- 2日 3時間
- マージ済み PR(30日)
- 29
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
liquid-java/liquidjava のほかの issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
liquid-java/liquidjava#388 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
liquid-java/liquidjava#373 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
liquid-java/liquidjava#321 ·
メンテナーはふだん 1 日以内に返信
-
Verifier crashes on `!` (or another unary operator) applied to a call whose type cannot be resolvedオープンbug
難易度 3/5 1〜2日 初心者へのやさしさ 65/100
liquid-java/liquidjava#389 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 25/100
liquid-java/liquidjava#381 ·
メンテナーはふだん 1 日以内に返信
liquid-java/liquidjava の issue をすべて見る
似ている issue
-
[BUG] Re-subscribing the Mono returned by listTools/listResources/listResourceTemplates/listPrompts/listRoots duplicates the results対応中かも このイシューにリンクされたプルリクエストがオープン中、またはマージ済みです。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
modelcontextprotocol/java-sdk#1174 · リアクション 1 件 ·
メンテナーはふだん 2 日以内に返信
-
module: core
難易度 2/5 1〜3時間 初心者へのやさしさ 77/100
bigbluebutton/bigbluebutton#26028 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
MetricsHub/metricshub-community#1390 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
apache/rocketmq-dashboard#6331 ·
メンテナーはふだん 5 日以内に返信
-
status: team-only type: dependency-upgrade
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
spring-projects/spring-boot#52143 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信