[BUG] Application role restrictions are ignored when using "Treat Tags As: Categories"
まだ誰も着手していません。
評価
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 初心者へのやさしさ
- 78/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 領域
- authorization, backend
調査の方向性
app/Http/Controllers/ItemController.php の ItemController::dash() から始め、categories ブランチを、すでに whereIn('role', $roles) でフィルタしている folders ブランチと比較してください。with('children', ...) クロージャ内の pinned() の隣に同じロール制約を追加し、ヘッダーがない場合に $roles がどのようにパースされるかを確認して、制限なしの項目が隠れないようにしてください。完了とは、ヘッダーに staff のみが含まれるユーザーがカテゴリ内で staff タイルだけを見えることです。上で説明した remote-groups ヘッダーで再現してください。
索引モデルが issue の本文から書いたものです。
説明
Description
When role-based authorization is enabled using AUTH_ROLES_ENABLE=true, Heimdall correctly supports assigning roles to individual application tiles.
However, when Treat Tags As is set to Categories, the configured application-level role restrictions are not enforced.
Applications assigned to a tag become visible on the dashboard regardless of whether the authenticated user belongs to the required group.
This appears to be a regression in authorization behavior depending on the selected dashboard layout.
Tags are only used to organize applications into categories. Assigning an application to a tag should not affect its existing role restrictions.
Environment
Deployment: Docker
Docker image: LinuxServer.io Heimdall
Image tag:
latest(exact image reference to be confirmed)Application version: To be confirmed from the running container
Source code analyzed: Heimdall v2.8.4
Authentication: External authentication with group information forwarded through HTTP headers
Role header:
remote-groupsRole-based authorization: Enabled
Treat Tags As:
Categories
Relevant example configuration:
AUTH_ROLES_ENABLE=true
AUTH_ROLES_HEADER=remote-groups
AUTH_ROLES_ADMIN=admin
The configuration and identifiers below illustrate a minimal reproduction scenario and do not contain production credentials or actual user information.
Minimal reproduction setup
Users and groups
Two regular users are provided by an external authentication system.
User A: Alice
Username: alice
remote-groups: staffUser B: Bob
Username: bob
remote-groups: operationsNeither user has the admin role.
Applications
Create two applications with different role restrictions:
| Application | Assigned role | Pinned |
|---|---|---|
| Internal Wiki | staff | Yes |
| Infrastructure Monitoring | operations | Yes |
Assign both applications to this tag.
Configure Heimdall to display tags as categories:
Settings → Treat Tags As → Categories
The tag is intended exclusively for organizing applications on the dashboard. It should not override or replace the roles assigned to individual applications.
Steps to reproduce
Start Heimdall with role-based authorization enabled.
Configure an external authentication system to forward the authenticated user's group memberships through the
remote-groupsheader.Create two application tiles:
Internal Wiki, restricted tostaff.Infrastructure Monitoring, restricted tooperations.
Ensure both applications are pinned.
Create a tag named
Infrastructureand pin it.Assign both application tiles to the
Infrastructuretag.Set
Treat Tags AstoCategories.Open Heimdall as a regular user whose
remote-groupsheader contains onlystaff.Inspect the applications displayed under the
Infrastructurecategory.
Expected behavior
The authenticated user's group memberships should determine which application tiles are visible, independently of the dashboard layout.
For Alice (remote-groups: staff), the dashboard should display:
Infrastructure
└── Internal WikiInfrastructure Monitoring must not be displayed because Alice does not have the operations role.
For Bob (remote-groups: operations), the dashboard should display:
Infrastructure
└── Infrastructure MonitoringInternal Wiki must not be displayed because Bob does not have the staff role.
The category should only organize applications that the current user is permitted to see.
Actual behavior
Both applications are displayed under the Infrastructure category, regardless of the authenticated user's group memberships.
For Alice, the dashboard incorrectly displays:
Infrastructure
├── Internal Wiki
└── Infrastructure Monitoring <-- UnexpectedFor Bob, it incorrectly displays:
Infrastructure
├── Internal Wiki <-- Unexpected
└── Infrastructure MonitoringApplication-level role restrictions are therefore not enforced when applications are rendered within categories.
Additionally, assigning a non-matching role to the tag itself does not prevent the applications from appearing.
For example, assigning the tag the role restricted-test-group, which neither user possesses, does not resolve the problem.
The issue is not that tags lack additional authorization capabilities. The issue is that existing application-level restrictions are ignored.
Technical analysis
The behavior appears to originate in:
app/Http/Controllers/ItemController.php
Specifically, within ItemController::dash().
In Heimdall v2.8.4, the relevant code in the role-enabled branch is:
$roles = explode( config('app.auth_roles_delimiter'), $request->header(config('app.auth_roles_header')) ?? '' );
if ($treat_tags_as == 'categories') {
$data['categories'] = Item::whereHas('children')
->with('children', function ($query) {
$query->pinned()->orderBy('order', 'asc');
})
->pinned()
->orderBy('order', 'asc')
->get();
}
The authenticated user's roles are extracted into $roles, but they are not used in the query that retrieves the category's child applications.
The eager-loaded children relationship only applies the pinned scope and ordering.
Consequently, applications are retrieved without checking whether their assigned roles match the current user's roles.
In contrast, the Folders branch of the same controller contains an application role filter:
->whereIn('role', $roles)This suggests that role filtering was omitted from the category-specific query.
Source:
https://github.com/linuxserver/Heimdall/blob/v2.8.4/app/Http/Controllers/ItemController.php
Impact
This issue causes unintended disclosure of application tiles to users who do not possess the required roles.
Potentially exposed information includes:
Application names
Application URLs
Application icons
The existence of internal services
Service organization and category membership
It also makes dashboard visibility restrictions dependent on the selected presentation mode.
An administrator may configure application roles correctly while being unaware that switching to the Categories layout effectively disables those visibility restrictions.
This report does not claim that authentication or authorization in the linked applications can be bypassed. The observed issue concerns the visibility of application entries within Heimdall.
Suggested resolution
Ensure that application-level role restrictions are applied when loading applications belonging to categories.
The existing authorization behavior should remain consistent across dashboard presentation modes.
Specifically:
Retrieve the authenticated user's roles using the existing role-header mechanism.
Apply the existing application role restrictions to applications loaded through category relationships.
Ensure that unauthorized applications are not included in the rendered category contents.
Preserve the use of tags as organizational elements without introducing mandatory tag-level authorization.
This report does not request additional permissions on tags or role inheritance from categories to applications.
It only requests that the existing application-level restrictions continue to be enforced when the dashboard is displayed using categories.
Additional information
The problem is reproducible with applications assigned to the same category but restricted to different groups.
Changing the tag's own role does not resolve the unauthorized visibility of its applications.
The relevant distinction is between:
Application role: Determines whether the user should see the application.
Tag/category: Determines where the application is displayed.
A presentation setting should not disable an existing visibility restriction.
The expected outcome is that users continue to see only applications matching their assigned roles, regardless of how those applications are organized on the dashboard.
- 主要言語
- PHP
- スター
- 9.4k
- フォーク
- 626
- 平均マージ
- 13分
- マージ済み PR(30日)
- 3
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
linuxserver/Heimdall のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 58/100
linuxserver/Heimdall#1625 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 53/100
linuxserver/Heimdall#1624 · コメント 1 件 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 52/100
linuxserver/Heimdall#1613 ·
-
no-issue-activity
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
linuxserver/Heimdall#1601 · コメント 1 件 · リアクション 4 件 ·
-
no-issue-activity
難易度 3/5 1〜2日 初心者へのやさしさ 55/100
linuxserver/Heimdall#1588 · コメント 4 件 ·
linuxserver/Heimdall の issue をすべて見る
似ている issue
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 85/100
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 82/100
-
難易度 1/5 1時間未満 初心者へのやさしさ 85/100
Automattic/static-site-importer#3129 ·
メンテナーはふだん 1 日以内に返信
-
Group 2 - Data Storage | Tripal DBX | Chado Group 5 - Search | ElasticSearch | Views Priority - Medium
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
-
category::bug code priority::normal
難易度 1/5 1〜3時間 初心者へのやさしさ 85/100
e0ipso/simple_oauth_21#58 ·
メンテナーはふだん 1 日以内に返信