Cursor pagination doesn't validate the cursor position or page size

オープン
#6,393 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
django, python

調査の方向性

Start with ValuesViewsetCursorPagination in contentcuration/contentcuration/utils/pagination.py, ContentNodePagination in contentcuration/contentcuration/viewsets/contentnode.py, and OptionalContentNodePagination in contentcuration/kolibri_public/views.py; compare how each handles cursor positions, ordering and page size. Reproduce the listed requests and add regression tests for each input, including the import metadata endpoint. Done means malformed cursors return DRF's invalid-cursor 404, ignored ordering cursors do not affect /api/contentnode, and public content-node pages respect a maximum size.

索引モデルが issue の本文から書いたものです。

説明

DEV: backend

Overview

Cursor pagination passes the cursor's position to the queryset filter without checking it fits the ordering field, and the public contentnode endpoint has no maximum page size. A crafted cursor, or a huge max_results, raises an exception and the request returns 500. Two of the affected endpoints are anonymous.

Complexity: Medium
Target branch: hotfixes

Context

All inputs below were reproduced:

  • ValuesViewsetCursorPagination relies on DRF's CursorPagination.decode_cursor, which validates the cursor's offset and direction but not its position (p). A base64 cursor of p=abc or p=notadate reaches the filter on:
    • /api/public/v2/contentnode/?max_results=2&cursor=cD1hYmM=: ValueError: Field 'lft' expected a number but got 'abc'. Anonymous.
    • /api/channelversion?version__gte=0&max_results=5&cursor=<p=abc>: ValueError on version. Anonymous.
    • /api/communitylibrary_submission?max_results=5&cursor=<p=notadate>: Django ValidationError on the datetime.
    • ImportMetadataPagination on /api/public/v2/importmetadata/<id>/ orders by lft the same way. Anonymous. Not reproduced separately.
  • ContentNodePagination reads the cursor field from the raw ordering param and only checks the value is an integer when that field is lft. On /api/contentnode?parent=<id>&max_results=2:
    • &ordering=foo&foo__gt=abc raises ValueError on lft, because DRF falls back to lft ordering.
    • &ordering=modified&modified__gt=abc raises Django ValidationError.
    • Related: #4854.
  • OptionalContentNodePagination sets no max_page_size. On /api/public/v2/contentnode/, ?max_results=999999999999999999999999999999 raises DataError: bigint out of range. Related: learningequality/kolibri#15826.
The Change
  • A cursor position that doesn't fit the ordering field should get the same response DRF gives for any malformed cursor.
  • ContentNodePagination should take its cursor field from the ordering the viewset applies, not the raw ordering param.
  • OptionalContentNodePagination should cap max_results.
Acceptance Criteria
General
  • Every cursor input in Context, and the same cursor on /api/public/v2/importmetadata/<id>/, returns DRF's invalid-cursor 404 instead of 500.
  • /api/contentnode ignores a cursor param for an ordering it doesn't apply, and returns a 4xx for a cursor value of the wrong type for the ordering it applies.
  • /api/public/v2/contentnode/ with a max_results above the cap returns at most the cap.
Testing
  • Each input in Context has a regression test.

AI usage

I scoped the audit and chose the validation strategy in #6387. Claude Code found and reproduced these failures and drafted this issue.

主要言語
Python
スター
212
フォーク
321
平均マージ
1日 7時間
マージ済み PR(30日)
14

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

learningequality/studio のほかの issue

learningequality/studio の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。