Every IconButton has the accessible name "text"

オープン
#6,378 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
2/5
見積もり時間
1〜3時間
初心者へのやさしさ
20/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
javascript

調査の方向性

Start with contentcuration/contentcuration/frontend/shared/views/IconButton.vue, specifically the ariaLabel prop usage cited in the issue. Then find the component's unit tests and check how they verify its tooltip text. Done means the accessible name matches the text prop, the test covers it, and the Generate, Upload, and Crop buttons are announced by their labels.

索引モデルが issue の本文から書いたものです。

説明

bug DEV: frontend

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Observed behavior

IconButton passes the literal string "text" to KIconButton (ariaLabel="text" with no : binding), so screen readers announce every icon button as "text":
https://github.com/learningequality/studio/blob/865e06b4fdef5bc8b0e7ec21782f6cbc5adbe88b/contentcuration/contentcuration/frontend/shared/views/IconButton.vue#L5-L7

The tooltip receives the translated label, so sighted users see the correct name on hover.

These 12 files use IconButton:

  • channelEdit/components/StudioTree/StudioTree.vue
  • channelEdit/components/ContentNodeEditListItem.vue
  • channelEdit/components/Clipboard/index.vue
  • channelEdit/pages/StagingTreePage/index.vue
  • channelEdit/views/TreeView/index.vue
  • channelEdit/views/CurrentTopicView.vue
  • channelEdit/views/ImportFromChannels/BrowsingCard.vue
  • channelEdit/views/files/EpubRenderer.vue
  • channelEdit/views/files/thumbnails/ContentNodeThumbnail.vue
  • shared/views/channel/ChannelThumbnail.vue
  • administration/pages/Channels/ChannelTable.vue
  • administration/pages/Users/UserTable.vue

User-facing consequences

Screen reader users cannot tell icon buttons apart in the channel editor. For example, the thumbnail field's Generate, Upload, and Crop buttons are all announced as "text".

Steps to reproduce

  1. Open the details of any resource in a channel's edit modal.
  2. Scroll to Thumbnail.
  3. Inspect the icon buttons below the thumbnail: each has aria-label="text".

Context

Studio unstable at 865e06b4f, Chromium.

Acceptance Criteria

  • Each IconButton has the same accessible name as its tooltip, i.e. its text prop.
  • The thumbnail field's Generate, Upload, and Crop buttons are announced by their labels.
  • A unit test covers the accessible name of IconButton.

AI usage

Claude Code found this during manual QA of #6358, checked IconButton.vue on unstable, and drafted this issue.

主要言語
Python
スター
211
フォーク
317
平均マージ
4日 10時間
マージ済み PR(30日)
25

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

learningequality/studio のほかの issue

learningequality/studio の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。