[Refactor/Chore] Defer MCP favicon parsing dependencies from the Integrations entry
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 45/100
- issue の種類
- リファクタリング
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- typescript
調査の方向性
Start with web/app/components/integrations/index.tsx and trace the listed section-renderer.tsx, MCP modal, and use-mcp-modal-form.ts chain to tldts. Run the Vinext browser build with Rolldown analysis, then compare production requests before and after opening MCP and entering a valid server URL. Done means the model-provider entry no longer eagerly includes the parser while MCP favicon loading, errors, stale results, and registrable-domain behavior remain correct.
索引モデルが issue の本文から書いたものです。
説明
Self Checks
- I have read the Contributing Guide and Language Policy.
- This is only for refactors or chores; if you would like to ask a question, please head to Discussions.
- I have searched for existing issues search for existing issues, including closed ones.
- I confirm that I am using English to submit this report, otherwise it will be closed.
- 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
- Please do not modify this template :) and fill in all the required fields.
Description
Defer the MCP favicon domain-parsing dependency instead of including it in the shared Integrations entry. The model-provider section currently shares a static dependency chain with MCP create/edit UI:
web/app/components/integrations/index.tsx
→ section-renderer.tsx
→ tool-provider-list.tsx
→ tools/mcp/index.tsx
→ tools/mcp/modal.tsx
→ tools/mcp/hooks/use-mcp-modal-form.ts
→ tldts
section-renderer.tsx switches between sections at runtime but statically imports their implementations. In use-mcp-modal-form.ts, getDomain is only used by the asynchronous URL blur handler for a newly created MCP server, to construct a favicon URL.
Rolldown DevTools confirms:
tldts7.4.13 contributes 302,095 bytes, directly imported by the MCP form hook.tldts-core7.4.13 contributes approximately 16 KB.- Both the Integrations entry and MCP modal/form modules appear in
integrations-BG8QSHyt.js. The final file is 549,378 bytes, approximately 179,461 bytes gzip.
These package contribution metrics and final chunk sizes have different scopes. The entire chunk is not removable, and these figures are not measured production transfer or guaranteed savings. This finding does not imply the datasets initial route downloads the Integrations chunk.
Reproduction:
- Build the Vinext browser target with Rolldown analysis enabled.
- Inspect
tldtsin Packages and follow its importer to the MCP form hook. - Inspect the Integrations chunk's module list and the source chain above.
- Verify production requests on
/integrations/model-providerbefore opening any MCP UI.
Motivation
Users visiting unrelated Integrations sections should not need the MCP favicon parser before using that functionality.
Possible focused fixes are to dynamically import tldts on the valid URL blur action or lazily load MCP dialogs while removing other eager paths to the form hook. A broader section split is another option if route measurements justify it.
Acceptance criteria:
- The model-provider Integrations entry no longer statically contains the MCP-only domain parser.
- MCP create/edit and favicon retrieval still work, including loading/error behavior and safe handling of stale asynchronous results.
- Preserve existing registrable-domain semantics:
URL.hostnameis not automatically equivalent for subdomains and public suffixes. - Compare before/after production requests and build output, including first opening MCP and entering a valid server URL.
Additional Context
Measured on a local Dify 1.17.1 development branch based on 06e473015a9a1abb71da88ac0a0e92d96a992008, with local DevTools integration patches, using Vinext 1.0.0-beta.10, Vite+ core 0.3.2, and Node 24.21.0. Browser analysis session: sid_4_1789651325793. Recheck against current main before implementing.
- 主要言語
- TypeScript
- スター
- 157k
- フォーク
- 24.7k
- 平均マージ
- 22時間 32分
- マージ済み PR(30日)
- 611
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
langgenius/dify のほかの issue
-
Annotation Reply: a stored score threshold of 0.0 is silently replaced with 1, disabling the feature オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
langgenius/dify#42639 · コメント 1 件 · リアクション 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
langgenius/dify#42468 · コメント 1 件 · リアクション 1 件 ·
-
🐞 bug
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
langgenius/dify#42446 · リアクション 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
langgenius/dify#42355 · コメント 1 件 · リアクション 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
langgenius/dify#42350 · コメント 1 件 · リアクション 1 件 ·
langgenius/dify の issue をすべて見る
似ている issue
-
calcite-components needs triage refactor
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
Esri/calcite-design-system#15203 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
難易度 1/5 1時間未満 初心者へのやさしさ 95/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
Automattic/studio#4908 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 90/100