Event bus: build high-rate topics only for clients that subscribed to them

オープン
#845 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 6 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
42/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
rust

調査の方向性

Start with crates/blockchain/src/events.rs and crates/net/rpc/src/events.rs, then trace the producer gates and sink trait in ethlambda-network-api; the issue describes two possible designs. Run or add a test where a client subscribes only to head. Done when that subscription does not build single_attestation, and the relevant high-rate topics are handled by the chosen design.

索引モデルが issue の本文から書いたものです。

説明

Problem. EventBus::has_subscribers is receiver_count() > 0 (crates/blockchain/src/events.rs:644). Every producer gates on it, so a single SSE client turns on every topic's payload construction, whatever ?topics= it asked for: a validator client that only wants head, for example. The filtering happens afterwards, in the stream (crates/net/rpc/src/events.rs, !topics.contains(&ev.topic())).

For the two high-rate beacon topics that means:

  • single_attestation (lambdaclass/ethlambda#757) clones every subnet attestation the node accepts: every vote on its backbone subnets, plus the duty subnets it joins.
  • attestation clones every accepted aggregate.

Both go into the one ring all topics share (CHAIN_EVENT_CHANNEL_CAPACITY, 8192, events.rs:600). A client whose connection stalls lags after capacity / total rate, and loses the low-rate events it did ask for, which it learns only from the dropped N messages comment frame. The doc on CHAIN_EVENT_CHANNEL_CAPACITY already names this and calls a per-topic split "the escape hatch". The rates on a mainnet node are not measured; lean_-prefixed counters per topic emitted would measure them.

Why not in lambdaclass/ethlambda#757. 757 adds one producer and follows the bus's existing gate, as attestation already does. Per-topic interest changes the bus, the SSE handler and every producer's gate.

Fix. Either of two:

  • Count subscriptions per Topic. The SSE handler registers its topic set with a guard that decrements on drop, and EventBus::wants(Topic) replaces has_subscribers at each producer; the sink trait in ethlambda-network-api grows the same method.
  • Keep has_subscribers, but give single_attestation and attestation a ring of their own, so their rate cannot push low-rate events out of a slow client's window.

A test: a client subscribed to head alone causes no single_attestation to be built.

Also high-rate (from lambdaclass/ethlambda#748): the gloas payload_attestation_message and execution_payload_bid events are built per message too, so the same per-topic interest check should cover them.

主要言語
Rust
スター
86
フォーク
34
平均マージ
9日 20時間
マージ済み PR(30日)
77

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

lambdaclass/ethlambda のほかの issue

lambdaclass/ethlambda の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。