Field-test backlog: open findings from three throwaway-host runs
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 25/100
- issue の種類
- バグ
- 明瞭さ
- 説明が足りない
- 活発さ
- 活発
- 技術スタック
- docker, go
- 領域
- cli, devops, infrastructure
調査の方向性
これは単一の変更ではなく、包括的なバックログです。まず network-ownership に関する調査結果について、internal/engine/services.go:52 と参照されている Spec.All() の挙動を読み、その後 deployment の証拠と関連する e2e の失敗を調査してください。選択した1件の調査結果について、焦点を絞った判断、実装、回帰テストのカバレッジが揃えば、コントリビューションは完了です。#84 と、受け入れ済みの #33/#34 の作業はすでに考慮されています。
索引モデルが issue の本文から書いたものです。
説明
Open items from deploying to three throwaway Hetzner hosts (gitea, a purpose-built feature project, and ghost on managed MySQL). Everything below was reproduced against a live server, not inferred from source. The fixed findings shipped in #30, #32, #33 and #34; these are what is left.
Ordered by what I would do first.
1. Network ownership — an app can silently join a stranger's network
Proven on a host. Create a network under a name a project will use, then run preflight:
$ docker network create foo_default # labels: {}
$ ob preflight
ok name collisions 3 derived names, none held by anything else
$ docker compose -p foo up -d # what ob does
stranger's network id: 3630dcad6cfb…
container joined id : 3630dcad6cfb… # joined it
Two causes: Spec.All() does not enumerate <app>_default, so preflight never asks about it; and the network carries no ob.app label, so ownedNames could not attribute it even if asked. Volumes and containers are labelled — this is the one resource class that is not.
Wider than one network. internal/engine/services.go:52 creates the service network with a bare docker network create and no label either. No network onebox makes carries ownership.
The naive fix is destructive — I tried it in #34 and reverted. Declaring networks.default in the generated runtime makes Compose manage it, and the e2e caught it immediately:
Network obe2e_default Removed
Error response from daemon: error while removing network: network
obe2e_default has active endpoints (name:"obe2e-traefik-1")
On a live host that removes the application's network mid-deploy.
What a coherent fix looks like: mark the app network external in the generated runtime, create it out of band the way the service network already is, label every network onebox creates with ob.app, and add it to Spec.All(). Needs care for hosts whose networks already exist unlabelled — treating an unlabelled network at a derived name as foreign would break every existing deployment at preflight.
2. Bootstrap installer safety boundary
Tracked in #84. Reverified against current main: the implicit get.docker.com installer runs after the host-owner claim but before the application lock, fence, journal, authored bootstrap hook, and evidence manifest. The dedicated issue owns the decision and acceptance criteria; this umbrella no longer duplicates them.
3. Every deploy recreates every workload, databases included
Changing one environment variable on an application workload recreated the database container too:
deploy 1: waiting 735d15bb4bb1 → healthy
deploy 2: waiting 55a3b5f110cb → healthy # different container
The plan diff showed the only change to db was its ob.release label. Because that label is stamped on every service, no container's config hash is ever unchanged between releases, so Compose recreates all of them. For a database that is a dropped-connection event on every unrelated deploy.
engine.OnlyReleaseLabelsChanged already exists and is used to decide whether a whole deploy is a no-op — the same idea per workload would fix this. Alternatively omit ob.release from workloads whose rendered definition is otherwise identical; the release is already recorded in the journal and the current symlink.
4. ob canonical no longer shows inferred durability
Accepted knowingly in #33 rather than papered over. The contract publishes persistence.mode defaulting to durable; a workload with a managed named volume is now treated as durable by ob doctor and the migration-backup requirement, but the document is not edited, so ob canonical does not show the inference.
Materialising it into the document was tried and reverted: the "this was inferred" exemption is in-memory state, and deepCopy round-trips through JSON, so Resolve refused projects that had loaded — blaming a replicas override nobody wrote. Making it visible and consistent needs either accepting a tightened constraint or teaching canonical to annotate a value that is not in the document.
5. The hook environment is a public contract documented nowhere
A local hook receives OB_APP, OB_SERVER, OB_HOST, OB_SSH_USER, OB_SSH_PORT, OB_RELEASE_DIR, OB_RELEASE_ID (internal/engine/recreate.go:127-134). People write scripts against these. No page in site/src/content/docs lists them.
6. The example corpus barely exercises the contract
Across all eleven apps in e2e/apps:
| Feature | Apps using it |
|---|---|
role: job, data_effect, schedule |
0 / 11 |
verifications, notifications, hooks |
0 / 11 |
env_files (secrets), registries |
0 / 11 |
protection, backup_targets, external_services |
0 / 11 |
replicas, strategy |
0 / 11 |
So a rolling deploy was never exercised on a host until ghost, and migrations, schedules and the backup gate needed a project written by hand. Three hosts produced three different classes of finding precisely because each reached contract the previous could not; a fourth app declaring the same fields as gitea would find nothing.
Worth adding one or two corpus projects that use the contract, rather than more apps that use the same tenth of it.
Smaller
LICENSEis absent. The blocker for going public, and the reason theonebox.run/v1renames were time-sensitive.app.SchemaIDpoints atraw.githubusercontent.comrather thanhttps://onebox.run/onebox.run-v1.schema.json.- The facts manifest has no published JSON Schema.
ob backup-evidence template(#33) closes the authoring gap, and the manifest is strictly decoded, but a schema file would let editors and CI validate it. Blocked on reusing the schema generator across packages. ob execfree-text flag guard is partial.TestEveryFlagNamedInAnErrorStringExistsOnThatCommandmatches the backticked`ob cmd --flag`form only; prose like "re-run with --allow-destructive-mounts" is correct but unguarded.- 19 instances of "that is the point" / "the whole point" across code and docs — a stylistic tic, deliberately left alone.
- 主要言語
- Go
- スター
- 3
- フォーク
- 0
- 平均マージ
- 2時間 44分
- マージ済み PR(30日)
- 49
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
labstack/onebox のほかの issue
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 80/100
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 85/100
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 85/100
-
bug
難易度 3/5 1〜2日 初心者へのやさしさ 65/100
-
難易度 4/5 3〜5日 初心者へのやさしさ 55/100
labstack/onebox の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
bazel-contrib/rules_go#4726 · コメント 1 件 ·
-
area/auto-scaling area/monitoring area/ops-productivity kind/enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
-
Type/Improvement
難易度 1/5 1〜3時間 初心者へのやさしさ 90/100
OpenNSW/nsw-srilanka#522 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 92/100