jamesplease/react-request

Redundant `render` run with outdated state

Open

#196 opened on 2018年9月24日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)JavaScript (21 forks)github user discovery
help wantedrefactor

Repository metrics

Stars
 (358 stars)
PR merge metrics
 (PR metrics pending)

説明

If I render the same Fetch with new url, first I get it's children rendered with previous state (old url, old data, etc.) It looks like the problem is known: https://github.com/jamesplease/react-request/blob/eca89d5fe79bd546a0641b6443415b722e3f6ec3/src/fetch.js#L107 It feels that it would be simple to fix it by updating Fetch state in componentWillReceiveProps hook. @jamesplease what's your opinion?

コントリビューターガイド