jamesplease/react-request

change `fetching` to be set to `true` on mount for non-lazy requests

オープン

#178 opened on 2018/05/25

 (3 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (21 件のフォーク)github user discovery
breakingenhancementhelp wanted

Repository metrics

Stars
 (358 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

I was wondering if you'd consider a slight change for non-lazy behavior. Right now it seems like you need to do:

<Fetch url="/me">
  {({ fetching, failed, data }) => {
    if (fetching) return ...
    if (failed) return ...
    if (!data) return null
    return ...
  }}
</Fetch>

There's an extra case where the component has just mounted, but hasn't yet started the request where fetching == false but data == null. Apollo seems to avoid this, such that you can handle the fetching and failed cases up front, and then assume you have data after that, which just reduces a little of the boilerplate.

Would you be down for that change?

コントリビューターガイド