[@capacitor/splash-screen] Android 8–11: failed Android 12 API attempt leaves a pre-draw hold, so nothing is drawn for launchShowDuration
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 初心者へのやさしさ
- 88/100
調査の方向性
showOnLaunch() が showWithAndroid12API() を呼び出し、レガシーの show() パスにフォールバックする Android スプラッシュ画面プラグインのコードを探します。Issue には、SDK バージョンに応じて Android 12 API の呼び出しをガードするパッチが示されています。この変更を既存の動作と比較し、Android 8~11 ではレガシーのスプラッシュ画面が使われ、Android 12 以降では現在のパスが維持されることを確認します。
索引モデルが issue の本文から書いたものです。
説明
🤖 Automated review by Claude — posted via @ibrahimkhatib365's account; not written by them personally.
Bug Report
Plugin(s)
@capacitor/splash-screen 8.0.2. The same code is in every version from 4.x through 8.0.3 nightly, 9.0.0-alpha.2 and the current 9.0 dev builds.
Capacitor Version
Latest Dependencies:
@capacitor/cli: 8.6.0
@capacitor/core: 8.6.0
@capacitor/android: 8.6.0
@capacitor/ios: 8.6.0
Installed Dependencies:
@capacitor/cli: 8.5.2
@capacitor/core: 8.5.2
@capacitor/android: 8.5.2
@capacitor/ios: 8.5.2
[success] Android looking great! 👌
Platform(s)
Android 8–11 (API 26–30). Android 12+ is not affected.
Current Behavior
On Android 8–11, showOnLaunch() calls showWithAndroid12API() first. On those versions the attempt does the following:
installSplashScreen()succeeds. The compat library supports API 23+.setKeepOnScreenCondition(() -> isVisible || isHiding)succeeds. Below API 31, the compatSplashScreen.Impladds anOnPreDrawListenertoandroid.R.id.contentright away.- With the default
launchFadeOutDuration(200),setOnExitAnimationListener()then throws, because building the compatSplashScreenViewProviderneedsTheme.SplashScreenattributes that a normal launch theme doesn't have.
The catch logs Android 12 Splash API failed... using previous method. and falls back to show(..., true). However, the compat pre-draw listener from step 2 is still registered, and the legacy path then sets isVisible = true. As a result, the activity's content is held back from drawing for the entire launchShowDuration. The legacy splash window shares the activity's window token, so it doesn't appear while the activity hasn't drawn either.
The visible result depends on timing:
- On a cold launch, the first draw usually happens before
isVisibleflips, so the splash shows normally. - When the activity is recreated in an existing process (for example, after closing it with Back and reopening it from the launcher), the hold wins. Nothing of the app is drawn for
launchShowDuration, and then the app appears at once.
On an Android 9 emulator with launchShowDuration: 3000, the reopen after Back logs Displayed .MainActivity: +3s426ms, and the next line in the log is SplashScreen was automatically hidden after the launch timeout. With a translucent launch theme, the launcher stays on screen for the whole 3.4 s. With an opaque launch theme, the window background shows instead of the plugin's splash.
The 9.x change to the default launchFadeOutDuration (0, #2526) makes this worse below Android 12. Step 3 no longer throws, so the plugin never reaches the legacy path. It only holds the first frame for launchShowDuration behind the theme's window. With launchFadeOutDuration: 0 on 8.0.2, Android 9 showed no splash at all on either a cold launch (+4.4 s) or a reopen (+3.2 s), only the launcher until the app appeared.
Expected Behavior
On Android 8–11, the legacy splash shows right away and the activity isn't held. That is what happens on a cold launch today.
Code Reproduction
No sample repository yet. The steps on a new app:
npm init @capacitor/app, add@capacitor/splash-screen, and setSplashScreen.launchShowDurationto3000incapacitor.config. Keep the other defaults.- Optional, to make the symptom obvious: add
<item name="android:windowIsTranslucent">true</item>toAppTheme.NoActionBarLaunch. - Run on an API 26–30 emulator, for example Android 9.
- Launch the app and wait for it to finish loading, press Back, then tap the launcher icon again.
- The app (and the splash) are not drawn for about 3 s.
adb logcatshowsAndroid 12 Splash API failed...and anActivityManager: Displayedtime of aboutlaunchShowDuration.
Other Technical Details
androidx.core:core-splashscreen1.2.0 (the plugin default)- Reproduced on an Android 9 (API 28) emulator
minSdkVersion26
Additional Context
A guard that only uses the Android 12 API where it applies fixes this, and we now ship it as a patch:
try {
- showWithAndroid12API(activity, settings);
- return;
+ if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
+ showWithAndroid12API(activity, settings);
+ return;
+ }
} catch (Exception e) {
With this guard on Android 9, the reopen after Back shows the legacy splash immediately (Displayed +182ms). The cold launch is unchanged, and Android 12+ runs the same code as before.
Another approach is to remove the pre-draw listener in the catch. However, the compat library doesn't expose it, so skipping the attempt below API 31 seems simpler. This is related to, but separate from, #2627 and #2548, which are about how hide() removes the plugin's own pre-draw listener.
- 主要言語
- Java
- スター
- 688
- フォーク
- 691
- 平均マージ
- 1日 5時間
- マージ済み PR(30日)
- 5
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
ionic-team/capacitor-plugins のほかの issue
-
triage
難易度 2/5 1〜3時間 初心者へのやさしさ 80/100
ionic-team/capacitor-plugins#2627 ·
メンテナーはふだん 1 日以内に返信
-
triage
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
ionic-team/capacitor-plugins#2616 ·
メンテナーはふだん 1 日以内に返信
-
[@capacitor/app] iOS: 'Expression implicitly coerced from String? to Any' warning in getAppLanguageオープンtriage
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
ionic-team/capacitor-plugins#2604 ·
メンテナーはふだん 1 日以内に返信
-
platform: android
難易度 3/5 1〜2日 初心者へのやさしさ 74/100
ionic-team/capacitor-plugins#2636 ·
メンテナーはふだん 1 日以内に返信
-
triage
難易度 3/5 1〜2日 初心者へのやさしさ 72/100
ionic-team/capacitor-plugins#2634 ·
メンテナーはふだん 1 日以内に返信
ionic-team/capacitor-plugins の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100
wultra/powerauth-tests#980 ·
-
account bug communication lecture
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
line/centraldogma#1397 ·
メンテナーはふだん 2 日以内に返信
-
[Bug]: Fixed/recurring deposit accounts are treated as savings in ownership and listings対応中かも @Aana123 が今日担当しました。 オープンbug Triage
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
apache/fineract-consumer-facing#252 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 76/100
ShaftHQ/SHAFT_ENGINE#7946 ·
メンテナーはふだん 1 日以内に返信