[RET-A5][P1] Delete the unreachable LOCAL runtime and evidence code, with strict state protocol N + 1

クローズ
  • 何か問題がありますか？
#388 コメント 3 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

関連するプルリクエストがすでにマージされています。

  • #421 @iceboundrock による — マージ済み

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
25/100
issue の種類
リファクタリング
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
python
領域
backend, devtools

調査の方向性

Start by reviewing parent issue #383 and the RET-A2, RET-A3, and RET-A4 work, then trace LOCAL workflow branches, state handling, and candidate acceptance across the engine, doctor, status, and tests. Recheck the current main branch against the stated planning baseline before implementation. Done means no reachable LOCAL path remains, REMOTE behavior and shared safeguards are preserved, and tests cover legacy, unknown, and corrupt state refusals without automatic remediation.

索引モデルが issue の本文から書いたものです。

説明

enhancement

Parent EPIC: #383 (https://github.com/iceboundrock/AutoForge/issues/383). Planning baseline: main 01c5b7e (2026-10-28); ADR 0009 is pinned to 02ce244. Recheck current main before implementation.

Amended 2026-10-30 for the breaking removal (maintainer decision on #384). No legacy discriminator, minimal LOCAL recognition or LOCAL migration is kept. This issue deletes everything #387 has made unreachable and carries the state protocol's strict N + 1 migration (ADR 0009 D1, D6, D8, D11, D12 step S3).

Safety: Preserve:

  • Controller authority, strict state/protocol parsing and independent read-back;
  • immutable PR HEAD/base binding and reconciliation;
  • explicit operator approval;
  • the fail-closed sandbox and credential boundary.

No real GitHub mutations or models in automated tests.

Workstream: RET-A5. Dependencies: RET-A2 (#385), RET-A3 (#386), RET-A4 (#387). The protocol number is confirmed on #23 before merge.

Scope

  • Delete every DELETE row of ADR 0009 Appendix A, with its tests:

    • the LOCAL topology and decision branches, and WorkflowMode.LOCAL;
    • _local_step_once and the LOCAL lifecycle;
    • the run contract, and the workspace walk, fingerprint and feature specification;
    • the LOCAL candidate, evidence and certificate pathways;
    • the LOCAL launch classes and launch accounting;
    • doctor's LOCAL subset;
    • LocalConfig;
    • the LOCAL result models and prompt templates.

    Delete a LOCAL test only when its shared invariant has #386's replacement on main (A.2.4).

  • Keep the shared facilities: git worktrees, the executor, the sandbox, validation, materialization, providers, durable state and safefs.py. No global rename of REMOTE, and no speculative abstraction.

  • Bump the state protocol to N + 1 (ADR 0009 D8).

    • Take N from main when the PR is ready to merge.
    • Before merging, announce on #23: this issue, the PR, N → N + 1, the twelve fields removed and the rule. If main moves past N, rebase and correct the announcement. After the merge, record the squash commit there.
    • The rule:
      • the mode check comes first;
      • every per-protocol rule then runs unchanged;
      • then each of the twelve LOCAL fields is dropped only when it is absent or empty, and refused when non-empty;
      • under N + 1, or with no label, any LOCAL field is refused.
    • There is no LOCAL migration path, and a refused file stays byte-identical.

  • The evidence parsers refuse workspace-variant records and local certificates in REMOTE state.

  • Documents and contracts.

    • Update the agent guides, the instruction maps (AGENTS.md, src/autoforge/AGENTS.md, tests/AGENTS.md, docs/README.md) and the test contracts (ADR 0009 A.2.5, A.3).
    • Add the protocol bump and the status --json change to CHANGELOG.md.
    • Since this PR completes the removal on main: add ADR 0001's superseded note and the LOCAL notes on ADR 0003 to 0008 (ADR 0009 D11, A.4).

Acceptance

  • ADR 0009's S3 exit tests pass:
    • positive loads, under every label that loads today;
    • every #385 refusal kept, with only the expected label moved;
    • the new refusals: one case per LOCAL field; an N + 1 or unlabelled file with any LOCAL field; mode: "LOCAL" under every label, N + 1 included; the LOCAL evidence kinds;
    • the structural tests;
    • no LOCAL template in the wheel.
  • No LOCAL workflow path or LOCAL candidate acceptance is reachable, or present. No legacy detector, inspector or error type.
  • Existing REMOTE behaviour is kept: state, effects, review, fix, replan, unblock, the merge gate, the EPIC scheduler and candidate certificates. No REMOTE state refused before the bump loads after it.
  • The protocol number is confirmed on #23 before merge.

Blocked by: RET-A2 (#385), RET-A3 (#386), RET-A4 (#387); confirmation on #23. Blocks: RET-A6 (#389).

主要言語
Python
スター
0
フォーク
0
平均マージ
5時間 19分
マージ済み PR（30日）
106

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

iceboundrock/AutoForge のほかの issue

iceboundrock/AutoForge の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。