Add a strict clippy config
メンテナーはふだん 2 日以内に返信
@seanmonstar がすでに取り組んでいます。
2026年5月19日 から。
評価
この issue はまだ評価されていません。
説明
hyper for a long time never bothered with clippy. Mostly for historical reasons and opinions.
I've now come around to just turning clippy up to 11. What I'm currently leaning towards is keeping an allowlist, and otherwise denying pedantic and even restriction lints. Yes, I know there's a restriction lint against linting for the restriction group. An allowlist still makes a lot of sense to me. If after a bit it turns out to be just unbearable, we can convert it to a bigger deny list, I guess.
The initial config is in place, with a CI job that enforce it, so we won't regress with new code. Now, we just need to evaluate all the undecided lints, and either choose to allow them for sure, or fix them.
How to help
Look at the list of lints that need to be decided upon in the Cargo.toml (it's around there, the line might move slightly).
- Pick a lint.
- If it seems obviously an improvement:
- Fix up the code from the lint.
- It might be as simple as
cargo clippy --fix --features full. - It might be obvious enough for an LLM to automate fixing. (But only if you understand what changes it made.)
- It might need manual adjustment in each case.
- It might need to be
#[allow(this_lint)]in specific cases, where the lint is usually useful.
- It might be as simple as
- Remove the allowed lint from the
Cargo.toml - Submit a PR for one lint at a time.
- Fix up the code from the lint.
- If it is not obviously an improvement:
- Move the lint down lower to the explicitly allowed list in the
Cargo.toml - Add a comment why the lint is being allowed
- Submit a PR (multiple lints solved this way is fine in a single PR)
- Move the lint down lower to the explicitly allowed list in the
Steps
- #4075
- address each one in in the todo list
- arithmetic_side_effects = "allow" # TODO: consider
- as_conversions = "allow" # TODO: tricky
- borrow_as_ptr = "allow"
- cast_lossless = "allow" # TODO: easy fix
- cast_possible_truncation = "allow" # TODO: consider
- cast_precision_loss = "allow" # TODO: consider
- checked_conversions = "allow"
- collapsible_match = "allow"
- decimal_literal_representation = "allow" # TODO: consider
- default_trait_access = "allow"
- else_if_without_else = "allow"
- empty_structs_with_brackets = "allow" # TODO: easy fix
- enum_glob_use = "allow"
- explicit_iter_loop = "allow" # TODO: easy fix
- float_arithmetic = "allow"
- ignored_unit_patterns = "allow"
- indexing_slicing = "allow"
- integer_division = "allow"
- integer_division_remainder_used = "allow"
- large_enum_variant = "allow"
- let_unit_value = "allow"
- manual_assert = "allow" # TODO: easy fix
- manual_assert_eq = "allow" # TODO: easy fix
- map_err_ignore = "allow"
- map_unwrap_or = "allow"
- match_wild_err_arm = "allow"
- missing_fields_in_debug = "allow" # TODO: use finish_non_exhaustive
- missing_errors_doc = "allow" # TODO: good to fix
- missing_panics_doc = "allow" # TODO: might be false
- multiple_inherent_impl = "allow"
- multiple_unsafe_ops_per_block = "allow"
- needless_continue = "allow"
- needless_pass_by_value = "allow"
- panic = "allow"
- pattern_type_mismatch = "allow"
- ptr_as_ptr = "allow"
- question_mark = "allow" # TODO: probably easy fix
- redundant_closure_for_method_calls = "allow"
- redundant_else = "allow"
- ref_option = "allow"
- ref_patterns = "allow" # TODO: perhaps deny?
- semicolon_if_nothing_returned = "allow" # TODO: easy fix
- single_char_lifetime_names = "allow"
- single_match_else = "allow" # TODO: easy fix
- struct_excessive_bools = "allow" # TODO: bogus lint?
- trivially_copy_pass_by_ref = "allow"
- undocumented_unsafe_blocks = "allow" # TODO: fix me
- uninlined_format_args = "allow" # TODO: easy fix
- unnecessary_semicolon = "allow" # TODO: easy fix
- unnecessary_trailing_comma = "allow"
- unnested_or_patterns = "allow"
- unused_async = "allow" # TODO: is it for API?
- unused_trait_names = "allow" # TODO: kinda annoying, but might be good to deny
- unwrap_in_result = "allow"
- useless_borrows_in_formatting = "allow"
- wildcard_enum_match_arm = "allow"
- wildcard_imports = "allow" # TODO: never, except for tests
- 主要言語
- Rust
- スター
- 16.4k
- フォーク
- 1.8k
- 平均マージ
- 5日 17分
- マージ済み PR（30日）
- 19
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
hyperium/hyper のほかの issue
-
C-feature
難易度 1/5 1時間未満 初心者へのやさしさ 65/100
hyperium/hyper#2652 · リアクション 4 件 ·
メンテナーはふだん 2 日以内に返信
-
Write a HIP for `Body::poll_progress()`対応中かも @cratelyn が 4 日前に担当しました。 オープンA-body B-rfc C-feature
hyperium/hyper#4228 · 担当者 1 名 ·
メンテナーはふだん 2 日以内に返信
-
難易度 3/5 1〜2日 初心者へのやさしさ 74/100
hyperium/hyper#4211 · コメント 1 件 ·
メンテナーはふだん 2 日以内に返信
-
Upgraded HTTP/2 CONNECT streams cannot be reset, so a failed tunnel looks like a clean close対応中かも @jeremyjpj0916 が 14 日前に担当しました。 オープン
難易度 4/5 3〜5日 初心者へのやさしさ 55/100
メンテナーはふだん 2 日以内に返信
-
Allow connection pools to stop reusing an HTTP/2 connection before its keep-alive timeout対応中かも @jiahaoliang が 32 日前に担当しました。 オープンC-feature
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
hyperium/hyper#4186 · コメント 2 件 ·
メンテナーはふだん 2 日以内に返信
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
swc-project/swc#12516 ·
メンテナーはふだん 1 日以内に返信
-
app bug
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
-
mls-rs-crypto-awslc: exact aws-lc-rs =1.16.3 pin blocks rustls security update対応中かも @muscariello が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
-
[work-item] adam-adae-worsening-emergence: conform spec.yaml to the specification style contract (REQ-1280)対応中かも @muse-yamaa-bot が今日担当しました。 オープンwork-item
難易度 1/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信