unmerge deletes a relation an independent insert reasserted on the survivor (data loss)

オープン
#385 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
52/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
typescript
領域
backend, databases

調査の方向性

Read src/selfgraph/resolution.py around unmerge (lines 1180–1305) and trace how rewritten relations, their versions, and evidence are restored before runner.delete_edges runs. Reproduce with the Kuzu example in the issue, then check existing unmerge tests for coverage. Done means unmerging removes only the merge’s contribution and preserves the independent survivor relation, matching the no-merge replay.

索引モデルが issue の本文から書いたものです。

説明

area: write bug effort: M P1

Summary

unmerge deletes a relation that an independent insert created on the survivor after the merge, causing silent data loss. The docs state that unmerging every merge of an insert leaves exactly what the inserts would have written without the merge, but here a relation written after the merge is removed entirely.

Reproduction (0.2.2, Kuzu backend)

g = SelfGraph(store=KuzuStore(path), namespace="e", resolver="exact")
await g.initialize()
await g.insert.facts({"entities": [{"type": "Person", "name": "Bob Ray"}, {"type": "Company", "name": "Zed Inc"}]}, source_id="seed")
r = await g.insert.facts(
    {"entities": [{"type": "Person", "name": "Bob Raye"}],
     "relations": [{"from_entity": "person:bob-raye", "type": "WORKS_AT", "to_entity": "company:zed"}]},
    resolver="fuzzy", source_id="s2")
# "Bob Raye" resolves and merges into person:bob-ray; the relation is rewritten onto person:bob-ray.
await g.insert.facts(
    {"relations": [{"from_entity": "person:bob-ray", "type": "WORKS_AT", "to_entity": "company:zed"}]}, source_id="s3")
# An independent, explicit bob-ray -> zed from a different source.
await g.entities.unmerge(r.merges[0].id)

# Observed: only person:bob-raye -> company:zed remains (carrying 2 sources). person:bob-ray -> company:zed is gone.
# Expected (what the same inserts produce with resolver="exact", no merge): both relations present,
#   person:bob-ray -> zed and person:bob-raye -> zed.

Cause

In src/selfgraph/resolution.py, unmerge (around lines 1180 to 1305) restores each rewritten relation by reading the survivor-side relation's current versions and evidence, then runner.delete_edges(ns, rw.id) removes every version of it and writes the relation back onto the absorbed endpoint. It cannot distinguish the merge's own contribution from an independent assertion made on the survivor after the merge, so the later write is deleted with it.

Expected

Unmerge removes only the merge's contribution and leaves relations written independently after the merge in place, so unmerge-all equals the no-merge replay.

主要言語
TypeScript
スター
173
フォーク
58
平均マージ
6時間
マージ済み PR(30日)
120

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

hydra-db/selfgraph のほかの issue

hydra-db/selfgraph の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。