beta testing github-app
@patzielinski がすでに取り組んでいます。
2025年5月16日 から。
評価
この issue はまだ評価されていません。
説明
Here are some observations from testing the github-app on a test repo following the getting started guide.
- For some reason the installation docs made me think that there would be any gittuf specific configuration steps during the install, Maybe because of sentence "The UI will walk you through the standard installation process. As a part of this..." . So I was surprised, that the installation was finished after I chose an account to install, and briefly thought the installation had failed.
- Removing the quoted phrase might make the instruction clearer.
- After the installation I was redirected to the top of the getting started document I was coming from, and already two thirds through reading.
- The redirect should lead somewhere, where I should go next after the installation.
- I then created a PR and noticed the gittuf-app check "PR is not mergeable" (and in the details: "More approvals are necessary for the PR to be mergeable.")
- Where does this policy come from?
- Is it hardcoded into the app?
- I couldn't find docs, or settings for this.
- Does the app install a gittuf policy into the git metadata?
- How many approvals are actually needed?
- Also gittuf and GitHub give me mixed signals about the mergeability of my PR.
- gittuf: Verify gittuf policy / PR is not mergable
- GitHub: Merging can be performed automatically / Merge pull request
- Despite gittuf saying otherwise, merging seems to work
- How can I see the merge attestation now?
- When I fetch locally after merge, I do find an RSL Reference Entry (requires git/gittuf specific knowledge)
git fetch origin "refs/gittuf/*:refs/gittuf/*" && git cat-file -p $(cat .git/refs/gittuf/reference-state-log) - Are there no attestations because I didn't approve the PR?
- Second round: PR with approval
- One approval does not seem to be enough. gittuf still says "More approvals are necessary for the PR to be mergeable."
- GitHub says otherwise
- Merging and fetching locally, I still don't see any attestations. But refs/gittuf/reference-state-log points to the second RSL Reference Entry now.
- Maybe much of this can be solved with better documentation / user feedback. :)
- 主要言語
- Go
- スター
- 5
- フォーク
- 1
- 平均マージ
- 8時間 40分
- マージ済み PR（30日）
- 6
環境構築
- Dockerfile または Docker Compose ファイルあり
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
gittuf/github-app のほかの issue
-
難易度 4/5 3〜5日 初心者へのやさしさ 45/100
gittuf/github-app#152 · コメント 3 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
gittuf/github-app#108 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 30/100
gittuf/github-app#54 · コメント 1 件 ·
-
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
gittuf/github-app#24 · コメント 1 件 ·
gittuf/github-app の issue をすべて見る
似ている issue
-
area/gateway kind/bug
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
vllm-project/aibrix#3226 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 1 日以内に返信
-
gencrl: serial numbers that fail to parse are added to the CRL as 0 or a partial value対応中かも @sebxt が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
cloudflare/cfssl#1460 ·
メンテナーはふだん 2 日以内に返信
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 75/100
ironcore-dev/cloud-hypervisor-provider#210 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
OpenTollGate/tollgate-module-basic-go#1027 ·
メンテナーはふだん 1 日以内に返信