Support declaring a token's granted permissions/scopes up front for tool pre-filtering (stdio config + HTTP header)
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 静か
- 技術スタック
- go
- 領域
- api, authorization, cli
調査の方向性
#2676 の CreateToolPermissionFilter と既存の pkg/scopes のフィルタリングから始め、次に stdio OAuth パスと HTTP リクエスト処理を追跡します。完了条件は、文書化された grant 宣言が stdio とリクエスト単位の HTTP モードの両方で両方のフィルターに入力でき、宣言がない場合は fail-open の動作が維持され、実行時の認可が変更されないことです。
索引モデルが issue の本文から書いたものです。
説明
Problem
We filter tools by what a token can do in only a few narrow cases today:
- Classic PATs (
ghp_) — we read theX-OAuth-Scopesresponse header and hide tools requiring scopes the token lacks. - OAuth login (stdio) — we filter by the requested OAuth scopes (default set hides nothing; a narrower
--oauth-scopesfilters).
For everything else we fail open and show every tool:
- Fine-grained PATs and GitHub App installation tokens do not advertise their granted permissions in a way we can read up front.
- The FGP requirement subsystem from #2676 ships dormant in OSS precisely because there is no grant source —
CreateToolPermissionFilter(granted)fails open on a nilgranted.
The result: a token that physically cannot perform an action still surfaces the tool, so the model discovers the limitation only by calling it and getting a 403. We already know the catalog of what each tool needs (#2676/#2679); what's missing is a way to tell the server what the token actually has.
Proposal
Let the operator declare the token's granted permissions/scopes up front, independent of OAuth, so we can pre-filter tools against the FGP catalog (#2676) and the classic scope catalog (pkg/scopes):
- stdio: a config flag / env var, e.g.
--granted-permissions/GITHUB_GRANTED_PERMISSIONS(fine-grained) and/or--granted-scopes/GITHUB_GRANTED_SCOPES(classic). Applies regardless of whether the token came from a PAT, a GitHub App installation token, or OAuth. - HTTP mode: a request header (e.g.
X-MCP-Granted-Permissions) carrying the same declaration per request, so a remote host that already knows the caller's grant can drive filtering without us re-deriving it.
When a grant declaration is present, feed it as the granted source to CreateToolPermissionFilter (FGP) and to the existing scope filter, so tools the token cannot use are hidden. When absent, keep today's fail-open behavior.
Caveats (call out in the design)
This is deliberately flagged as a sharp-edged feature:
- Manual and messy interface. Enumerating fine-grained permissions + levels (read/write/admin) by hand is verbose and error-prone. The format needs thought — a flat
perm:levellist is ugly; anything richer is heavy for a CLI flag / header. - No validation against the real token. A declared grant can drift from what the token actually has. Over-declaring hides nothing it shouldn't but re-introduces the 403-on-call surprise; under-declaring hides usable tools. We are trusting the operator's declaration.
- Two vocabularies. Classic scopes vs fine-grained permissions are different models; we'd need to be explicit about which a given token uses (and possibly support both).
- It is a pre-filter for ergonomics/safety, not an authorization boundary — GitHub still enforces the real permissions server-side.
Context / related
- #2676 — declarative FGP requirement subsystem (catalog +
CreateToolPermissionFilter, ships dormant; this issue is the grant-source piece that's out of scope there). - #2679 — expand per-tool FGP annotations.
- Existing classic-scope filtering for
ghp_PATs and OAuth requested scopes (stdio). - OAuth stdio stack (in progress) — OAuth can only filter by requested scopes, and even then we don't know the granted set from the app alone; this issue is the general, OAuth-independent mechanism.
Out of scope
- Auto-deriving grants from the token (not generally possible for fine-grained PATs / installation tokens).
- Any change to runtime per-call authorization — GitHub remains the enforcement point.
- 主要言語
- Go
- スター
- 33.1k
- フォーク
- 5k
- 平均マージ
- 2日 1時間
- マージ済み PR(30日)
- 25
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
github/github-mcp-server のほかの issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
github/github-mcp-server#3235 ·
-
enhancement
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
github/github-mcp-server#3042 · コメント 2 件 ·
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
github/github-mcp-server#3032 · リアクション 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
github/github-mcp-server#2803 · コメント 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
github/github-mcp-server#2740 ·
github/github-mcp-server の issue をすべて見る
似ている issue
-
textual definition
難易度 1/5 1時間未満 初心者へのやさしさ 90/100
geneontology/go-ontology#32653 ·
-
難易度 1/5 1時間未満 初心者へのやさしさ 75/100
-
needs design
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
-
Priority/High ready-for-agent Severity/Major Type/Bug
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100