Hacktoberfest 2026:メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Clean up the remaining AndroidCurrentDateProvider usages

オープン
#6,104 コメント 1 件 リアクション 0 件 担当者 1 名 GitHub で見る

@runningcode がすでに取り組んでいます。

2026年9月11日 から。

評価

この issue はまだ評価されていません。

説明

Platform: Java

Follow-up to getsentry/sentry-java#6102, which deprecates AndroidCurrentDateProvider but migrates nothing. Five internal call sites still use it, each carrying a @SuppressWarnings("deprecation") that points here.

Why they should move

AndroidCurrentDateProvider.getCurrentTimeMillis() is SystemClock.uptimeMillis(), which stops advancing while the device is in deep sleep. Any interval measured with it under-reports real elapsed time, so a window looks un-expired long after it actually expired. MonotonicTicker is CLOCK_BOOTTIME via SystemClock.elapsedRealtimeNanos() and keeps counting through deep sleep.

Call sites

Debouncerinternal/util/Debouncer.java reads the provider for its window check. Four constructions pass the uptime provider:

  • ViewHierarchyEventProcessor (2 s window)
  • ScreenshotEventProcessor (2 s window)
  • SystemEventsBreadcrumbsIntegration (60 s window)
  • AppComponentsBreadcrumbsIntegration (60 s window)

The two 60 s breadcrumb debouncers are the ones that can swallow a real breadcrumb: a trim-memory or connectivity event right after a long Doze can land inside a window that expired hours ago in wall time. The 2 s screenshot and view-hierarchy windows are much harder to hit. Note this is a behavior change, not a rename — the debounce interval starts counting deep sleep.

AndroidEnvelopeCachecurrentDateProvider.getCurrentTimeMillis() - sdkInitTimeSpan.getStartUptimeMs(), the startup-crash detection threshold. Same deep-sleep skew: a crash long after init, with sleep in between, can fall under startupCrashDurationThresholdMillis and be written as a startup crash.

AndroidEnvelopeCache cannot move in isolation

TimeSpan is documented and implemented on SystemClock.uptimeMillis() (performance/TimeSpan.java:14, :45, :51). Moving only the left operand to a MonotonicTicker tick would subtract two different clock bases — worse than what is there today. Either move TimeSpan's base along with it, or split this call site into its own issue.

Out of scope

  • sentry-android-replay's ICurrentDateProvider consumers — getsentry/sentry-java#5578 / PR #6090.
  • Deleting AndroidCurrentDateProvider. The class is @ApiStatus.Internal and absent from sentry-android-core.api, so removal is not a binary-compat break, but per the project plan removal lands on v9.

Done when

  • No production code references AndroidCurrentDateProvider, or the only remaining reference is AndroidEnvelopeCache with the TimeSpan coupling tracked separately.
  • Every @SuppressWarnings("deprecation") added by getsentry/sentry-java#6102, and its comment, is gone.
  • Tests cover a deep-sleep-style jump: real time advances well past the window while the old uptime source would not have.
主要言語
Kotlin
スター
1.4k
フォーク
478
平均マージ
3日 2時間
マージ済み PR(30日)
70

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

getsentry/sentry-java のほかの issue

getsentry/sentry-java の issue をすべて見る

似ている issue

Kotlin の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。