Admin resources ready for contributed translations, and the pseudo-cultures in the browser (A-53)
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 25/100
- issue の種類
- 機能追加
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- csharp
調査の方向性
Start with sections 4.17, 5.1, 7, and 10.8 of docs/planning/admin-technical-spec.md, then inspect InterfaceCultureOptions.cs, LocalizationTests.cs, and eng/check-admin-size.cs. The issue defines acceptance checks across resource builds, satellite downloads, browser tests, and multiple assemblies; done means all listed acceptance criteria pass, including the ar-XB right-to-left browser case.
索引モデルが issue の本文から書いたものです。
説明
Problem
Row 3.18 asks for resource-based translations of the admin, and AQ14 ships English with the resources ready for contributed translations and pseudo-cultures in the tests. The exit criteria of A7 ask that the admin runs in English and in a right-to-left pseudo-culture. Today:
- One culture, and no proven path for a second.
InterfaceCultureOptions.Shippedis["en"], a list in code (admin/src/FluentCMS.Admin/Localization/InterfaceCultureOptions.cs, line 10). The repository has no resource file of a second culture (five.resxfiles, all neutral), so no build has made a satellite assembly. Nothing has shown that the app fetches the satellite assemblies of the culture chosen at start and of no other, that a lazy assembly finds its own when it loads, or that the size check leaves them out:eng/check-admin-size.csreadssatelliteResourcesof the boot configuration (lines 119 to 125), a branch no publish has reached. - The pseudo-cultures exist in bUnit only.
PseudoCulture(admin/tests/FluentCMS.Admin.Tests/PseudoLocalization.cs,en-XAandar-XB) marks every value through a localizer factory that the test context puts in place of the real one (AdminTestContext.cs, lines 92 to 95). A browser cannot run the admin right to left, so no end-to-end case and no axe-core check (A-42) sees a mirrored page. - The sweep covers one assembly.
LocalizationTestsrenders every routable page ofFluentCMS.Adminunder both pseudo-cultures (LocalizationTests.cs, lines 17 to 51 and 298). The media half and the rich text editor are not in it, and neither is what A6 adds: the administration assembly and five halves. The test of section 7 that asks every key of the neutral resources in each shipped culture does not exist, since there is one culture. - A translator would carry what is not the admin. 113 of the 706 keys of
AdminResources.resxareSystem.*, the texts of the component gallery, sample titles and names included (#3178). - Texts a translation cannot reach.
CmsLibraryTextsfeeds the component library's localizer fromCmsStrings.resx, which holds four of the library's keys; any other keeps the library's English (#3178). A menu item of a half takes its text per culture from its hand-written manifest (labels, withenalone in the media half), not from its resources, and the manifest check asks forenonly.ContentType.{name}is looked up in the resources ofFluentCMS.Adminalone (Shell/AdminLabels.cs, line 19), so only a satellite assembly of that package can name a team's types (#3178).
Proposal
- A translation is a set of resource files and nothing else. The shipped cultures come from the build: the cultures
FluentCMS.Adminhas resource files in, in place of the list in code. Each assembly of the app carries its own (AdminResources.fr.resx,CmsStrings.fr.resxand so on), each becomes a satellite assembly, and the app fetches those of the culture chosen at start only. The first download aseng/check-admin-size.csmeasures it does not change with the number of cultures. - A test of the keys. For each shipped culture and each assembly: every key of the neutral file is there, none is there that the neutral file lacks, and the placeholders of a text are those of the neutral one. It names each difference. With English alone it passes on nothing, so it is proven on the pseudo-cultures.
- The pseudo-cultures in the browser, in a test build only. With a build property (the name is open) the build writes
en-XAandar-XBresource files from the neutral ones, for every assembly of the app, with the marking ofPseudoCulture, which moves to one place that the build and the component tests share. A release build holds none. The end-to-end host is published with the property, andFluentCms:Admin:Cultures:Defaultchooses one for a run. - The sweep covers every first-party assembly. The helper that finds unmarked text moves to
admin/tests/Shared, and the test project of each half, of the rich text editor and of the administration assembly renders its pages under both pseudo-cultures. - The gallery's texts move to a resource file of their own, which the test of the keys and a translation leave out.
- The library's texts. Every text of the library that a wrapped component can show is in
CmsStrings.resxunder the library's key. A check in the browser underen-XAfinds no unmarked text in the gallery, shadow roots included; a text the library draws in script and no key reaches is listed with its component. - A half's menu texts. The manifest check asks a text in
labelsfor each culture the half has resources in, so a translated half whose manifest was forgotten fails its manifest test. - A team's type names. The app gives
AddFluentCmsAdmina resource type of its own, read before the admin's forContentType.{name}. A half's menu label stays in its manifest, as A-19 decided.
Acceptance
- A build with the pseudo-cultures publishes one satellite assembly per assembly and culture; the network shows those of the chosen culture fetched at start, none of the other, and a lazy assembly's texts in that culture once it loads
- The first download that
eng/check-admin-size.csmeasures is the same with and without the pseudo-cultures, and a release build holds no pseudo-culture - With
ar-XBas the default culture the document isdir="rtl", and an end-to-end case signs in, opens a list and a form and finds every text of the shell marked - The test of the keys names a key that a culture lacks, a key the neutral file lacks, and a text whose placeholders differ
- Every page of the administration assembly, of the rich text editor and of each half passes the sweep under both pseudo-cultures in its own test project
-
AdminResources.resxholds no key of the gallery, and no wrapped component shows an unmarked text of the library in the gallery underen-XA - The manifest test of a half fails when the half has resources in a culture that a menu label lacks
- A team's app names a content type in its own resources and the sidebar shows it
- The items of #3178 on the library's built-in strings, the gallery's texts and the label of a content type are ticked
Design: docs/planning/admin-technical-spec.md, sections 4.17, 5.1, 7 and 10.8 (A-53, split from A-41). Rows 3.18, 7.9. Takes three items of #3178. A-41 and A-42 need it. Size: M.
- 主要言語
- C#
- スター
- 567
- フォーク
- 107
- 平均マージ
- 1時間 19分
- マージ済み PR(30日)
- 353
環境構築
- Dockerfile または Docker Compose ファイルあり
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
fluentcms/FluentCMS のほかの issue
-
area:localization plugin type:bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
area:storage type:bug
難易度 4/5 3〜5日 初心者へのやさしさ 48/100
メンテナーはふだん 1 日以内に返信
-
area:testing type:bug
難易度 3/5 1〜2日 初心者へのやさしさ 72/100
メンテナーはふだん 1 日以内に返信
-
area:api area:publishing type:feature
難易度 4/5 3〜5日 初心者へのやさしさ 55/100
fluentcms/FluentCMS#3473 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
area:storage plugin type:bug
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
メンテナーはふだん 1 日以内に返信
fluentcms/FluentCMS の issue をすべて見る
似ている issue
-
[Bug]: Threading.Analyzers 0.7.79 does not load on the .NET 10 SDK (CS9057), CHT rules silently offオープンbug regression threading
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
CryptoHives/Foundation#362 ·
メンテナーはふだん 1 日以内に返信
-
[Bug]: 本地歌词翻译显示错误オープンbug need-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
Fervent-Tempo/AF-Media-Bar#321 ·
-
a-corriger documentation
難易度 1/5 1時間未満 初心者へのやさしさ 87/100
christian-raj/S-Aloha#345 ·
-
bug 要トリアージ
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
メンテナーはふだん 1 日以内に返信
-
worldInstancedOccluderNode reads its appendix count as one byte, but it is a VLQ対応中かも @spuddeh が今日担当しました。 オープン
難易度 1/5 1時間未満 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信