Export reads one row at a time without a snapshot, and import crashes on a locale for a non-localized type

オープン
#3,305 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
25/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
csharp, sql

調査の方向性

Start with the named transfer paths under src/FluentCMS.Core/: Content/EntryTransfer.cs, Transfer/TransferExporter.cs, Transfer/TransferImporter.cs, and the referenced store, service, import, and authorization files. Trace export queries and transaction handling, then follow how import handles locales and author fields; check the tests for each acceptance item. Done means all four behaviors meet the acceptance criteria and each has a test.

索引モデルが issue の本文から書いたものです。

説明

area:content performance type:bug

Problem

  1. Export reads entries one row at a time. Only cms_document is read in chunks of 100 (Content/EntryTransfer.cs:67-69). Each locale row then calls store.ReadAsync per state (:82-83), 2–3 queries each (Content/EntryStore.cs:143-153): up to 6 queries per locale row.
  2. Export is not a snapshot. Transfer/TransferExporter.cs:125-140 opens no transaction; ids, document rows and field rows are separate statements. A save during the export can pair an old version with new fields, or leave a reference to an entry missing from the package.
  3. A non-localized item that carries a locale crashes. The locale is kept as sent (Transfer/TransferImporter.cs:424-427) but the row is written under "" (Content/ContentService.cs:1256), so written.Find(...)! throws a NullReferenceException (Content/ContentService.Import.cs:113-116). The item is reported as an unexpected failure. Only hand-made packages do this.
  4. The package decides who owns imported entries. Keeping the author fields is specified (spec 4.14), but the own-entries rule keys on CreatedBy (Authorization/AuthorizationBuilder.cs:16), and there is no way to import as oneself.

Paths are under src/FluentCMS.Core/.

Proposal

  • Read shared rows, locale rows and references per chunk with IN (ids).
  • Run the export in one snapshot or repeatable-read transaction.
  • Refuse the line as an invalid item, with a message.
  • Add authors=keep|importer to import, default keep.

Acceptance

  • Exporting N entries issues a number of queries proportional to N / chunk size
  • A save during an export does not change what the package contains
  • A non-localized item with a locale is reported as invalid, not as an unexpected failure
  • authors=importer records the importer as creator and updater
  • Tests for each

Found in the code review of 17 Nov 2026.

主要言語
C#
スター
567
フォーク
107
平均マージ
1時間 19分
マージ済み PR(30日)
353

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

fluentcms/FluentCMS のほかの issue

fluentcms/FluentCMS の issue をすべて見る

似ている issue

C# の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。