[Data Connect] MISSING_JOIN_TABLE_KEY false positive on tables with an explicit id key referenced by other tables

オープン
  • 何か問題がありますか？
#11,348 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
55/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
typescript
領域
backend-api-design, cli

調査の方向性

Start by tracing the Data Connect schema compilation path used by firebase dataconnect:compile and find where MISSING_JOIN_TABLE_KEY is detected; the issue does not name implementation files or tests. Check how the detection handles explicit @table(key: ["id"]) declarations and references from other tables, then add coverage for the Enrollment schema. Done when that schema no longer produces the warning while genuine join tables still do.

索引モデルが issue の本文から書いたものです。

説明

api: dataconnect Needs: Author Feedback type: bug
[REQUIRED] Environment info

firebase-tools: 15.34.1 (Data Connect emulator / toolkit 3.4.24)

Platform: macOS 26.4, Node 22

[REQUIRED] Test case

A table with two required @ref fields that is an entity in its own right, not a join table. It has its own id key, the pair of parents is intentionally not unique, and another table references it by id:

type User @table { name: String! }
type Plan @table { title: String! }

# A user can enroll in the same plan more than once (re-enrollment),
# so (user, plan) is not unique and cannot be the primary key.
type Enrollment @table(key: ["id"]) {
  id: UUID! @default(expr: "uuidV4()")
  user: User!
  plan: Plan!
  startDate: Date!
  status: String!
}

# Other tables reference an enrollment by its id.
type Session @table {
  enrollment: Enrollment
  performedAt: Timestamp!
}

The same thing happens for other common shapes, e.g. a "notes about a user written by an author" table (many notes per author/user pair), or an ordered "exercises in a workout" table where the same exercise can appear twice.

[REQUIRED] Steps to reproduce
  1. Use the schema above.
  2. Run firebase deploy --only dataconnect (also shown by firebase dataconnect:compile).
[REQUIRED] Expected behavior

No MISSING_JOIN_TABLE_KEY warning for Enrollment. It explicitly declares key: ["id"], and another table references that key, so it can't be a join table missing its composite key. Alternatively, a way to acknowledge the warning per table (e.g. a schema-level opt-out) so it doesn't show on every deploy.

[REQUIRED] Actual behavior

Every deploy lists the table as an insecure operation or risky change and asks for acknowledgement:

MISSING_JOIN_TABLE_KEY  schema/....gql: On Enrollment: This table looks like a join table, but it is missing the composite primary key definition.
Workaround: Add `@table(key: ["plan", "user"])` to the type.
Reason: A join table must have a composite primary key that consists of two foreign keys.

Following the suggested workaround would be wrong here. It would break re-enrollment, drop the id that Session references, and require a primary-key migration on a populated table.

Related: #9630 (@view false positive, fixed in v15.3.0) and #9762 (3-column composite key false positive). In both, a maintainer confirmed the warning is non-blocking and shouldn't trigger in those cases.

主要言語
TypeScript
スター
4.5k
フォーク
1.3k
平均マージ
2日 5時間
マージ済み PR（30日）
68

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

firebase/firebase-tools のほかの issue

firebase/firebase-tools の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。