[Runtime] Carp::carp reports Java source location in compile-time attribute handlers

オープン
#2,092 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
54/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
java, perl
領域
backend

調査の方向性

Start by reading Attributes.java near line 402 and the runtime stack or source-location handling used by Carp::carp; the issue identifies the Java call into the compile-time attribute handler as the failing path. Add project-owned regression coverage for a :ATTR(CODE,BEGIN) handler that calls Carp::carp, then run it on system Perl and both PerlOnJava backends. Done means the warning reports the Perl source file and line on both backends.

索引モデルが issue の本文から書いたものです。

説明

area:backend area:runtime area:warnings bug

Summary

A compile-time custom code attribute handler that calls Carp::carp gets the PerlOnJava implementation file and line as its warning location. In the Attribute-RecordCallers 0.02 suite, the warning points to Attributes.java line 402 instead of the Perl test file t/03my.t, so the test's source-location assertion fails.

Reproduction

Install or add Attribute-RecordCallers 0.02 to @INC, then run its upstream test t/03my.t:

use 5.18.0;
use warnings;
use feature 'lexical_subs';
no warnings 'experimental::lexical_subs';
use Attribute::RecordCallers;

my @w;
BEGIN { $SIG{__WARN__} = sub { push @w, @_ }; }
my sub foo :RecordCallers { }
print $w[0];

The upstream test checks that the warning matches:

Ignoring RecordCallers attribute on anonymous subroutine at .*03my.t

System Perl 5.42.2 passes the complete distribution suite: 8 files, 64 tests. On PerlOnJava, the JVM and interpreter backends both emit:

Ignoring RecordCallers attribute on anonymous subroutine at Attributes.java line 402.

The archived CPAN run 20261117-153921-75160 fails only t/03my.t test 4: 63/64 assertions pass (1 of 8 test files fails).

Root cause

Attributes.java:402 invokes the Perl custom MODIFY_CODE_ATTRIBUTES handler during compilation. Attribute::RecordCallers calls Carp::carp from that handler. Carp's stack walk receives the Java implementation call site as the source location instead of the Perl compilation unit and line. The resulting warning therefore contains Attributes.java line 402 rather than t/03my.t.

This reproduces on both execution backends. It is a Perl source-location/runtime stack mapping issue, not an Attribute-RecordCallers dependency or environment failure; the distribution is pure Perl and passes on system Perl.

Expected behavior

Warnings emitted by Carp::carp in compile-time attribute handlers should identify the Perl source file and line where the attribute is being applied, matching system Perl.

Related issues

Issues #1656 and #1666 addressed Carp::croak locations through Moo-generated eval/destructor wrappers. This report is a distinct reproducible Carp::carp location failure during compile-time attribute application; the existing fixes do not correct this case.

Suggested regression coverage

Add a project-owned test for a compile-time custom :ATTR(CODE,BEGIN) handler that calls Carp::carp, asserting that the warning location names the Perl source file rather than a Java implementation file. Validate the test on system Perl and both PerlOnJava backends.

主要言語
Perl
スター
67
フォーク
8
平均マージ
5時間 12分
マージ済み PR(30日)
131

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

fglock/PerlOnJava のほかの issue

fglock/PerlOnJava の issue をすべて見る

似ている issue

Perl の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。