Avoid repeated reachability walks while Moose modules initialize

オープン
  • 何か問題がありますか？
#1,950 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
java
領域
compilers

調査の方向性

Start in WeakRefRegistry.weaken(), at the weakenedLiveBlessedRef condition, where reachableOwnerCount() is evaluated before ModuleInitGuard.inModuleInit(). Follow reachableOwnerCount() into ReachabilityWalker.isScalarReachable() to see the root walk. Reorder the check, add a deterministic regression test for module initialization, and confirm weak-reference behaviour outside module init. Done when t/05_round.t finishes on both the JVM and interpreter backends.

索引モデルが issue の本文から書いたものです。

説明

area:memory area:performance bug

Summary

Loading StorageDisplay 1.0.11 through Moose triggers a large number of Scalar::Util::weaken calls. For live blessed references, WeakRefRegistry.weaken() calls reachableOwnerCount(), which repeatedly walks the Perl object graph. The module-initialization guard is checked only after this expensive query, so it does not suppress the work during module loading. The repeated walks make t/05_round.t exceed the CPAN tester timeout on both PerlOnJava backends.

Evidence

  • CPAN random tester run: 20261102-094403-98885
  • Distribution: StorageDisplay-1.0.11; failing test: t/05_round.t
  • System Perl 5.42.2: full suite passed, 7 files / 85 tests, in about 6 seconds.
  • PerlOnJava 5.44.1 / Java 24.0.2: CPAN run timed out after 120 seconds with no output for 60 seconds. Focused runs of t/05_round.t with the archived dependency overlay exceeded a 40-second hard timeout on both JVM and interpreter backends.
  • An 8-second JVM Flight Recorder profile of use StorageDisplay showed repeated stacks through ScalarUtil.weaken, RuntimeBase.reachableOwnerCount, and ReachabilityWalker root traversal. This is repeated work, not evidence of an infinite loop.

StorageDisplay is pure Perl and uses Moose 2.4000 and namespace::sweep 0.006. The PerlOnJava report showed t/000-report-versions.t passing before the harness stopped producing output.

Suspected cause

In WeakRefRegistry.weaken(), the condition at the weakenedLiveBlessedRef check evaluates base.reachableOwnerCount() == 0 before !ModuleInitGuard.inModuleInit(). reachableOwnerCount() checks each active owner using ReachabilityWalker.isScalarReachable(), which traverses the global root graph. Moose performs many such weaken operations while required modules execute under ModuleInitGuard, multiplying full root walks during initialization.

Move the module-init check ahead of the reachability query, then confirm the same behavior is preserved outside module initialization.

Acceptance criteria

  • Add deterministic regression coverage proving module initialization does not perform the expensive reachable-owner walk for this path.
  • Run new/changed Perl-level coverage with system Perl first.
  • t/05_round.t completes under PerlOnJava's JVM and interpreter backends with the archived dependency load order.
  • Run the required build and lifecycle tests; retain bounded output and verify weak-reference semantics outside module initialization.

Related: #1642 and merged PR #1746 addressed other repeated reachability paths during cleanup. This CPAN case reproduces through WeakRefRegistry.weaken() during module initialization.

主要言語
Perl
スター
65
フォーク
8
平均マージ
5時間 49分
マージ済み PR（30日）
177

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

fglock/PerlOnJava のほかの issue

fglock/PerlOnJava の issue をすべて見る

似ている issue

Perl の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。