feat(workflow): attention nudge when a launch workflow parks on a gate

オープン
#115 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
javascript, python
領域
backend, frontend

調査の方向性

Start with the workflow runner and external event buffer in src/profiles/server/routes/workflow.py and src/profiles/server/routes/instance.py, then trace how the App polls /api/notifications and displays port handoff toasts. Add a gate event when a session newly enters a waiting state, and handle it in the web layer with deduplication and focus checks. Done means the gate draws attention through the requested cues without repeating for the same session and step; the issue names no test files.

索引モデルが issue の本文から書いたものです。

説明

enhancement

Problem

When a launch triggers workflow hooks containing ask:/notify: gates, the session parks in waiting_ask/waiting_notify until the user answers. Users who trigger launches via barcode scans or keyboard shortcuts are frequently focused in another application when the gate appears — ProFiles sits in the background with the runner modal open and nothing draws them back. Interactive sessions are kept indefinitely (the TTL purge only drops terminal sessions), so a missed gate can block the rest of a workflow for as long as the app runs.

Evidence

  • The only way forward is the respond route; src/profiles/server/routes/workflow.py:397-643. The purge at src/profiles/server/routes/workflow.py:90-96 explicitly keeps interactive sessions (Drop terminal sessions past the TTL (interactive ones are kept)).
  • A general UI event poll channel already exists and is already polled by the app for port-handoff toasts: GET /api/notifications at src/profiles/server/routes/instance.py:74 (state.external_events_after(after)).
  • No event is recorded when a session enters a waiting state, and no OS-level attention mechanism (toast, document.title flash, notification) exists anywhere in the web layer today.

Proposed approach

  • Server: when the session runner parks on waiting_ask / waiting_notify / notice, push an event into the existing external-events buffer (same channel the port handoff uses), carrying session id + gate kind.
  • Web: the App-level notifications poll already runs — on a gate event, show a toast, flash document.title, and fire a Web Notification where the environment permits. Fire only when the gate is newly reached (dedupe per session+step), and skip when the document has focus.
  • Desktop (optional stretch): a pywebview-specific attention request kept inside profiles.desktop, per the AGENTS.md layering rules (presentation layer only).
  • Scope S-M. No breaking change — additive event + UI behaviour.

Alternatives considered

  1. Auto-timeout on gates — changes workflow semantics and could auto-launch or auto-skip against the user's intent; rejected.
  2. Sound-only cue — poor accessibility and lost on muted systems; toast + title flash is quieter, testable headlessly (vitest), and composes with the existing toast component.

Proposed during automated enhancement scan 2026-11-04

主要言語
Python
スター
1
フォーク
1
平均マージ
4時間 46分
マージ済み PR(30日)
55

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

falbany/ProFiles のほかの issue

falbany/ProFiles の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。