WasmFS: ProxyWorker's 50 ms heartbeat outlives its thread and runs the freed queue on a pooled Worker (`Assertion failed: pthread_self()` in `emscripten_proxy_execute_queue`)

オープン
  • 何か問題がありますか？
#27,858 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
cpp, wasm
領域
devtools

調査の方向性

Start with the heartbeat in src/lib/libwasmfs.js and ProxyWorker lifecycle in system/lib/wasmfs/thread_utils.h, then review Worker pooling in src/lib/libpthread.js. Run the provided proxy_worker_exit.cpp command with -pthread, -sWASMFS, -sPTHREAD_POOL_SIZE=2, and -sEXIT_RUNTIME; done means repeated heartbeats no longer access the destroyed queue or abort after worker reuse.

索引モデルが issue の本文から書いたものです。

説明

emscripten::ProxyWorker (system/lib/wasmfs/thread_utils.h), which the OPFS and fetch backends use for their dedicated thread, starts a heartbeat on that thread: a 50 ms setInterval that calls emscripten_proxy_execute_queue() on the ProxyWorker's queue. Nothing stops it except ABORT.

~ProxyWorker() cancels and joins the thread, and then the queue is freed. But the thread's Worker goes back to the pool rather than being terminated, and its timer goes with it. So every 50 ms the Worker runs a freed queue: while it is idle, pthread_self() is null and, with assertions, emscripten_proxy_execute_queue() aborts; without assertions, or once the Worker hosts another thread, it reads freed memory. Backends are destroyed at exit with EXIT_RUNTIME, so a program with an OPFS or fetch backend can abort at exit this way.

Version of emscripten/emsdk:

emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 6.0.12-git (ce6d2aad8bbf1e508e5a6d112f986617198bdc0d)
clang version 24.0.0git (https:/github.com/llvm/llvm-project d3e9891b54da54deebe2a6df0eb67c8ec155fa65)

main at ce6d2aad8 with the toolchain from test/emsdk_version.txt (dbaebb43), Node.js v24.19.0, x86_64 Linux.

Test case (proxy_worker_exit.cpp, which includes the internal header as a backend does):

// A destroyed ProxyWorker must leave nothing running against its freed queue,
// both while its Worker is idle in the pool and once it hosts another thread.
// Each wait spans several of the thread's 50 ms heartbeats.

#include <assert.h>
#include <condition_variable>
#include <emscripten/emscripten.h>
#include <emscripten/eventloop.h>
#include <mutex>
#include <stdio.h>
#include <thread>

#include "thread_utils.h"

// A ProxyWorker can't be created on the main browser thread.
static void use_worker() {
  std::thread([] {
    emscripten::ProxyWorker worker;
    bool ran = false;
    worker([&] { ran = true; });
    assert(ran);
  }).join();
}

static void second_idle(void*) {
  printf("done\n");
  emscripten_force_exit(0);
}

static void first_idle(void*) {
  use_worker();
  emscripten_set_timeout(second_idle, 500, nullptr);
}

int main() {
  use_worker();
  emscripten_set_timeout(first_idle, 500, nullptr);
}

Failing command line in full:

$ em++ -pthread -sWASMFS -sPTHREAD_POOL_SIZE=2 -sEXIT_RUNTIME -I$EMSCRIPTEN/system/lib/wasmfs proxy_worker_exit.cpp -o t.js
$ node t.js
Aborted(Assertion failed: pthread_self(), at: /emsdk/emscripten/system/lib/pthread/proxying.c,113,emscripten_proxy_execute_queue)
worker sent an error! undefined:undefined: Aborted(Assertion failed: pthread_self(), at: /emsdk/emscripten/system/lib/pthread/proxying.c,113,emscripten_proxy_execute_queue)
node:internal/event_target:1136
  process.nextTick(() => { throw err; });
                           ^

RuntimeError: Aborted(Assertion failed: pthread_self(), at: /emsdk/emscripten/system/lib/pthread/proxying.c,113,emscripten_proxy_execute_queue)
    at abort (t.js:855:11)
    at ___assert_fail (t.js:1743:7)
    at wasm://wasm/0006d26e:wasm-function[189]:0x3aa3
    at t.js:887:12
    at Timeout._onTimeout (t.js:2262:13)
    at listOnTimeout (node:internal/timers:635:17)
    at process.processTimers (node:internal/timers:571:7)

Node.js v24.19.0
[exit status 1]

It aborts in 10 runs out of 10. At -O2 (no assertions) it prints done, since the freed queue is still readable and empty.

Where:

I have a fix ready and will send a PR: the destructor stops the heartbeat on the thread, with a synchronous proxied call, before cancelling it.

主要言語
C++
スター
27.8k
フォーク
3.6k
平均マージ
1日 6時間
マージ済み PR（30日）
181

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

emscripten-core/emscripten のほかの issue

emscripten-core/emscripten の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。