Update: stage support files before activation in the Terminal update path

オープン
  • 何か問題がありますか？
#484 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
42/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
rust
領域
backend, testing

調査の方向性

Read update.rs around lines 1580–1658 and compare the Terminal and operator paths with the System Update staging at lines 1727–1790; then inspect setup.rs and update_controller.rs at the referenced locations. Add coverage for failures on the second changed support file and after the first replacement, verifying the previous release set remains usable offline and user data is unchanged. The issue also requires cross-family review and installed update checks on Mac and Linux.

索引モデルが issue の本文から書いたものです。

説明

Intended behavior

elastos update in the Terminal and the remote operator apply path stage every changed provider and capsule file before they activate the new release, as the System Update path already does. If any step fails, the Home keeps one verified release set: the previous binary, components.json, providers and capsules. The Home then opens without network access, and user data stays unchanged.

Current gap

On the local 0.8.0 candidate 460b1888d, the Terminal path activates the binary and components.json (update.rs:1580), then writes each changed support file to its live path (update.rs:1591, setup.rs:3778-3839). If a later step fails, recovery (update.rs:1652-1658) restores the release files and keeps the support files that were already written. The code comment at update.rs:1587-1588 records the same gap. On the next Home start, support repair (update_controller.rs:695-696) downloads the previous files again, so a Home with network access repairs itself. A Home without network access cannot start until the release source is reachable again.

The gap was first recorded in #108 and confirmed again by the 22 October audit (#108 comment). Develop 3beb81643 has the same code, so the train did not introduce it. The System Update button uses complete staging (update.rs:1727-1790).

The updater that runs is the one already installed, so this fix protects updates that start from a release that contains it.

Done means

  • The Terminal and operator paths stage support with the shared staging (setup::stage_update_support, prepare_support) before activation.
  • Tests: the second changed support file fails after the first one succeeds; the update stops after the first support replacement. In both cases the previous binary, manifests, providers and capsules form one verified set, Home opens without network access, and user data is unchanged.
  • Cross-family review of the diff.
  • Installed update check on Mac and Linux from a release that contains the fix.

Triage (22 Oct): known gap for 0.8.0, fixed after the release. Related: #108, #89, #297.

主要言語
Rust
スター
6
フォーク
2
平均マージ
1日 3時間
マージ済み PR（30日）
42

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

elastos/elastos-runtime のほかの issue

elastos/elastos-runtime の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。