Show a visible notice when a dashboard snapshot read is cut at the row cap

オープン
#336 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
54/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
next.js, playwright, react, supabase, typescript
領域
data, frontend

調査の方向性

Start in src/lib/supabase/paging.ts: readAllPages already stops at SNAPSHOT_MAX_ROWS, so the first question is how it can also report whether it was cut. Carry that complete value through loadSnapshots and loadMonthlySnapshots in src/lib/data/dashboard.ts and getHeadlineSnapshots in src/lib/data/headline.ts, then render one page-level notice following the withStaleNotice pattern from #267, naming the affected part and the first complete date. Done means boundary tests just under, at and over the cap for each read, plus one Playwright case with an accessibility scan.

索引モデルが issue の本文から書いたものです。

説明

area: dashboard bug priority: P2 size: M

Summary

The dashboard's snapshot reads stop at SNAPSHOT_MAX_ROWS = 10_000 rows, newest first (readAllPages in src/lib/supabase/paging.ts), and when a read is cut the only signal is a dashboard.snapshots_truncated warning in the log (loadSnapshots and loadMonthlySnapshots in src/lib/data/dashboard.ts). The user sees missing history as unavailable values with no explanation.

Where each read is cut, from the review of PR #334 (#317):

Read Rows per account and metric Cut at about
Cards and daily trend: loadDashboardSnapshots (45 days, every daily row) 45 222 account and metric pairs
Headline strip: getHeadlineSnapshots in src/lib/data/headline.ts (money kinds and declared signup totals) days in the windows depends on the window
Monthly trend: loadMonthlySnapshots (one row per month since #317) 13 770 account and metric pairs

The cards' read is now the weakest: past about 222 pairs with a daily row each, the oldest days of the 45 day window are dropped, so an account that stopped reporting in that range falls out of the current values silently.

Scope

  • Carry complete from readAllPages up through these reads and show one visible notice on the dashboard when any of them was cut, saying which part (cards, headline, monthly trend) is incomplete and from which date the data is complete.
  • One notice for the page, following the stale notice pattern (withStaleNotice, #267), not one per card.

Acceptance criteria

  • A workspace past the cap of any of the three reads sees a visible notice naming the affected part and the date from which it is complete.
  • Happy-path and boundary tests: just under, at, and over the cap for each read.
  • Playwright covers the notice on one cut read, with an accessibility scan.

Source: Fable review round 1 of PR #334, comment https://github.com/eddiejaoude/DevMacro/pull/334#discussion_r4543797670.

Model: anthropic/claude-opus-5-5 | Reasoning effort: low

主要言語
TypeScript
スター
1
フォーク
1
平均マージ
6時間 56分
マージ済み PR(30日)
136

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

eddiejaoude/StackDash のほかの issue

eddiejaoude/StackDash の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。