Set up user authentication with OAuth
@parkhabit がすでに取り組んでいます。
2018年4月6日 から。
評価
この issue はまだ評価されていません。
説明
This issue began as a discussion of the download/authorisation/authentication model of the application. Set up as a github app has been done and so now the next point to be addressed in this issue will be the authentication of users trying to access their github history/backup using OAuth.
As a gh-backup user
I want to be able to authenticate myself to access my github history
so that I know that unauthorised users will not have access to my private history.
- User is redirected to github authentication when trying to access a github-backup page
- User is redirected to the gh-backup page once they're authentication is successful
Notes:
OAuth Authentication
Once a user (where github-backup has been installed) wants to click on the button to see the history of a given comment they will be taken to the github-backup site and then they will have to authenticate with OAuth to prove that they are from the org. This step technically would not need to be performed in the case of public repos but given that it's essential for private repos, you only have to do it once and that in the future we may introduce writing access it seems like a good idea.
OAuth2 lets external applications request authorization to private details in a user's GitHub account
— Providing that its a Github App that has been installed by the org owner, will the github API provide a user access to all issues/comments regardless of if they're an author/ mentioned in them?
Github Apps
To see the github-back up button on each of your comments (which would link you to the github-backup site) we would use github apps.
To install a GitHub App, you must be an organization owner.
In the case of github-backup I envisage this being the case (so that in the long run the organisation can decide whether they wish to accept any costs associated with using the app as opposed to the individual). The other advantage of this is that: 'a GitHub App remains installed if the person who set it up leaves the organization', so this would be continuous as well.
GitHub Apps can request separate access to issues and pull requests without accessing the actual contents of the repository.
- 主要言語
- Elixir
- スター
- 33
- フォーク
- 3
- PR マージ指標
- 30日以内にマージされた PR はありません
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
dwyl/github-backup のほかの issue
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 15/100
dwyl/github-backup#138 ·
-
discuss enhancement priority-2
dwyl/github-backup#136 · コメント 10 件 · 担当者 1 名 ·
-
😕 オープンhelp wanted priority-2
難易度 5/5 1週間以上 初心者へのやさしさ 25/100
dwyl/github-backup#135 · コメント 1 件 · リアクション 3 件 ·
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 20/100
dwyl/github-backup#133 ·
-
discuss priority-4 technical
難易度 5/5 1週間以上 初心者へのやさしさ 20/100
dwyl/github-backup#132 · コメント 3 件 · リアクション 1 件 ·
dwyl/github-backup の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
carverauto/serviceradar#4542 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
phoenixframework/phoenix#6847 ·
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
beyond-all-reason/teiserver#1584 ·