[todo] check rpmlint warnings and errors on packages

オープン
#585 コメント 4 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
49/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
bash, docker, python

調査の方向性

Start by identifying the RPM spec files and packaging scripts that produce the packages listed in the issue, then reproduce the checks with rpmlint on CentOS 7 and Fedora 35. The output covers several packages and many different warnings, and the issue does not specify which findings should be fixed or accepted. Done looks like resolving the agreed actionable warnings and errors and rerunning rpmlint to confirm the results.

索引モデルが issue の本文から書いたものです。

説明

We should look at the rpmlint warnings and errors on the RPMs; some of them look like "easy fixes", others are bit unclear (need to look into the meaning of each of those);

On CentOS 7
CentOS 7: docker-ce-cli
curl -fsSLO  https://download-stage.docker.com/linux/centos/7/x86_64/stable/Packages/docker-ce-cli-20.10.13-3.el7.x86_64.rpm

rpmlint ./docker-ce-cli-20.10.13-3.el7.x86_64.rpm
docker-ce-cli.x86_64: E: description-line-too-long C they can run anywhere, from your laptop to the largest cloud compute instance and
docker-ce-cli.x86_64: E: no-changelogname-tag
docker-ce-cli.x86_64: W: unstripped-binary-or-object /usr/libexec/docker/cli-plugins/docker-buildx
docker-ce-cli.x86_64: W: unstripped-binary-or-object /usr/bin/docker
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-container-create.1.gz 155: warning: macro `host':' not defined
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-container-create.1.gz 156: warning: macro `private':' not defined
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-container-create.1.gz 157: warning: macro `':' not defined
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-image-pull.1.gz 253: warning: macro `...' not defined
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-create.1.gz 51: warning: macro `host':' not defined
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-create.1.gz 52: warning: macro `private':' not defined
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-create.1.gz 53: warning: macro `':' not defined
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-inspect.1.gz 251: warning: macro `...' not defined
docker-ce-cli.x86_64: E: non-executable-script /usr/share/bash-completion/completions/docker 0644L /usr/bin/env
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-run.1.gz 1255: warning: macro `You' not defined
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-container-run.1.gz 51: warning: macro `host':' not defined
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-container-run.1.gz 52: warning: macro `private':' not defined
docker-ce-cli.x86_64: W: manual-page-warning /usr/share/man/man1/docker-container-run.1.gz 53: warning: macro `':' not defined
docker-ce-cli.x86_64: E: unknown-key (MD5
1 packages and 0 specfiles checked; 4 errors, 14 warnings.
CentOS 7: docker-compose-plugin
curl -fsSLO https://download-stage.docker.com/linux/centos/7/x86_64/stable/Packages/docker-compose-plugin-2.3.1-3.el7.x86_64.rpm

rpmlint ./docker-compose-plugin-2.3.1-3.el7.x86_64.rpm
docker-compose-plugin.x86_64: E: no-changelogname-tag
docker-compose-plugin.x86_64: E: statically-linked-binary /usr/libexec/docker/cli-plugins/docker-compose
docker-compose-plugin.x86_64: W: no-documentation
docker-compose-plugin.x86_64: E: unknown-key (MD5
docker-compose-plugin.x86_64: W: empty-%post
docker-compose-plugin.x86_64: W: empty-%preun
docker-compose-plugin.x86_64: W: empty-%postun
1 packages and 0 specfiles checked; 3 errors, 4 warnings.
CentOS 7: docker-scan-plugin
curl -fsSLO https://download-stage.docker.com/linux/centos/7/x86_64/stable/Packages/docker-scan-plugin-0.9.0-3.el7.x86_64.rpm

rpmlint ./docker-scan-plugin-0.9.0-3.el7.x86_64.rpm
docker-scan-plugin.x86_64: E: no-changelogname-tag
docker-scan-plugin.x86_64: E: statically-linked-binary /usr/libexec/docker/cli-plugins/docker-scan
docker-scan-plugin.x86_64: W: no-documentation
docker-scan-plugin.x86_64: E: unknown-key (MD5
docker-scan-plugin.x86_64: W: empty-%post
docker-scan-plugin.x86_64: W: empty-%preun
docker-scan-plugin.x86_64: W: empty-%postun
1 packages and 0 specfiles checked; 3 errors, 4 warnings.
CentOS 7: docker-ce
curl -fsSLO https://download-stage.docker.com/linux/centos/7/x86_64/stable/Packages/docker-ce-20.10.13-3.el7.x86_64.rpm

rpmlint ./docker-ce-20.10.13-3.el7.x86_64.rpm
docker-ce.x86_64: E: explicit-lib-dependency libcgroup
docker-ce.x86_64: E: description-line-too-long C they can run anywhere, from your laptop to the largest cloud compute instance and
docker-ce.x86_64: E: no-changelogname-tag
docker-ce.x86_64: W: obsolete-not-provided docker-ce-selinux
docker-ce.x86_64: W: obsolete-not-provided docker-engine-selinux
docker-ce.x86_64: W: obsolete-not-provided docker-engine
docker-ce.x86_64: W: unstripped-binary-or-object /usr/bin/dockerd
docker-ce.x86_64: W: unstripped-binary-or-object /usr/bin/docker-proxy
docker-ce.x86_64: E: statically-linked-binary /usr/bin/docker-init
docker-ce.x86_64: W: only-non-binary-in-usr-lib
docker-ce.x86_64: W: no-documentation
docker-ce.x86_64: W: no-manual-page-for-binary docker-proxy
docker-ce.x86_64: W: no-manual-page-for-binary docker-init
docker-ce.x86_64: W: no-manual-page-for-binary dockerd
docker-ce.x86_64: E: unknown-key (MD5
1 packages and 0 specfiles checked; 5 errors, 10 warnings.
CentOS 7: docker-ce-rootless-extras
curl -fsSLO https://download-stage.docker.com/linux/centos/7/x86_64/stable/Packages/docker-ce-rootless-extras-20.10.13-3.el7.x86_64.rpm
rpmlint ./docker-ce-rootless-extras-20.10.13-3.el7.x86_64.rpm
docker-ce-rootless-extras.x86_64: E: no-changelogname-tag
docker-ce-rootless-extras.x86_64: W: unstripped-binary-or-object /usr/bin/rootlesskit-docker-proxy
docker-ce-rootless-extras.x86_64: W: unstripped-binary-or-object /usr/bin/rootlesskit
docker-ce-rootless-extras.x86_64: W: no-documentation
docker-ce-rootless-extras.x86_64: W: no-manual-page-for-binary dockerd-rootless.sh
docker-ce-rootless-extras.x86_64: W: no-manual-page-for-binary dockerd-rootless-setuptool.sh
docker-ce-rootless-extras.x86_64: W: no-manual-page-for-binary rootlesskit
docker-ce-rootless-extras.x86_64: W: no-manual-page-for-binary rootlesskit-docker-proxy
docker-ce-rootless-extras.x86_64: E: unknown-key (MD5
docker-ce-rootless-extras.x86_64: W: empty-%post
docker-ce-rootless-extras.x86_64: W: empty-%preun
docker-ce-rootless-extras.x86_64: W: empty-%postun
1 packages and 0 specfiles checked; 2 errors, 10 warnings.
CentOS 7: containerd.io
curl -fsSLO https://download-stage.docker.com/linux/centos/7/x86_64/stable/Packages/containerd.io-1.5.10-3.1.el7.x86_64.rpm

rpmlint ./containerd.io-1.5.10-3.1.el7.x86_64.rpm
containerd.io.x86_64: W: manpage-not-compressed gz /usr/share/man/man8/ctr.8
containerd.io.x86_64: W: manpage-not-compressed gz /usr/share/man/man8/containerd.8
containerd.io.x86_64: W: manpage-not-compressed gz /usr/share/man/man8/containerd-config.8
containerd.io.x86_64: W: manpage-not-compressed gz /usr/share/man/man5/containerd-config.toml.5
containerd.io.x86_64: E: explicit-lib-dependency libseccomp
containerd.io.x86_64: W: invalid-url URL: https://containerd.io <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:618)>
containerd.io.x86_64: W: self-obsoletion containerd obsoletes containerd
containerd.io.x86_64: W: self-obsoletion runc obsoletes runc
containerd.io.x86_64: E: no-binary
containerd.io.x86_64: W: only-non-binary-in-usr-lib
containerd.io.x86_64: W: no-manual-page-for-binary containerd-shim
containerd.io.x86_64: W: no-manual-page-for-binary runc
containerd.io.x86_64: W: no-manual-page-for-binary containerd-shim-runc-v2
containerd.io.x86_64: W: no-manual-page-for-binary containerd-shim-runc-v1
containerd.io.x86_64: E: unknown-key (MD5
1 packages and 0 specfiles checked; 3 errors, 12 warnings.
On Fedora 35

Checking on Fedora 35 (more current version of RPM)

Fedora 35: docker-ce-cli
curl -fsSLO  https://download-stage.docker.com/linux/fedora/35/x86_64/stable/Packages/docker-ce-cli-20.10.13-3.fc35.x86_64.rpm

rpmlint ./docker-ce-cli-20.10.13-3.fc35.x86_64.rpm
========================================================================================== rpmlint session starts ==========================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

docker-ce-cli.x86_64: W: unstripped-binary-or-object /usr/bin/docker
docker-ce-cli.x86_64: W: unstripped-binary-or-object /usr/libexec/docker/cli-plugins/docker-buildx
docker-ce-cli.x86_64: E: unknown-key 621e9f35
docker-ce-cli.x86_64: W: position-independent-executable-suggested /usr/libexec/docker/cli-plugins/docker-app
docker-ce-cli.x86_64: W: position-independent-executable-suggested /usr/libexec/docker/cli-plugins/docker-buildx
docker-ce-cli.x86_64: E: non-executable-script /usr/share/bash-completion/completions/docker 644 /usr/bin/env bash
docker-ce-cli.x86_64: E: no-changelogname-tag
docker-ce-cli.x86_64: E: description-line-too-long they can run anywhere, from your laptop to the largest cloud compute instance and
=========================================================== 1 packages and 0 specfiles checked; 4 errors, 4 warnings, 4 badness; has taken 3.3 s ===========================================================
Fedora 35: docker-compose-plugin
curl -fsSLO https://download-stage.docker.com/linux/fedora/35/x86_64/stable/Packages/docker-compose-plugin-2.3.1-3.fc35.x86_64.rpm

rpmlint ./docker-compose-plugin-2.3.1-3.fc35.x86_64.rpm
========================================================================================== rpmlint session starts ==========================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

docker-compose-plugin.x86_64: E: unknown-key 621e9f35
docker-compose-plugin.x86_64: E: statically-linked-binary /usr/libexec/docker/cli-plugins/docker-compose
docker-compose-plugin.x86_64: W: position-independent-executable-suggested /usr/libexec/docker/cli-plugins/docker-compose
docker-compose-plugin.x86_64: W: no-documentation
docker-compose-plugin.x86_64: E: no-changelogname-tag
docker-compose-plugin.x86_64: W: empty-%preun
docker-compose-plugin.x86_64: W: empty-%postun
docker-compose-plugin.x86_64: W: empty-%post
=========================================================== 1 packages and 0 specfiles checked; 3 errors, 5 warnings, 3 badness; has taken 0.3 s ===========================================================
Fedora 35: docker-scan-plugin
curl -fsSLO https://download-stage.docker.com/linux/fedora/35/x86_64/stable/Packages/docker-scan-plugin-0.17.0-3.fc35.x86_64.rpm

rpmlint ./docker-scan-plugin-0.17.0-3.fc35.x86_64.rpm
========================================================================================== rpmlint session starts ==========================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

docker-scan-plugin.x86_64: E: unknown-key 621e9f35
docker-scan-plugin.x86_64: E: statically-linked-binary /usr/libexec/docker/cli-plugins/docker-scan
docker-scan-plugin.x86_64: W: position-independent-executable-suggested /usr/libexec/docker/cli-plugins/docker-scan
docker-scan-plugin.x86_64: W: no-documentation
docker-scan-plugin.x86_64: E: no-changelogname-tag
docker-scan-plugin.x86_64: W: empty-%preun
docker-scan-plugin.x86_64: W: empty-%postun
docker-scan-plugin.x86_64: W: empty-%post
=========================================================== 1 packages and 0 specfiles checked; 3 errors, 5 warnings, 3 badness; has taken 0.2 s ===========================================================
Fedora 35: docker-ce
curl -fsSLO https://download-stage.docker.com/linux/fedora/35/x86_64/stable/Packages/docker-ce-20.10.13-3.fc35.x86_64.rpm

rpmlint ./docker-ce-20.10.13-3.fc35.x86_64.rpm
========================================================================================== rpmlint session starts ==========================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

docker-ce.x86_64: W: unstripped-binary-or-object /usr/bin/docker-proxy
docker-ce.x86_64: W: unstripped-binary-or-object /usr/bin/dockerd
docker-ce.x86_64: E: unknown-key 621e9f35
docker-ce.x86_64: E: statically-linked-binary /usr/bin/docker-init
docker-ce.x86_64: W: position-independent-executable-suggested /usr/bin/docker-init
docker-ce.x86_64: W: obsolete-not-provided docker-ce-selinux
docker-ce.x86_64: W: obsolete-not-provided docker-engine
docker-ce.x86_64: W: obsolete-not-provided docker-engine-selinux
docker-ce.x86_64: W: no-manual-page-for-binary docker-init
docker-ce.x86_64: W: no-manual-page-for-binary docker-proxy
docker-ce.x86_64: W: no-manual-page-for-binary dockerd
docker-ce.x86_64: W: no-documentation
docker-ce.x86_64: E: no-changelogname-tag
docker-ce.x86_64: E: explicit-lib-dependency libcgroup
docker-ce.x86_64: E: description-line-too-long they can run anywhere, from your laptop to the largest cloud compute instance and
========================================================== 1 packages and 0 specfiles checked; 5 errors, 10 warnings, 5 badness; has taken 4.9 s ===========================================================
Fedora 35: docker-ce-rootless-extras
curl -fsSLO https://download-stage.docker.com/linux/fedora/35/x86_64/stable/Packages/docker-ce-rootless-extras-20.10.13-3.fc35.x86_64.rpm

rpmlint ./docker-ce-rootless-extras-20.10.13-3.fc35.x86_64.rpm
========================================================================================== rpmlint session starts ==========================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

docker-ce-rootless-extras.x86_64: W: unstripped-binary-or-object /usr/bin/rootlesskit
docker-ce-rootless-extras.x86_64: W: unstripped-binary-or-object /usr/bin/rootlesskit-docker-proxy
docker-ce-rootless-extras.x86_64: E: unknown-key 621e9f35
docker-ce-rootless-extras.x86_64: W: no-manual-page-for-binary dockerd-rootless-setuptool.sh
docker-ce-rootless-extras.x86_64: W: no-manual-page-for-binary dockerd-rootless.sh
docker-ce-rootless-extras.x86_64: W: no-manual-page-for-binary rootlesskit
docker-ce-rootless-extras.x86_64: W: no-manual-page-for-binary rootlesskit-docker-proxy
docker-ce-rootless-extras.x86_64: W: no-documentation
docker-ce-rootless-extras.x86_64: E: no-changelogname-tag
docker-ce-rootless-extras.x86_64: W: empty-%preun
docker-ce-rootless-extras.x86_64: W: empty-%postun
docker-ce-rootless-extras.x86_64: W: empty-%post
========================================================== 1 packages and 0 specfiles checked; 2 errors, 10 warnings, 2 badness; has taken 0.4 s ===========================================================
Fedora 35: containerd.io
curl -fsSLO https://download-stage.docker.com/linux/fedora/35/x86_64/stable/Packages/containerd.io-1.5.10-3.1.fc35.x86_64.rpm

rpmlint ./containerd.io-1.5.10-3.1.fc35.x86_64.rpm
========================================================================================== rpmlint session starts ==========================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

containerd.io.x86_64: W: unstripped-binary-or-object /usr/bin/runc
containerd.io.x86_64: E: unknown-key 621e9f35
containerd.io.x86_64: E: statically-linked-binary /usr/bin/containerd-shim
containerd.io.x86_64: E: statically-linked-binary /usr/bin/containerd-shim-runc-v1
containerd.io.x86_64: E: statically-linked-binary /usr/bin/containerd-shim-runc-v2
containerd.io.x86_64: W: self-obsoletion containerd obsoletes containerd
containerd.io.x86_64: W: self-obsoletion runc obsoletes runc
containerd.io.x86_64: W: position-independent-executable-suggested /usr/bin/containerd-shim
containerd.io.x86_64: W: position-independent-executable-suggested /usr/bin/containerd-shim-runc-v1
containerd.io.x86_64: W: position-independent-executable-suggested /usr/bin/containerd-shim-runc-v2
containerd.io.x86_64: W: no-manual-page-for-binary containerd-shim
containerd.io.x86_64: W: no-manual-page-for-binary containerd-shim-runc-v1
containerd.io.x86_64: W: no-manual-page-for-binary containerd-shim-runc-v2
containerd.io.x86_64: W: no-manual-page-for-binary runc
containerd.io.x86_64: W: manpage-not-compressed gz /usr/share/man/man5/containerd-config.toml.5
containerd.io.x86_64: W: manpage-not-compressed gz /usr/share/man/man8/containerd-config.8
containerd.io.x86_64: W: manpage-not-compressed gz /usr/share/man/man8/containerd.8
containerd.io.x86_64: W: manpage-not-compressed gz /usr/share/man/man8/ctr.8
containerd.io.x86_64: E: explicit-lib-dependency libseccomp
========================================================== 1 packages and 0 specfiles checked; 5 errors, 14 warnings, 5 badness; has taken 3.4 s ===========================================================
主要言語
Dockerfile
スター
37
フォーク
42
平均マージ
16時間 53分
マージ済み PR(30日)
30

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

docker/packaging のほかの issue

docker/packaging の issue をすべて見る

似ている issue

Build System の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。