[coverage] Conformance findings: METADATA-005
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 52/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- node.js, typescript
調査の方向性
tests/ 配下の coverage PR #1413 にある METADATA-005 xfail テストから始め、想定される動作を参照 PR #291 と比較します。Node.js ドライバーの SEA getTypeInfo() 実装と、そのメタデータ結果の構築箇所を特定します。Thrift 向けの結果が指定された 18 列、20 行の形状に一致し、適合性テストに合格すれば完了です。
索引モデルが issue の本文から書いたものです。
説明
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-nodejs. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-nodejs) is fixed, then flips green as a tripwire.
Findings
- METADATA-005 [sea]: SEA getTypeInfo() synthesises a non-canonical type catalogue: COLUMN_SIZE instead of PRECISION, AUTO_UNIQUE_VALUE instead of AUTO_INCREMENT, an extra 19th INTERVAL_PRECISION column, and 23 rows (extra VARCHAR/TIMESTAMP_NTZ/INTERVAL/VARIANT/VARBINARY/NUMERIC, VOID missing) instead of the canonical 18-column / 20-row Thrift TGetTypeInfoResp shape
- failing test:
getTypeInfo — canonical 20-row corpus, order, cell values, NULLABLE=1 / getTypeInfo — canonical 18-column TGetTypeInfoResp layout (PRECISION/AUTO_INCREMENT, no INTERVAL_PRECISION)(see the coverage PR diff undertests/)
- failing test:
- METADATA-005: SEA getTypeInfo() synthesises a non-canonical type catalogue: emits COLUMN_SIZE instead of PRECISION and AUTO_UNIQUE_VALUE instead of AUTO_INCREMENT, adds a 19th INTERVAL_PRECISION column, and returns 23 rows (extra VARCHAR/TIMESTAMP_NTZ/INTERVAL/VARIANT/VARBINARY/NUMERIC, VOID missing) instead of the canonical 18-column / 20-row Thrift TGetTypeInfoResp shape, so a wrapper switching Thrift→SEA sees its public getTypeInfo() result change
Reproduce & Expected
METADATA-005 — Validates GetTypeInfo returns the canonical Thrift/HiveServer2 getTypeInfo result for the supported Databricks SQL data types: the 18-column schema, the 20-row type corpus, and the per-type cell va…
Reproduce:
- Call GetTypeInfo via IsMetadataCommand statement (C# only)
Expected (per the shared spec):
- GetTypeInfo completes successfully
- Result contains type information
- C# Thrift path only
- Exactly the canonical Thrift/HiveServer2 getTypeInfo column count — not 19. A synthesised result must not add an extra column (the pre-fix kernel carried a 19th INTERVAL_PRECISION column that the Thrift response does not have). Scoped to the Thrift/JDBC-style surface: ODBC SQLGetTypeInfo has its own spec-fixed column set.
- Column names AND their order match the Thrift getTypeInfo result exactly. The two renames matter for wrappers that read the result positionally or by name: PRECISION (not COLUMN_SIZE) at index 2 and AUTO_INCREMENT (not AUTO_UNIQUE_VALUE) at index 11. Scoped to the Thrift/JDBC-style surface (see SURFACE SCOPE in the description): a driver whose type-info surface is ODBC SQLGetTypeInfo asserts its own canonical column set instead — record that per-driver answer in this entry's status cells.
- The type catalogue has exactly 20 rows — the Thrift
SparkGetTypeInfoUtil.supportedTypecorpus. Not "at least one type": a synthesised catalogue must neither drop rows nor add types Thrift does not report (the pre-fix kernel listed 24 rows including VARCHAR, TIMESTAMP_NTZ, the two INTERVAL types, VARIANT and VARBINARY, which Thrift does not). - The first 17 rows are exactly these type names, in exactly this order — the leading run of the 20-row
SparkGetTypeInfoUtil.supportedTypecorpus. Row ORDER is part of the contract, not just membership: VOID is row 0, and a catalogue that reorders the corpus (or omits VOID) diverges from Thrift even if the same names are present. Only a PREFIX is enumerated because the reference PR diff available when this entry was authored is truncated after CHAR; rows 18–20 are pinned by the row_count: 20 assertion above and should be read off the reference implementation when implementing. - Per-type cell values match Thrift. DATA_TYPE codes are java.sql.Types values and must agree with the driver's getColumns type mapping (the historical drift this pins: FLOAT reported as REAL (7), STRING as LONGVARCHAR (-1), BOOLEAN as BIT (-7)). PRECISION is non-null only for the numeric types (and is NULL for STRING/BINARY/CHAR — a synthesised catalogue must not substitute i32::MAX or 255). SEARCHABLE is 3 (typeSearchable) for every type except the complex types ARRAY / MAP / STRUCT, which are 0 (typeNoSearch). CASE_SENSITIVE is true only for STRING.
- Every row reports NULLABLE = 1 (typeNullable), matching Thrift — not 2 (typeNullableUnknown), which the pre-fix synthesised catalogue used for every row.
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-sql-kernel/pull/291 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-nodejs; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1413
- 主要言語
- TypeScript
- スター
- 37
- フォーク
- 51
- 平均マージ
- 5時間 56分
- マージ済み PR(30日)
- 9
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
databricks/databricks-sql-nodejs のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
databricks/databricks-sql-nodejs#526 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
databricks/databricks-sql-nodejs#503 ·
メンテナーはふだん 1 日以内に返信
-
engineer-bot
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
databricks/databricks-sql-nodejs#274 · コメント 1 件 · リアクション 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 3/5 1〜2日 初心者へのやさしさ 68/100
databricks/databricks-sql-nodejs#525 ·
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
databricks/databricks-sql-nodejs#524 ·
メンテナーはふだん 1 日以内に返信
databricks/databricks-sql-nodejs の issue をすべて見る
似ている issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
rossoctl/serverless-harness#428 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
prime-radiant-inc/evener#3726 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
FuRongJun-1999/dsh-memory#56 ·
メンテナーはふだん 1 日以内に返信
-
bug via-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
pingdotgg/t3code#15682 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
openwatersio/slackwater.xyz#152 ·
メンテナーはふだん 1 日以内に返信