Report.ts pr: install-relative diff cannot apply to upstream's LifeOS/install/ layout

オープン
#2,890 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 5 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
57/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
git, typescript

調査の方向性

Read skills/LifeOS/Tools/Report.ts around lines 332, 633, and 670, plus Redact.ts around line 201. Trace how pr validates diff paths and applies them at the repository root; reproduce with a diff for LifeOS/install/skills/ISA/SKILL.md. Done means accepted diffs apply in the upstream layout and staged path validation still works; the optional existing-issue workflow is a separate change.

索引モデルが issue の本文から書いたものです。

説明

Version

LifeOS 8.761.0 · attestation: not run

What is broken

Report.ts pr cannot open a pull request against the current upstream layout. Its diff gate (diffDenied, via diffAllowed) accepts only install-relative paths such as skills/... or LIFEOS/..., because SYSTEM_TREES lists the install tree. The public repo's main keeps those files under LifeOS/install/, and recent PRs there (for example #2860, #2870) touch LifeOS/install/... paths. So a diff that passes the gate is applied with git apply --index at the repository root, where skills/... does not exist, and pr --yes stops at patch does not apply. The reverse also fails: a diff with LifeOS/install/... paths is refused by the gate. A second, smaller point: pr requires a locally built issue report (build --kind issue) even when the issue already exists upstream, so a contributor answering an existing issue has to build a throwaway issue report and must remember never to run file, which would post a duplicate.

Where (file:line)

skills/LifeOS/Tools/Report.ts:670 (apply), Report.ts:332 + Redact.ts:201 (gate), Report.ts:633 (built issue required)

Repro on a clean tree
1. Fresh shallow clone of danielmiessler/LifeOS main.
2. Change any shipped skill file, e.g. append a line to LifeOS/install/skills/ISA/SKILL.md, and write the diff install-relative (git diff --relative=LifeOS/install), which is the only form the pr gate allows.
3. git apply --index --check that diff at the repository root, exactly as Report.ts pr does at step 3.
4. It fails: skills/ISA/SKILL.md does not exist in the index. Applying with --directory=LifeOS/install succeeds.
Negative control

Probe: export LC_ALL=C; W=$(mktemp -d) && git clone -q --depth 1 https://github.com/danielmiessler/LifeOS.git "$W/r" && cd "$W/r" && printf "x\n" >> LifeOS/install/skills/ISA/SKILL.md && git diff --relative=LifeOS/install > ../skills-relative.patch && git checkout -q . && echo "paths the pr gate allows:" && grep "^diff --git" ../skills-relative.patch && git apply --index --check ../skills-relative.patch · exit 1 · captured 2026-11-20T15:39:41.803Z

paths the pr gate allows:
diff --git a/skills/ISA/SKILL.md b/skills/ISA/SKILL.md

--- stderr ---
error: skills/ISA/SKILL.md: does not exist in index
Suggested fix

In pr, apply the gated install-relative diff under the upstream install root when it exists (git apply --index --directory=LifeOS/install if LifeOS/install/ is present in the clone), and keep running stagedDenied on the staged paths with that prefix stripped. Optionally let pr take --issue <number> instead of a locally built issue report, so answering an existing issue needs no throwaway build.

Environment
  • OS: macOS 26.6.2 (arm64)
  • Harness: claude-code
  • bun: 1.4.2 · git: 2.55.0
  • Doctor broken: none
主要言語
TypeScript
スター
19.9k
フォーク
2.5k
PR マージ指標
30日以内にマージされた PR はありません

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

danielmiessler/LifeOS のほかの issue

danielmiessler/LifeOS の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。