AgentCoreMemorySessionManager discards the two boto3 clients MemoryClient builds; boto_session and boto_client_config are not passed through
メンテナーはふだん 1 日以内に返信
評価
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 初心者へのやさしさ
- 84/100
調査の方向性
src/bedrock_agentcore/memory/integrations/strands/session_manager.py の AgentCoreMemorySessionManager.init から始め、次に memory/client.py:76-80 の MemoryClient.init を調べます。提供されている no-session と warm-session の再現を実行します。完了の条件は、公開シグネチャを変更せずに MemoryClient が override クライアントと同じセッションを使用し、報告されている timing と region の動作が修正されていることです。
索引モデルが issue の本文から書いたものです。
説明
Describe the bug
AgentCoreMemorySessionManager.__init__ builds its MemoryClient without a boto3 session, then overwrites both clients MemoryClient just created with clients from a different session.
# src/bedrock_agentcore/memory/integrations/strands/session_manager.py, 1.23.1
self.memory_client = MemoryClient(region_name=region_name) # :151
session = boto_session or boto3.Session(region_name=region_name) # :152
...
self.memory_client.gmcp_client = session.client( # :195
"bedrock-agentcore-control", region_name=..., config=client_config
)
self.memory_client.gmdp_client = session.client( # :198
"bedrock-agentcore", region_name=..., config=client_config
)
MemoryClient.__init__ accepts boto3_session (memory/client.py:76-80) and would use it. Since it isn't passed, MemoryClient creates its own boto3.Session() and builds bedrock-agentcore-control and bedrock-agentcore clients from it. Lines 195 and 198 then replace both. Those two clients are built and thrown away on every instantiation.
botocore caches the parsed service model per boto3.Session, so a fresh session pays that load again every time.
boto_session and boto_client_config are both in the signature and documented in the docstring. Neither reaches MemoryClient.
Cost
We build a session manager per invoke, so this runs on every turn. We also pass a long-lived boto_session, which is what the parameter is for, and that's where this hurts most. The injected session only reaches the override clients. MemoryClient still cold-builds its own session, and that cold build is nearly all of the remaining time.
Medians over 10 iterations after a warm-up, from the script below:
| caller | as shipped | with the fix below |
|---|---|---|
passes boto_session (a long-lived session) |
42 ms | 3.3 ms |
passes no boto_session |
97 ms | 41 ms |
Five consecutive runs ranged 40.3 to 43.9 ms against 3.2 to 3.5 ms for the first row, and 95.3 to 98.9 ms against 39.9 to 44.1 ms for the second.
These are from an M-series laptop. On a warm AgentCore runtime the per-turn cost is in the same range, 37 to 51 ms. The first construction on a cold container is higher, because the service-model load and credential resolution happen then.
To Reproduce
import os, statistics, time
os.environ["AWS_CONFIG_FILE"] = "/dev/null"
os.environ["AWS_SHARED_CREDENTIALS_FILE"] = "/dev/null"
os.environ["AWS_ACCESS_KEY_ID"] = "AKIAIOSFODNN7EXAMPLE"
os.environ["AWS_SECRET_ACCESS_KEY"] = "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"
os.environ["AWS_EC2_METADATA_DISABLED"] = "true"
import boto3
from botocore.config import Config
from bedrock_agentcore.memory.client import MemoryClient
REGION = "us-west-2"
CFG = Config(user_agent_extra="strands-agents") # what :184-192 builds
def pair(s): # the :195/:198 overrides
s.client("bedrock-agentcore-control", region_name=REGION, config=CFG)
s.client("bedrock-agentcore", region_name=REGION, config=CFG)
# A long-lived session the caller passes as boto_session, primed once.
WARM = boto3.Session(region_name=REGION)
pair(WARM)
def no_session_shipped(): # boto_session=None, as shipped
MemoryClient(region_name=REGION)
pair(boto3.Session(region_name=REGION))
def no_session_fixed():
s = boto3.Session(region_name=REGION)
MemoryClient(region_name=REGION, boto3_session=s)
pair(s)
def warm_session_shipped(): # boto_session=WARM, as shipped
MemoryClient(region_name=REGION)
pair(WARM)
def warm_session_fixed():
MemoryClient(region_name=REGION, boto3_session=WARM)
pair(WARM)
for name, fn in (("no session, shipped", no_session_shipped),
("no session, fixed", no_session_fixed),
("warm session, shipped", warm_session_shipped),
("warm session, fixed", warm_session_fixed)):
fn() # warm-up
samples = []
for _ in range(10):
t0 = time.perf_counter(); fn()
samples.append((time.perf_counter() - t0) * 1000)
print(f"{name:22s} {statistics.median(samples):6.1f} ms")
Run it with no AWS profile set. It makes no network calls, so the dummy keys only stop botocore from searching for real ones.
Expected behavior
MemoryClient should be built from the same session the overrides use. Hoisting line 152 above line 151 and passing the session through is enough:
session = boto_session or boto3.Session(region_name=region_name)
self.memory_client = MemoryClient(region_name=region_name, boto3_session=session)
No public signature changes. Callers who pass boto_session get the 42 to 3.3 ms drop, and callers who don't still save the second service-model load.
Two related points:
-
boto_client_configcan't be forwarded the same way.MemoryClient.__init__takes onlyregion_name,integration_sourceandboto3_session, and builds its ownConfig(user_agent_extra=...)internally. Honouring the documentedboto_client_configmeans adding a parameter there. Until then, retry and timeout config can't be set on the memory client at all. -
With
region_name=Noneand aboto_sessionpinned to one region,MemoryClient.region_nameresolves from a fresh default session while the clients actually used come fromboto_session. The attribute can disagree with the region serving the calls. Passing the session fixes that too.
Happy to test a patch against our workload. I didn't open a PR because CONTRIBUTING.md says the repo isn't accepting external ones.
Environment
bedrock-agentcore1.23.1. Also present onmainat cc980d14, the most recent commit to touch this file.- boto3 1.43.101, botocore 1.43.101
- Python 3.13.13, macOS
- Also reproduces on 1.18.1
- 主要言語
- Python
- スター
- 777
- フォーク
- 155
- 平均マージ
- 1日 12時間
- マージ済み PR(30日)
- 14
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
aws/bedrock-agentcore-sdk-python のほかの issue
-
bug high-severity
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
aws/bedrock-agentcore-sdk-python#680 ·
メンテナーはふだん 1 日以内に返信
-
[Bug] update_message fails with parameter validation error when SessionMessage.message_id is a Strands positional integer index対応中かも @citizen204 が 106 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
aws/bedrock-agentcore-sdk-python#556 ·
メンテナーはふだん 1 日以内に返信
-
CodeInterpreter should not require a region argument対応中かも @citizen204 が 121 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
aws/bedrock-agentcore-sdk-python#511 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
aws/bedrock-agentcore-sdk-python#496 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
Pydantic deprecation warning: Support for class-based `config` is deprecated, use ConfigDict instead対応中かも @citizen204 が 121 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
aws/bedrock-agentcore-sdk-python#320 · コメント 2 件 · リアクション 3 件 ·
メンテナーはふだん 1 日以内に返信
aws/bedrock-agentcore-sdk-python の issue をすべて見る
似ている issue
-
customer-reported question
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
Azure/azure-sdk-for-python#49548 · コメント 1 件 · リアクション 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
btclib-org/btclib-wallet#409 ·
メンテナーはふだん 1 日以内に返信
-
Phase 2 PSA Capability & Career Profile
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
bcgov/digital-journeys#2310 ·
-
bug good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
fastmachinelearning/hls4ml#1582 ·
メンテナーはふだん 3 日以内に返信
-
Sort modelsオープンenhancement good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
メンテナーはふだん 1 日以内に返信