Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Requests `Session.request` assumes url to be `str`

オープン
  • 何か問題がありますか？
#329 コメント 1 件 リアクション 0 件 担当者 1 名 GitHub で見る

@NathanielRN がすでに取り組んでいます。

2022年3月21日 から。

評価

この issue はまだ評価されていません。

説明

https://github.com/aws/aws-xray-sdk-python/blob/f5f9c470b189bb34f31a1d0a28f497741132b7d2/aws_xray_sdk/ext/requests/patch.py#L23
Implicitly assumes the url to be str.
In the case where you have bytes as the url (allowed by requests in stubs https://github.com/python/typeshed/blob/master/stubs/requests/requests/sessions.pyi#L88 and works fine in runtime. The official docs however don't specify a specific type https://github.com/psf/requests/blob/79f60274f7e461b8fd2f579e741f748438d7eadb/requests/sessions.py#L465) the variable goes through the following path leading to an TypeError when sampling is enabled.

https://github.com/aws/aws-xray-sdk-python/blob/f5f9c470b189bb34f31a1d0a28f497741132b7d2/aws_xray_sdk/ext/util.py#L131
Returns parsed url with type(url.hostname) -> bytes.

https://github.com/aws/aws-xray-sdk-python/blob/f5f9c470b189bb34f31a1d0a28f497741132b7d2/aws_xray_sdk/core/recorder.py#L425
Passed without any changes to report_subsegment.
https://github.com/aws/aws-xray-sdk-python/blob/f5f9c470b189bb34f31a1d0a28f497741132b7d2/aws_xray_sdk/core/recorder.py#L276
And from there passed to begin_subsegment unchanged. Here types declared in docstrings are not followed.

https://github.com/aws/aws-xray-sdk-python/blob/f5f9c470b189bb34f31a1d0a28f497741132b7d2/aws_xray_sdk/core/models/subsegment.py#L81
Then the name passes to Subsegment if sampling is enabled.

https://github.com/aws/aws-xray-sdk-python/blob/f5f9c470b189bb34f31a1d0a28f497741132b7d2/aws_xray_sdk/core/models/entity.py#L30
super().__init__ is called and we end up in Entity.__init__ with the unchanged name with type bytes.

https://github.com/aws/aws-xray-sdk-python/blob/f5f9c470b189bb34f31a1d0a28f497741132b7d2/aws_xray_sdk/core/models/entity.py#L38
Then at this line we're iterating over the items in the bytes (type(c) -> int) and checking if those are included in an str and we get a TypeError.

  File "/var/task/aws_xray_sdk/ext/requests/patch.py", line 27, in _xray_traced_requests
    return xray_recorder.record_subsegment(
  File "/var/task/aws_xray_sdk/core/recorder.py", line 428, in record_subsegment
    subsegment = self.begin_subsegment(name, namespace)
  File "/var/task/aws_xray_sdk/core/recorder.py", line 300, in begin_subsegment
    subsegment = Subsegment(name, namespace, segment)
  File "/var/task/aws_xray_sdk/core/models/subsegment.py", line 98, in __init__
    super(Subsegment, self).__init__(name)
  File "/var/task/aws_xray_sdk/core/models/entity.py", line 38, in __init__
    self.name = ''.join([c for c in name if c not in _common_invalid_name_characters])
  File "/var/task/aws_xray_sdk/core/models/entity.py", line 38, in <listcomp>
    self.name = ''.join([c for c in name if c not in _common_invalid_name_characters])
TypeError: 'in <string>' requires string as left operand, not int

The best fix is probably to sanitize the hostname once getting that off from urlparse and convert it to an str.

主要言語
Python
スター
340
フォーク
148
30日以内にマージされた PR はありません

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

aws/aws-xray-sdk-python のほかの issue

aws/aws-xray-sdk-python の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。