Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

nodejs_npm --build-in-source silently produces a dependency-less artifact for an npm workspaces monorepo

オープン
  • 何か問題がありますか？
#933 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 2 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
68/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
nodejs, python
領域
build-system, devtools

調査の方向性

Start with NodejsNpmBuilder and NodejsNpmWorkflow._actions_for_linking_source_dependencies_to_artifacts, then inspect LinkSinglePathAction.execute. Reproduce the npm workspaces build_in_source example and check how the missing packages/fn/node_modules path is handled. Done means hoisted dependencies reach the artifact or the build emits a visible warning instead of succeeding silently.

索引モデルが issue の本文から書いたものです。

説明

Description

For an npm workspaces monorepo built with --build-in-source, the NodejsNpmBuilder workflow (the plain one, not NodejsNpmEsbuildBuilder) produces an artifact with no dependencies at all, and reports success.

npm hoists the workspace package's dependencies to the monorepo root, so packages/<fn>/node_modules is never created. NodejsNpmWorkflow._actions_for_linking_source_dependencies_to_artifacts then links source_dir/node_modules into the artifacts directory, and LinkSinglePathAction.execute treats a missing source as nothing to do:

if not source_path.exists():
    # Source path doesn't exist, nothing to symlink
    LOG.debug("Source path %s does not exist, skipping generating symlink", source_path)
    return

The result is a Lambda package that fails at invoke time with Cannot find module, with only a debug-level log at build time.

Steps to reproduce

An npm workspaces monorepo, one function per workspace package:

package.json            { "workspaces": ["packages/*"] }
package-lock.json
packages/fn/package.json  { "dependencies": { "minimal-request-promise": "^1.3.0" } }
packages/fn/included.js   require("minimal-request-promise")

Build packages/fn in source:

LambdaBuilder(language="nodejs", dependency_manager="npm", application_framework=None).build(
    source_dir,          # <monorepo>/packages/fn
    artifacts_dir,
    scratch_dir,
    os.path.join(source_dir, "package.json"),
    runtime="nodejs22.x",
    build_in_source=True,
)
Observed result
artifacts dir:                  ['included.js', 'package.json']
artifacts/node_modules:         ABSENT
source packages/fn/node_modules: None            <- npm hoisted, nothing to link
monorepo root node_modules:     ['.package-lock.json', '@workspaces-monorepo', 'minimal-request-promise']
require.resolve from artifacts dir: UNRESOLVABLE

The build exits successfully.

Expected result

Either the hoisted dependencies reach the artifact, or the build says out loud that it could not find any — a warning rather than a debug log, so the failure surfaces at build time instead of at invoke time.

NodejsNpmEsbuildBuilder is unaffected: esbuild bundles the dependency into the output file, resolving it through the root node_modules.

Additional environment details
  • aws-lambda-builders develop (measured at 587257c) and unchanged by #931
  • npm 11.19.0, node 22, Linux; the hoisting behaviour is the same on npm 8/9/10

Raised out of review on #931, which changes which npm command installs those dependencies but not where npm puts them, so the gap predates it and is not made worse by it. Filing it so the workspaces coverage added there does not imply the plain workflow's artifact is covered.

主要言語
Python
スター
381
フォーク
164
平均マージ
1日 1時間
マージ済み PR（30日）
2

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

aws/aws-lambda-builders のほかの issue

aws/aws-lambda-builders の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。