[Feature]: Add a unified OtelPlugin factory with execution defaults
メンテナーはふだん 1 日以内に返信
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 25/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 停滞
- 技術スタック
- aws, java
- 領域
- backend, observability
調査の方向性
Start in the otel-plugin module and read the existing ExecutionOtelPlugin.factory(...) and InvocationOtelPlugin.factory(...) implementations, then inspect the DurableExecutionPluginFactory and ServiceLoader registration paths. Add the selector and otel provider while preserving factory metadata and configuration paths. Done means the acceptance criteria pass, including lifecycle isolation, compatibility, telemetry, examples, and documentation.
索引モデルが issue の本文から書いたものです。
説明
What would you like?
Add a single public OtelPlugin entry point for selecting the OTel view, with execution mode as the default and invocation mode as an explicit choice. Users should be able to import one name and register a factory, while existing registration APIs continue to work.
Illustrative API, using factory to make the return value explicit:
import software.amazon.lambda.durable.DurableConfig;
import software.amazon.lambda.durable.otel.OtelPlugin;
var execution = OtelPlugin.factory();
var invocation = OtelPlugin.factory(OtelPlugin.Mode.INVOCATION);
// Register one selected factory with DurableConfig:
var config = DurableConfig.builder().withPlugins(execution).build();
Support explicit execution selection and the existing OtelPluginConfig and application-owned SdkTracerProviderBuilder configuration paths as well.
Also add DURABLE_EXECUTION_PLUGINS=otel as the default execution entry point. Keep otel-execution and otel-invocation working with their existing meanings.
Possible Implementation
Implement the new entry point in otel-plugin as a small selector over ExecutionOtelPlugin.factory(...) and InvocationOtelPlugin.factory(...). Return the selected factory directly where possible, retaining its exclusive-group metadata and diagnostic identity.
The current SDK registers DurableExecutionPluginFactory objects. The new API must preserve that lifecycle: the SDK supplies InvocationInfo and creates a fresh plugin for each invocation; provider/environment state retains its existing lifetime. Do not share an invocation plugin between concurrent executions or replace the factory contract with a no-argument plugin instance constructor.
Register a ServiceLoader provider named otel that delegates to the execution factory, including its exclusivity metadata. Keep the existing providers intact. Default construction continues to use the ADOT/global-provider integration; custom provider setup passes through to the selected implementation.
Is this a breaking change?
No. Preserve all public APIs supported by the target release, including existing factory overloads, configuration types, package paths, and provider names. Retain source and binary compatibility. The new entry point must not change existing trace hierarchy, span identities, sampling, logging, or replay behavior.
Does this require an RFC?
No. This is an additive API over existing implementations; final overload naming can be settled during API review.
Additional Context
Acceptance criteria:
- Default and explicit execution selection match the existing execution factory; invocation selection matches the existing invocation factory. Reject invalid explicit mode values.
- Configuration reaches the selected factory unchanged, including global-provider and custom-builder paths.
- Existing factory registration and ServiceLoader entry points continue to work;
otelloads execution mode without handler-side OTel imports or registration. - Preserve exclusive-view validation when combining new and existing entry points, including explicit/environment combinations. Related wrapper metadata issue: https://github.com/aws/aws-durable-execution-sdk-java/issues/856.
- Exercise the public API through an initial invocation and suspension/resume, and reuse one factory across concurrent invocations to verify isolation and equivalent telemetry.
- Update Java examples and documentation for both views and environment loading. Explain that no handler-side setup still requires the plugin JAR and configured ADOT/provider/exporter; installing the package alone does not enable instrumentation.
Coordinate the API semantics and cross-language documentation with the Python and JS implementations.
Related SDK issues
- 主要言語
- Java
- スター
- 28
- フォーク
- 18
- 平均マージ
- 16時間 53分
- マージ済み PR(30日)
- 63
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
aws/aws-durable-execution-sdk-java のほかの issue
-
bug pkg:conformance
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
aws/aws-durable-execution-sdk-java#844 ·
メンテナーはふだん 1 日以内に返信
-
documentation pkg:sdk
難易度 1/5 1〜3時間 初心者へのやさしさ 88/100
aws/aws-durable-execution-sdk-java#645 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
aws/aws-durable-execution-sdk-java#300 ·
メンテナーはふだん 1 日以内に返信
-
bug pkg:telemetry
難易度 4/5 3〜5日 初心者へのやさしさ 54/100
aws/aws-durable-execution-sdk-java#877 ·
メンテナーはふだん 1 日以内に返信
-
[Bug]: ctx.map returns MapResult items as LinkedHashMap instead of the declared result type対応中かも @pcbeingused333 が 1 日前に担当しました。 オープンbug pkg:sdk
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
aws/aws-durable-execution-sdk-java#870 ·
メンテナーはふだん 1 日以内に返信
aws/aws-durable-execution-sdk-java の issue をすべて見る
似ている issue
-
needs-area-label
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100
メンテナーはふだん 2 日以内に返信
-
enhancement Java macOS
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
freerouting/freerouting#1079 ·
メンテナーはふだん 4 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
apache/maven-enforcer#1074 ·
メンテナーはふだん 1 日以内に返信
-
Gradle liquibaseDiffChangelog drops jhi_date_time_wrapper対応中かも @mraible が今日担当しました。 オープンarea: triage theme: undefined
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
jhipster/generator-jhipster#35998 ·
メンテナーはふだん 1 日以内に返信