Charts: add area charts (chartType "area")

オープン
#620 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
77/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
python
領域
backend

調査の方向性

Read the chart builder in sdpm/sdpm/engine/builder/elements/chart.py and converter in sdpm/sdpm/engine/converter/chart.py, then check the lint rules and the chart round-trip tests. Use the bar-variant and bar-series-color tests as models; update the guides and changelog listed in the issue. Done when area charts build and round-trip with stacked state and series data, lint validates area, and the specified checks pass.

索引モデルが issue の本文から書いたものです。

説明

enhancement good first issue
What problem would this solve?

Native charts support chartType bar, line, pie and donut only. Area charts are common in business decks (volume over time, stacked share of a total), and python-pptx builds them natively (XL_CHART_TYPE.AREA, AREA_STACKED). Today an agent has to fall back to a line chart, and an area chart imported with pptx_to_json is read as a bar chart that only its _chartXml keeps (_chartRebuildable: false).

Proposed solution

Add chartType: "area", with the existing stacked flag:

{
  "type": "chart", "chartType": "area",
  "x": 192, "y": 216, "width": 1536, "height": 700,
  "categories": ["Jan", "Feb", "Mar", "Apr"],
  "series": [
    {"name": "Lambda", "values": [120, 150, 180, 210], "color": "#FF9900"},
    {"name": "ECS", "values": [80, 95, 90, 130], "color": "#41B3FF"}
  ],
  "stacked": true,
  "legend": true,
  "dataLabels": false
}
  • stacked: false → XL_CHART_TYPE.AREA, stacked: true → XL_CHART_TYPE.AREA_STACKED. 100% stacked (AREA_STACKED_100) is out of scope and stays non-rebuildable.
  • Axes, valueAxis / categoryAxis, numberFormat, style (gridlines, fonts, legend position) work as for bar. Series color is the area fill.

Files to touch:

  • sdpm/sdpm/engine/builder/elements/chart.py (_add_chart): the type_map, and the series colour branch (it handles line and pie/donut separately; an area series takes a fill like a bar).
  • sdpm/sdpm/engine/converter/chart.py (extract_chart_element): map AREA / AREA_STACKED in type_map so the chart reads back as area and becomes rebuildable.
  • sdpm/sdpm/engine/schema/lint.py: add area to _CHART_TYPES, update the "Specify bar, line, pie, or donut" message, and let the "stacked is only valid for bar" rule accept area.
  • Docs: the chart section of sdpm/references/guides/slide-json-media.md (chartType list and guide list), and a new sdpm/references/guides/chart-area.md modelled on chart-line.md. If you add the guide, also add it next to chart-bar / chart-line / chart-pie in sdpm/references/guides/slide-json-spec.md and sdpm/references/workflows/composer.md.
  • CHANGELOG.md: an entry under [Unreleased] → Added.

Done when

  • chartType: "area" builds an c:areaChart (stacked and not stacked), and pptx_to_json reads it back as chartType: "area" with stacked, categories, series names, values and colours intact.
  • An edited area chart is rebuilt from its JSON: drop "area" from the kind list of TestChartsTheJsonCannotDescribe::test_edited_chart_keeps_its_type in tests/test_chart_roundtrip.py, and point the other tests in that class that use "area" at another non-rebuildable kind (radar or stacked100).
  • Lint accepts area and still rejects unknown types.
  • make lint and uv run pytest tests/test_chart_roundtrip.py -v pass.

Tests to copy: TestChartTypes::test_bar_variants and TestColors::test_bar_series_colors in tests/test_chart_roundtrip.py (they use _one_chart / _built_chart, no LibreOffice needed).

Which area?

Slide generation / engine (layouts, elements, charts)

🤖 Created by Kiro Crew

主要言語
Python
スター
136
フォーク
13
平均マージ
7時間 36分
マージ済み PR(30日)
175

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

aws-samples/sample-spec-driven-presentation-maker のほかの issue

aws-samples/sample-spec-driven-presentation-maker の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。